|
|
|
require "rails_helper"
|
|
|
|
|
|
|
|
RSpec.shared_examples "shared examples for derived fields" do |log_type|
|
|
|
|
describe "sets ethnic based on the value of ethnic_refused" do
|
|
|
|
it "is set to 17 when ethnic_group is 17" do
|
|
|
|
log = FactoryBot.build(log_type, ethnic_group: 17, ethnic: nil)
|
|
|
|
|
|
|
|
expect { log.set_derived_fields! }.to change(log, :ethnic).from(nil).to(17)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "is is not modified otherwise" do
|
|
|
|
log = FactoryBot.build(log_type, ethnic_group: nil, ethnic: nil)
|
|
|
|
|
|
|
|
expect { log.set_derived_fields! }.not_to change(log, :ethnic)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when uprn is not confirmed" do
|
|
|
|
it "derives other uprn fields correctly" do
|
|
|
|
log = FactoryBot.build(log_type, uprn_known: 1, uprn: 1, uprn_confirmed: 0)
|
|
|
|
|
|
|
|
expect { log.set_derived_fields! }.to change(log, :uprn_known).from(1).to(0)
|
|
|
|
.and change(log, :uprn).from("1").to(nil)
|
|
|
|
.and change(log, :uprn_confirmed).from(0).to(nil)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "does not affect older logs with uprn_confirmed == 0" do
|
CLDC-3787 Autocomplete address search (#2924)
* Prototype
* Remove git from dockerfile
* UPRN search too
* Revert address client and use uprn client
* Add address search to lettings too
* Updates with lettings logs
* Update copy
* Move guidance to partial
* Fix uprn return
* Delete new db file, restore old
* Lint
* Remove old db file
* Lint
* Add new db file, remove old
* JS lint
* Update schema
* Add manual entry option
* Update derived variables
* Comment out old version of find address in 2024
* Remove db column
* Add new db columns
* Update guidance partial
* Add unless to migration
* Add migration files to remove and readd
* authenticate user
* Remove file
* Delete migration files
* Add search url
* Add search url
* Fix onConfirm
* Add manual entry button instead of change skip link
* Revert "Add manual entry button instead of change skip link"
This reverts commit 22577c801aca940acfc16caf94d3159071ea8258.
* Revert "Revert "Add manual entry button instead of change skip link""
This reverts commit 9f0a2111a58e933a28105e54aba6ca08c2d043b7.
* Replace uprn question
* Update question copy
* Allow changing the address search value
* Rename address autocomplete to address search
* Add buttons to switch between address questions
* Fix controller logic
* Enable adding question numbers to page headers
* Update skip links
* Add js disabled message to select
* Alternative way to handle js disabled users
* Revert "Alternative way to handle js disabled users"
This reverts commit 10da3d61e2f89ec29ef9f9071c63eb99aa2bb482.
* Fix typo
* Fix address options for address search question
* Reuse AddressDataPresenter where appropriate
* Lint
* Remove uprn selection question tests
* Reuse UprnDataPresenter where appropriate
* CSV export, exclude address_search
* Add address search to sales and lettings factory bots
* Exclude old address questions from routing, keep as exported values
* lint
* Update uprn value
* Add address search input boolean and switch between questions
* Reword copy, remove "Find" and "Search by"
* Align address questions, add question number and question text
* Remove old wip depends on
* Update some tests
* Update migration, move default value from db to model
* Update test
* Remove binding pry
* Lint
* Update test
* Lint
* Update test
* Update routes with underscores
* Remove debugging
* Limit visible logs to user
* Add manual address entry selected variable
* Change address search min length to 3chars
* Remove binding.pry
* Update factory bots, manual_address_entry_selected to true for preexisting tests
* Update model tests
* Update sales model tests excl E-code tests
* Update address search request test
* Reuse uprn id instead of address_search
* Set manual address entry selected as false when creating test logs
* Update model test
* Update request tests and remove old questions
* Add back test
* Update services
* Update more tests
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
* Update request tests
* update model tests
* Also update sales log
* Update service csv uprn_selection values to 1
* Add tests for pages and questions
* Update test
* Update uprn_known
* Lint
* Add feature test
* Update test
* Update tests
* Remove test
* pre-consolidate migration files
* Indentation
* Controller method improvements
* Update question numbers for 2025/26
* Update question numbers tests
* consolidate and delete old migration files
* undo changes to schema.rb
* Update 2025 property information translation files
* Update answer options to show singular previously selected result if present
* Move buttons to bottom guidance partials
* Small improvements, make address search and existing search more similar
* Validate entered addresses as within England
* Update test
* Revert "Validate entered addresses as within England"
This reverts commit 2dbfbcc8a5188cde7fb0ac0dcdbc5919eefd6a12.
* Add missing button to sales address page
* Change error code
* Clear invalid options
* Edit no results message method
* Keep no result logic just change text
* Display uprn value with address value
* Still show no results message when characters entered is less than 3 rather than nothing
* Fix uprn result when query is ambiguous
* Reduce min match for address search
* Hide no result found message just before results are populated
* Prevent changing logs to 2025 with invalid addresses
* Correct attribute name
* Handle nil
* Remove custom error message
* Remove unused variables from factory
* Update tests, remove address and postcode from old find address
* Fix bug clearing uprn from see all answers
* Revert "Fix bug clearing uprn from see all answers"
This reverts commit a66c47a1abf7a429f25e0a016fedb0b92e92f15c.
* Undo changes to validation method
* Fix unchanged uprn_selection when clearing or changing uprn
* Undo a change
* Update bulk upload 2025
* Fix typo
* Remove redundant line
---------
Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
2 weeks ago
|
|
|
Timecop.freeze(Time.zone.local(2023, 4, 1)) do
|
|
|
|
log = FactoryBot.build(log_type, uprn_known: 0, uprn: nil, uprn_confirmed: 0)
|
|
|
|
allow(log.form).to receive(:start_year_2024_or_later?).and_return(false)
|
|
|
|
expect { log.set_derived_fields! }.to not_change(log, :uprn_known)
|
|
|
|
.and not_change(log, :uprn)
|
|
|
|
.and not_change(log, :uprn_confirmed)
|
|
|
|
end
|
|
|
|
Timecop.return
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|