|
|
|
FactoryBot.define do
|
|
|
|
factory :lettings_log do
|
|
|
|
assigned_to { association :user }
|
|
|
|
created_by { assigned_to }
|
|
|
|
owning_organisation { assigned_to.organisation }
|
|
|
|
managing_organisation { assigned_to.organisation }
|
|
|
|
created_at { Time.zone.today }
|
|
|
|
updated_at { Time.zone.today }
|
CLDC-3787: Autocomplete address uprn search (#2967)
* Prototype
* Remove git from dockerfile
* UPRN search too
* Revert address client and use uprn client
* Add address search to lettings too
* Updates with lettings logs
* Update copy
* Move guidance to partial
* Fix uprn return
* Delete new db file, restore old
* Lint
* Remove old db file
* Lint
* Add new db file, remove old
* JS lint
* Update schema
* Add manual entry option
* Update derived variables
* Comment out old version of find address in 2024
* Remove db column
* Add new db columns
* Update guidance partial
* Add unless to migration
* Add migration files to remove and readd
* authenticate user
* Remove file
* Delete migration files
* Add search url
* Add search url
* Fix onConfirm
* Add manual entry button instead of change skip link
* Revert "Add manual entry button instead of change skip link"
This reverts commit 22577c801aca940acfc16caf94d3159071ea8258.
* Revert "Revert "Add manual entry button instead of change skip link""
This reverts commit 9f0a2111a58e933a28105e54aba6ca08c2d043b7.
* Replace uprn question
* Update question copy
* Allow changing the address search value
* Rename address autocomplete to address search
* Add buttons to switch between address questions
* Fix controller logic
* Enable adding question numbers to page headers
* Update skip links
* Add js disabled message to select
* Alternative way to handle js disabled users
* Revert "Alternative way to handle js disabled users"
This reverts commit 10da3d61e2f89ec29ef9f9071c63eb99aa2bb482.
* Fix typo
* Fix address options for address search question
* Reuse AddressDataPresenter where appropriate
* Lint
* Remove uprn selection question tests
* Reuse UprnDataPresenter where appropriate
* CSV export, exclude address_search
* Add address search to sales and lettings factory bots
* Exclude old address questions from routing, keep as exported values
* lint
* Update uprn value
* Add address search input boolean and switch between questions
* Reword copy, remove "Find" and "Search by"
* Align address questions, add question number and question text
* Remove old wip depends on
* Update some tests
* Update migration, move default value from db to model
* Update test
* Remove binding pry
* Lint
* Update test
* Lint
* Update test
* Update routes with underscores
* Remove debugging
* Limit visible logs to user
* Add manual address entry selected variable
* Change address search min length to 3chars
* Remove binding.pry
* Update factory bots, manual_address_entry_selected to true for preexisting tests
* Update model tests
* Update sales model tests excl E-code tests
* Update address search request test
* Reuse uprn id instead of address_search
* Set manual address entry selected as false when creating test logs
* Update model test
* Update request tests and remove old questions
* Add back test
* Update services
* Update more tests
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
* Update request tests
* update model tests
* Also update sales log
* Update service csv uprn_selection values to 1
* Add tests for pages and questions
* Update test
* Update uprn_known
* Lint
* Add feature test
* Update test
* Update tests
* Remove test
* pre-consolidate migration files
* Indentation
* Controller method improvements
* Update question numbers for 2025/26
* Update question numbers tests
* consolidate and delete old migration files
* undo changes to schema.rb
* Update 2025 property information translation files
* Update answer options to show singular previously selected result if present
* Move buttons to bottom guidance partials
* Small improvements, make address search and existing search more similar
* Validate entered addresses as within England
* Update test
* Revert "Validate entered addresses as within England"
This reverts commit 2dbfbcc8a5188cde7fb0ac0dcdbc5919eefd6a12.
* Add missing button to sales address page
* Change error code
* Clear invalid options
* Edit no results message method
* Keep no result logic just change text
* Display uprn value with address value
* Still show no results message when characters entered is less than 3 rather than nothing
* Fix uprn result when query is ambiguous
* Reduce min match for address search
* Hide no result found message just before results are populated
* Prevent changing logs to 2025 with invalid addresses
* Correct attribute name
* Handle nil
* Remove custom error message
* Remove unused variables from factory
* Update tests, remove address and postcode from old find address
* Fix bug clearing uprn from see all answers
* Revert "Fix bug clearing uprn from see all answers"
This reverts commit a66c47a1abf7a429f25e0a016fedb0b92e92f15c.
* Undo changes to validation method
* Fix unchanged uprn_selection when clearing or changing uprn
* Undo a change
* Update bulk upload 2025
* Fix typo
* Remove redundant line
---------
Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
1 week ago
|
|
|
manual_address_entry_selected { true }
|
|
|
|
|
|
|
|
before(:create) do |log, _evaluator|
|
|
|
|
if log.period && !log.managing_organisation.organisation_rent_periods.exists?(rent_period: log.period)
|
|
|
|
log.managing_organisation.organisation_rent_periods << build(:organisation_rent_period, rent_period: log.period)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
trait :setup_completed do
|
|
|
|
startdate_today
|
|
|
|
renewal { 0 }
|
|
|
|
needstype { 1 }
|
|
|
|
rent_type { 1 }
|
|
|
|
declaration { 1 }
|
|
|
|
end
|
|
|
|
trait :in_progress do
|
|
|
|
setup_completed
|
|
|
|
status { 1 }
|
|
|
|
tenancycode { Faker::Name.initials(number: 10) }
|
|
|
|
postcode_full { Faker::Address.postcode }
|
|
|
|
ppostcode_full { Faker::Address.postcode }
|
|
|
|
hhmemb { 2 }
|
|
|
|
age1 { 17 }
|
|
|
|
age2 { 19 }
|
|
|
|
end
|
|
|
|
trait :duplicate do
|
|
|
|
setup_completed
|
|
|
|
status { 1 }
|
|
|
|
tenancycode { "same tenancy code" }
|
|
|
|
postcode_full { "A1 1AA" }
|
|
|
|
uprn_known { 0 }
|
|
|
|
declaration { 1 }
|
|
|
|
age1_known { 0 }
|
|
|
|
age1 { 18 }
|
|
|
|
sex1 { "M" }
|
|
|
|
hhmemb { 1 }
|
|
|
|
ecstat1 { 0 }
|
|
|
|
period { 2 }
|
|
|
|
brent { 200 }
|
|
|
|
scharge { 50 }
|
|
|
|
pscharge { 40 }
|
|
|
|
supcharg { 35 }
|
|
|
|
tcharge { 325 }
|
|
|
|
propcode { "same property code" }
|
|
|
|
startdate { Time.zone.today }
|
|
|
|
end
|
|
|
|
trait :completed do
|
|
|
|
startdate { Time.zone.today }
|
|
|
|
status { 2 }
|
|
|
|
tenancycode { Faker::Name.initials(number: 10) }
|
|
|
|
age1_known { 0 }
|
|
|
|
age1 { Faker::Number.within(range: 25..45) }
|
|
|
|
sex1 { %w[F M X R].sample }
|
|
|
|
ethnic_group { 0 }
|
|
|
|
ethnic { 2 }
|
|
|
|
national { 13 }
|
|
|
|
prevten { 6 }
|
|
|
|
ecstat1 { 0 }
|
|
|
|
hhmemb { 2 }
|
|
|
|
relat2 { "P" }
|
|
|
|
age2_known { 0 }
|
|
|
|
details_known_2 { 0 }
|
|
|
|
age2 { Faker::Number.within(range: 25..45) }
|
|
|
|
sex2 { %w[F M X R].sample }
|
|
|
|
ecstat2 { 6 }
|
|
|
|
homeless { 1 }
|
|
|
|
underoccupation_benefitcap { 0 }
|
|
|
|
leftreg { 4 }
|
|
|
|
reservist { 1 }
|
|
|
|
illness { 1 }
|
|
|
|
preg_occ { 2 }
|
|
|
|
startertenancy { 1 }
|
|
|
|
tenancylength { 2 }
|
|
|
|
tenancy { 4 }
|
|
|
|
ppostcode_full { Faker::Address.postcode }
|
|
|
|
rsnvac { 6 }
|
|
|
|
unittype_gn { 7 }
|
|
|
|
beds { 3 }
|
|
|
|
voiddate { startdate - 2.days }
|
|
|
|
offered { 2 }
|
|
|
|
wchair { 1 }
|
|
|
|
earnings { 268 }
|
|
|
|
incfreq { 1 }
|
|
|
|
benefits { 1 }
|
|
|
|
period { 2 }
|
|
|
|
brent { 200 }
|
|
|
|
scharge { 50 }
|
|
|
|
pscharge { 40 }
|
|
|
|
supcharg { 35 }
|
|
|
|
tcharge { 325 }
|
|
|
|
layear { 2 }
|
|
|
|
waityear { 7 }
|
|
|
|
postcode_known { 1 }
|
|
|
|
postcode_full { "SW1A 1AA" }
|
|
|
|
reasonpref { 1 }
|
|
|
|
cbl { 0 }
|
|
|
|
chr { 1 }
|
|
|
|
cap { 0 }
|
|
|
|
accessible_register { 0 }
|
|
|
|
reasonother { nil }
|
|
|
|
housingneeds { 1 }
|
|
|
|
housingneeds_type { 0 }
|
|
|
|
housingneeds_other { 0 }
|
|
|
|
housingneeds_a { 1 }
|
|
|
|
housingneeds_b { 0 }
|
|
|
|
housingneeds_c { 0 }
|
|
|
|
housingneeds_f { 0 }
|
|
|
|
housingneeds_g { 0 }
|
|
|
|
housingneeds_h { 0 }
|
|
|
|
illness_type_1 { 0 }
|
|
|
|
illness_type_2 { 1 }
|
|
|
|
illness_type_3 { 0 }
|
|
|
|
illness_type_4 { 0 }
|
|
|
|
illness_type_8 { 0 }
|
|
|
|
illness_type_5 { 0 }
|
|
|
|
illness_type_6 { 0 }
|
|
|
|
illness_type_7 { 0 }
|
|
|
|
illness_type_9 { 0 }
|
|
|
|
illness_type_10 { 0 }
|
|
|
|
rp_homeless { 0 }
|
|
|
|
rp_insan_unsat { 1 }
|
|
|
|
rp_medwel { 0 }
|
|
|
|
rp_hardship { 0 }
|
|
|
|
rp_dontknow { 0 }
|
|
|
|
tenancyother { nil }
|
|
|
|
net_income_value_check { nil }
|
|
|
|
void_date_value_check { 1 }
|
|
|
|
major_repairs_date_value_check { 1 }
|
|
|
|
net_income_known { 0 }
|
|
|
|
previous_la_known { 1 }
|
|
|
|
property_owner_organisation { "Test" }
|
|
|
|
property_manager_organisation { "Test" }
|
|
|
|
renewal { 0 }
|
|
|
|
rent_type { 1 }
|
|
|
|
needstype { 1 }
|
|
|
|
purchaser_code { 798_794 }
|
|
|
|
reason { 4 }
|
|
|
|
propcode { Faker::Name.initials(number: 10) }
|
|
|
|
majorrepairs { 1 }
|
|
|
|
la { "E09000003" }
|
|
|
|
prevloc { "E07000105" }
|
|
|
|
hb { 6 }
|
|
|
|
hbrentshortfall { 1 }
|
|
|
|
tshortfall { 12 }
|
|
|
|
property_relet { 0 }
|
|
|
|
mrcdate { startdate - 1.day }
|
|
|
|
incref { 0 }
|
|
|
|
armedforces { 1 }
|
|
|
|
builtype { 1 }
|
|
|
|
unitletas { 2 }
|
|
|
|
has_benefits { 1 }
|
|
|
|
is_carehome { 0 }
|
|
|
|
declaration { 1 }
|
|
|
|
first_time_property_let_as_social_housing { 0 }
|
|
|
|
referral_type { 1 }
|
|
|
|
referral { 2 }
|
|
|
|
uprn_known { 0 }
|
|
|
|
joint { 3 }
|
|
|
|
address_line1 { "Address line 1" }
|
|
|
|
town_or_city { Faker::Address.city }
|
|
|
|
ppcodenk { 1 }
|
|
|
|
tshortfall_known { 1 }
|
CLDC-3787: Autocomplete address uprn search (#2967)
* Prototype
* Remove git from dockerfile
* UPRN search too
* Revert address client and use uprn client
* Add address search to lettings too
* Updates with lettings logs
* Update copy
* Move guidance to partial
* Fix uprn return
* Delete new db file, restore old
* Lint
* Remove old db file
* Lint
* Add new db file, remove old
* JS lint
* Update schema
* Add manual entry option
* Update derived variables
* Comment out old version of find address in 2024
* Remove db column
* Add new db columns
* Update guidance partial
* Add unless to migration
* Add migration files to remove and readd
* authenticate user
* Remove file
* Delete migration files
* Add search url
* Add search url
* Fix onConfirm
* Add manual entry button instead of change skip link
* Revert "Add manual entry button instead of change skip link"
This reverts commit 22577c801aca940acfc16caf94d3159071ea8258.
* Revert "Revert "Add manual entry button instead of change skip link""
This reverts commit 9f0a2111a58e933a28105e54aba6ca08c2d043b7.
* Replace uprn question
* Update question copy
* Allow changing the address search value
* Rename address autocomplete to address search
* Add buttons to switch between address questions
* Fix controller logic
* Enable adding question numbers to page headers
* Update skip links
* Add js disabled message to select
* Alternative way to handle js disabled users
* Revert "Alternative way to handle js disabled users"
This reverts commit 10da3d61e2f89ec29ef9f9071c63eb99aa2bb482.
* Fix typo
* Fix address options for address search question
* Reuse AddressDataPresenter where appropriate
* Lint
* Remove uprn selection question tests
* Reuse UprnDataPresenter where appropriate
* CSV export, exclude address_search
* Add address search to sales and lettings factory bots
* Exclude old address questions from routing, keep as exported values
* lint
* Update uprn value
* Add address search input boolean and switch between questions
* Reword copy, remove "Find" and "Search by"
* Align address questions, add question number and question text
* Remove old wip depends on
* Update some tests
* Update migration, move default value from db to model
* Update test
* Remove binding pry
* Lint
* Update test
* Lint
* Update test
* Update routes with underscores
* Remove debugging
* Limit visible logs to user
* Add manual address entry selected variable
* Change address search min length to 3chars
* Remove binding.pry
* Update factory bots, manual_address_entry_selected to true for preexisting tests
* Update model tests
* Update sales model tests excl E-code tests
* Update address search request test
* Reuse uprn id instead of address_search
* Set manual address entry selected as false when creating test logs
* Update model test
* Update request tests and remove old questions
* Add back test
* Update services
* Update more tests
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
* Update request tests
* update model tests
* Also update sales log
* Update service csv uprn_selection values to 1
* Add tests for pages and questions
* Update test
* Update uprn_known
* Lint
* Add feature test
* Update test
* Update tests
* Remove test
* pre-consolidate migration files
* Indentation
* Controller method improvements
* Update question numbers for 2025/26
* Update question numbers tests
* consolidate and delete old migration files
* undo changes to schema.rb
* Update 2025 property information translation files
* Update answer options to show singular previously selected result if present
* Move buttons to bottom guidance partials
* Small improvements, make address search and existing search more similar
* Validate entered addresses as within England
* Update test
* Revert "Validate entered addresses as within England"
This reverts commit 2dbfbcc8a5188cde7fb0ac0dcdbc5919eefd6a12.
* Add missing button to sales address page
* Change error code
* Clear invalid options
* Edit no results message method
* Keep no result logic just change text
* Display uprn value with address value
* Still show no results message when characters entered is less than 3 rather than nothing
* Fix uprn result when query is ambiguous
* Reduce min match for address search
* Hide no result found message just before results are populated
* Prevent changing logs to 2025 with invalid addresses
* Correct attribute name
* Handle nil
* Remove custom error message
* Remove unused variables from factory
* Update tests, remove address and postcode from old find address
* Fix bug clearing uprn from see all answers
* Revert "Fix bug clearing uprn from see all answers"
This reverts commit a66c47a1abf7a429f25e0a016fedb0b92e92f15c.
* Undo changes to validation method
* Fix unchanged uprn_selection when clearing or changing uprn
* Undo a change
* Update bulk upload 2025
* Fix typo
* Remove redundant line
---------
Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
1 week ago
|
|
|
after(:build) do |log, evaluator|
|
|
|
|
if log.startdate >= Time.zone.local(2024, 4, 1)
|
|
|
|
log.nationality_all_group = 826
|
CLDC-3787: Autocomplete address uprn search (#2967)
* Prototype
* Remove git from dockerfile
* UPRN search too
* Revert address client and use uprn client
* Add address search to lettings too
* Updates with lettings logs
* Update copy
* Move guidance to partial
* Fix uprn return
* Delete new db file, restore old
* Lint
* Remove old db file
* Lint
* Add new db file, remove old
* JS lint
* Update schema
* Add manual entry option
* Update derived variables
* Comment out old version of find address in 2024
* Remove db column
* Add new db columns
* Update guidance partial
* Add unless to migration
* Add migration files to remove and readd
* authenticate user
* Remove file
* Delete migration files
* Add search url
* Add search url
* Fix onConfirm
* Add manual entry button instead of change skip link
* Revert "Add manual entry button instead of change skip link"
This reverts commit 22577c801aca940acfc16caf94d3159071ea8258.
* Revert "Revert "Add manual entry button instead of change skip link""
This reverts commit 9f0a2111a58e933a28105e54aba6ca08c2d043b7.
* Replace uprn question
* Update question copy
* Allow changing the address search value
* Rename address autocomplete to address search
* Add buttons to switch between address questions
* Fix controller logic
* Enable adding question numbers to page headers
* Update skip links
* Add js disabled message to select
* Alternative way to handle js disabled users
* Revert "Alternative way to handle js disabled users"
This reverts commit 10da3d61e2f89ec29ef9f9071c63eb99aa2bb482.
* Fix typo
* Fix address options for address search question
* Reuse AddressDataPresenter where appropriate
* Lint
* Remove uprn selection question tests
* Reuse UprnDataPresenter where appropriate
* CSV export, exclude address_search
* Add address search to sales and lettings factory bots
* Exclude old address questions from routing, keep as exported values
* lint
* Update uprn value
* Add address search input boolean and switch between questions
* Reword copy, remove "Find" and "Search by"
* Align address questions, add question number and question text
* Remove old wip depends on
* Update some tests
* Update migration, move default value from db to model
* Update test
* Remove binding pry
* Lint
* Update test
* Lint
* Update test
* Update routes with underscores
* Remove debugging
* Limit visible logs to user
* Add manual address entry selected variable
* Change address search min length to 3chars
* Remove binding.pry
* Update factory bots, manual_address_entry_selected to true for preexisting tests
* Update model tests
* Update sales model tests excl E-code tests
* Update address search request test
* Reuse uprn id instead of address_search
* Set manual address entry selected as false when creating test logs
* Update model test
* Update request tests and remove old questions
* Add back test
* Update services
* Update more tests
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
* Update request tests
* update model tests
* Also update sales log
* Update service csv uprn_selection values to 1
* Add tests for pages and questions
* Update test
* Update uprn_known
* Lint
* Add feature test
* Update test
* Update tests
* Remove test
* pre-consolidate migration files
* Indentation
* Controller method improvements
* Update question numbers for 2025/26
* Update question numbers tests
* consolidate and delete old migration files
* undo changes to schema.rb
* Update 2025 property information translation files
* Update answer options to show singular previously selected result if present
* Move buttons to bottom guidance partials
* Small improvements, make address search and existing search more similar
* Validate entered addresses as within England
* Update test
* Revert "Validate entered addresses as within England"
This reverts commit 2dbfbcc8a5188cde7fb0ac0dcdbc5919eefd6a12.
* Add missing button to sales address page
* Change error code
* Clear invalid options
* Edit no results message method
* Keep no result logic just change text
* Display uprn value with address value
* Still show no results message when characters entered is less than 3 rather than nothing
* Fix uprn result when query is ambiguous
* Reduce min match for address search
* Hide no result found message just before results are populated
* Prevent changing logs to 2025 with invalid addresses
* Correct attribute name
* Handle nil
* Remove custom error message
* Remove unused variables from factory
* Update tests, remove address and postcode from old find address
* Fix bug clearing uprn from see all answers
* Revert "Fix bug clearing uprn from see all answers"
This reverts commit a66c47a1abf7a429f25e0a016fedb0b92e92f15c.
* Undo changes to validation method
* Fix unchanged uprn_selection when clearing or changing uprn
* Undo a change
* Update bulk upload 2025
* Fix typo
* Remove redundant line
---------
Co-authored-by: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Co-authored-by: kosiakkatrina <kosiakkatrina@users.noreply.github.com>
1 week ago
|
|
|
log.uprn = evaluator.uprn || "10033558653"
|
|
|
|
log.uprn_selection = evaluator.uprn_selection || "10033558653"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
trait :export do
|
|
|
|
tenancycode { "987654" }
|
|
|
|
ppostcode_full { "LE5 1QP" }
|
|
|
|
propcode { "MYPROP" }
|
|
|
|
tenancylength { nil }
|
|
|
|
end
|
|
|
|
trait :sh do
|
|
|
|
needstype { 2 }
|
|
|
|
sheltered { 3 }
|
|
|
|
household_charge { 0 }
|
|
|
|
end
|
|
|
|
trait :sheltered_housing do
|
|
|
|
needstype { 2 }
|
|
|
|
end
|
|
|
|
trait :startdate_today do
|
|
|
|
startdate { Time.zone.today }
|
|
|
|
end
|
|
|
|
trait :deleted do
|
|
|
|
status { 4 }
|
|
|
|
discarded_at { Time.zone.now }
|
|
|
|
end
|
|
|
|
trait :imported do
|
|
|
|
old_id { Random.hex }
|
|
|
|
end
|
|
|
|
trait :with_illness_without_type do
|
|
|
|
illness { 1 }
|
|
|
|
illness_type_1 { false }
|
|
|
|
illness_type_2 { false }
|
|
|
|
illness_type_3 { false }
|
|
|
|
illness_type_4 { false }
|
|
|
|
illness_type_5 { false }
|
|
|
|
illness_type_6 { false }
|
|
|
|
illness_type_7 { false }
|
|
|
|
illness_type_8 { false }
|
|
|
|
illness_type_9 { false }
|
|
|
|
illness_type_10 { false }
|
|
|
|
end
|
|
|
|
trait :ignore_validation_errors do
|
|
|
|
to_create do |instance|
|
|
|
|
instance.valid?
|
|
|
|
instance.errors.clear
|
|
|
|
instance.save!(validate: false)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|