|
|
|
require "rails_helper"
|
|
|
|
|
|
|
|
RSpec.describe "Lettings Log Features" do
|
|
|
|
context "when searching for specific logs" do
|
|
|
|
context "when I am signed in and there are logs in the database" do
|
|
|
|
let(:user) { create(:user, last_sign_in_at: Time.zone.now) }
|
|
|
|
let!(:log_to_search) { create(:lettings_log, owning_organisation: user.organisation) }
|
|
|
|
let!(:same_organisation_log) { create(:lettings_log, owning_organisation: user.organisation) }
|
|
|
|
let!(:another_organisation_log) { create(:lettings_log) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
fill_in("user[email]", with: user.email)
|
|
|
|
fill_in("user[password]", with: user.password)
|
|
|
|
click_button("Sign in")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "displays the logs belonging to the same organisation" do
|
|
|
|
expect(page).to have_link(log_to_search.id.to_s)
|
|
|
|
expect(page).to have_link(same_organisation_log.id.to_s)
|
|
|
|
expect(page).not_to have_link(another_organisation_log.id.to_s)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when I search for a specific log" do
|
|
|
|
it "there is a search bar with a message and search button for logs" do
|
|
|
|
expect(page).to have_field("search")
|
|
|
|
expect(page).to have_content("Search by log ID, tenant code, property reference or postcode")
|
|
|
|
expect(page).to have_button("Search")
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when I fill in search information and press the search button" do
|
|
|
|
before do
|
|
|
|
fill_in("search", with: log_to_search.id)
|
|
|
|
click_button("Search")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "displays log matching the log ID" do
|
|
|
|
expect(page).to have_link(log_to_search.id.to_s)
|
|
|
|
expect(page).not_to have_link(same_organisation_log.id.to_s)
|
|
|
|
expect(page).not_to have_link(another_organisation_log.id.to_s)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when I want to clear results" do
|
|
|
|
it "there is link to clear the search results" do
|
|
|
|
expect(page).to have_link("Clear search")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "displays the logs belonging to the same organisation after I clear the search results" do
|
|
|
|
click_link("Clear search")
|
|
|
|
expect(page).to have_link(log_to_search.id.to_s)
|
|
|
|
expect(page).to have_link(same_organisation_log.id.to_s)
|
|
|
|
expect(page).not_to have_link(another_organisation_log.id.to_s)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the signed is user is a Support user" do
|
|
|
|
let(:organisation) { create(:organisation, name: "User org") }
|
|
|
|
let(:support_user) { create(:user, :support, last_sign_in_at: Time.zone.now, organisation:) }
|
|
|
|
let(:devise_notify_mailer) { DeviseNotifyMailer.new }
|
|
|
|
let(:notify_client) { instance_double(Notifications::Client) }
|
|
|
|
let(:mfa_template_id) { User::MFA_TEMPLATE_ID }
|
|
|
|
let(:otp) { "999111" }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(DeviseNotifyMailer).to receive(:new).and_return(devise_notify_mailer)
|
|
|
|
allow(devise_notify_mailer).to receive(:notify_client).and_return(notify_client)
|
|
|
|
allow(notify_client).to receive(:send_email).and_return(true)
|
|
|
|
allow(SecureRandom).to receive(:random_number).and_return(otp)
|
|
|
|
visit("/account/sign-in")
|
|
|
|
fill_in("user[email]", with: support_user.email)
|
|
|
|
fill_in("user[password]", with: support_user.password)
|
|
|
|
click_button("Sign in")
|
|
|
|
fill_in("code", with: otp)
|
|
|
|
click_button("Submit")
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when completing the setup lettings log section", :aggregate_failure do
|
|
|
|
it "includes the owning organisation and created by questions" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
select(support_user.organisation.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
select("#{support_user.name} (#{support_user.email})", from: "lettings-log-created-by-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Stock owner User org", normalize_ws: true)
|
|
|
|
expect(page).to have_content("You have answered 2 of 8 questions")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when visiting a subsection check answers page" do
|
|
|
|
let(:lettings_log) { create(:lettings_log, :setup_completed) }
|
|
|
|
|
|
|
|
it "has the correct breadcrumbs with the correct links" do
|
|
|
|
visit lettings_log_setup_check_answers_path(lettings_log)
|
|
|
|
breadcrumbs = page.find_all(".govuk-breadcrumbs__link")
|
|
|
|
expect(breadcrumbs.first.text).to eq "Logs"
|
|
|
|
expect(breadcrumbs.first[:href]).to eq lettings_logs_path
|
|
|
|
expect(breadcrumbs[1].text).to eq "Log #{lettings_log.id}"
|
|
|
|
expect(breadcrumbs[1][:href]).to eq lettings_log_path(lettings_log)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when reviewing a complete log" do
|
|
|
|
let(:lettings_log) { create(:lettings_log, :completed) }
|
|
|
|
|
|
|
|
it "has the correct breadcrumbs with the correct links" do
|
|
|
|
visit review_lettings_log_path(lettings_log)
|
|
|
|
breadcrumbs = page.find_all(".govuk-breadcrumbs__link")
|
|
|
|
expect(breadcrumbs.first.text).to eq "Logs"
|
|
|
|
expect(breadcrumbs.first[:href]).to eq lettings_logs_path
|
|
|
|
expect(breadcrumbs[1].text).to eq "Log #{lettings_log.id}"
|
|
|
|
expect(breadcrumbs[1][:href]).to eq lettings_log_path(lettings_log)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the owning organisation question isn't answered" do
|
|
|
|
it "doesn't show the managing agent question" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
click_link("Skip for now")
|
|
|
|
expect(page).not_to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the owning organisation question is answered" do
|
|
|
|
context "and the owning organisation doesn't hold stock" do
|
|
|
|
let(:managing_org) { create(:organisation, name: "Managing org") }
|
|
|
|
let!(:org_rel) { create(:organisation_relationship, parent_organisation: support_user.organisation, child_organisation: managing_org) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
support_user.organisation.update!(holds_own_stock: false)
|
|
|
|
end
|
|
|
|
|
|
|
|
it "shows the managing organisation question" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
select(support_user.organisation.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
select(managing_org.name, from: "lettings-log-managing-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Managing agent Managing org", normalize_ws: true)
|
|
|
|
expect(support_user.organisation.managing_agents).to eq([org_rel.child_organisation])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and the owning organisation does hold stock" do
|
|
|
|
before do
|
|
|
|
support_user.organisation.update!(holds_own_stock: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and the owning organisation has no managing agents" do
|
|
|
|
it "doesn't show the managing organisation question" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
select(support_user.organisation.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
expect(page).not_to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).not_to have_content("Managing agent ")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and the owning organisation has 1 or more managing agents" do
|
|
|
|
let(:managing_org1) { create(:organisation, name: "Managing org 1") }
|
|
|
|
let!(:org_rel1) { create(:organisation_relationship, parent_organisation: support_user.organisation, child_organisation: managing_org1) }
|
|
|
|
|
|
|
|
it "does show the managing organisation question" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
select(support_user.organisation.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
select(managing_org1.name, from: "lettings-log-managing-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Managing agent Managing org 1", normalize_ws: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and the owning organisation has 2 or more managing agents" do
|
|
|
|
let(:managing_org2) { create(:organisation, name: "Managing org 2") }
|
|
|
|
let!(:org_rel2) { create(:organisation_relationship, parent_organisation: support_user.organisation, child_organisation: managing_org2) }
|
|
|
|
|
|
|
|
context "and the organisation relationship for the selected managing agent is deleted" do
|
|
|
|
it "doesn't change the CYA page text to be 'You didn't answer this question'" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
select(support_user.organisation.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
select(managing_org1.name, from: "lettings-log-managing-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Managing agent Managing org 1", normalize_ws: true)
|
|
|
|
org_rel1.destroy!
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Managing agent Managing org 1", normalize_ws: true)
|
|
|
|
expect(support_user.organisation.managing_agents).to eq([org_rel2.child_organisation])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the signed is user is not a Support user" do
|
|
|
|
let(:organisation) { create(:organisation, name: "User org") }
|
|
|
|
let(:user) { create(:user, :data_coordinator, name: "User name", organisation:) }
|
|
|
|
let(:devise_notify_mailer) { DeviseNotifyMailer.new }
|
|
|
|
let(:notify_client) { instance_double(Notifications::Client) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
allow(DeviseNotifyMailer).to receive(:new).and_return(devise_notify_mailer)
|
|
|
|
allow(devise_notify_mailer).to receive(:notify_client).and_return(notify_client)
|
|
|
|
allow(notify_client).to receive(:send_email).and_return(true)
|
|
|
|
visit("/account/sign-in")
|
|
|
|
fill_in("user[email]", with: user.email)
|
|
|
|
fill_in("user[password]", with: user.password)
|
|
|
|
click_button("Sign in")
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when completing the setup log section" do
|
|
|
|
context "and there is at most 1 potential stock owner" do
|
|
|
|
it "does not include the owning organisation and includes the created by questions" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
select(user.name, from: "lettings-log-created-by-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/needs-type")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).not_to have_content("Stock owner ")
|
|
|
|
expect(page).not_to have_content("Log owner ")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and there are 2 or more potential stock owners" do
|
|
|
|
let(:owning_org1) { create(:organisation, name: "Owning org 1") }
|
|
|
|
let!(:org_rel1) { create(:organisation_relationship, child_organisation: user.organisation, parent_organisation: owning_org1) }
|
|
|
|
|
|
|
|
it "does include the owning organisation question" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/stock-owner")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Stock owner User org", normalize_ws: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and there are 3 or more potential stock owners" do
|
|
|
|
let(:owning_org2) { create(:organisation, name: "Owning org 2") }
|
|
|
|
let!(:org_rel2) { create(:organisation_relationship, child_organisation: user.organisation, parent_organisation: owning_org2) }
|
|
|
|
|
|
|
|
context "and the organisation relationship for the selected stock owner is deleted" do
|
|
|
|
it "doesn't change the CYA page text to be 'You didn't answer this question'" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/stock-owner")
|
|
|
|
select(owning_org1.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Stock owner Owning org 1", normalize_ws: true)
|
|
|
|
org_rel1.destroy!
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Stock owner Owning org 1", normalize_ws: true)
|
|
|
|
expect(user.organisation.stock_owners).to eq([org_rel2.parent_organisation])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the current user's organisation doesn't hold stock" do
|
|
|
|
let(:owning_org1) { create(:organisation, name: "Owning org 1") }
|
|
|
|
let(:owning_org2) { create(:organisation, name: "Owning org 2") }
|
|
|
|
let!(:org_rel1) { create(:organisation_relationship, child_organisation: user.organisation, parent_organisation: owning_org1) }
|
|
|
|
let!(:org_rel2) { create(:organisation_relationship, child_organisation: user.organisation, parent_organisation: owning_org2) }
|
|
|
|
|
|
|
|
it "shows the managing organisation question" do
|
|
|
|
user.organisation.update!(holds_own_stock: false)
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/stock-owner")
|
|
|
|
select(owning_org1.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
select(user.organisation.name, from: "lettings-log-managing-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
|
|
|
|
expect(page).to have_content("Managing agent User org", normalize_ws: true)
|
|
|
|
expect(user.organisation.stock_owners).to eq([org_rel1.parent_organisation, org_rel2.parent_organisation])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when the current user's organisation does hold stock" do
|
|
|
|
let!(:owning_org) { create(:organisation, name: "Owning org") }
|
|
|
|
let!(:org_rel1) { create(:organisation_relationship, child_organisation: user.organisation, parent_organisation: owning_org) }
|
|
|
|
|
|
|
|
before do
|
|
|
|
user.organisation.update!(holds_own_stock: true)
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and the user's organisation has no managing agents" do
|
|
|
|
it "doesn't show the managing organisation question" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/stock-owner")
|
|
|
|
select(owning_org.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
expect(page).not_to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).not_to have_content("Managing agent ")
|
|
|
|
expect(user.organisation.stock_owners).to eq([org_rel1.parent_organisation])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "and the user's organisation has 1 or more managing agents" do
|
|
|
|
let(:managing_org) { create(:organisation, name: "Managing org") }
|
|
|
|
let!(:org_rel2) { create(:organisation_relationship, parent_organisation: user.organisation, child_organisation: managing_org) }
|
|
|
|
|
|
|
|
it "does show the managing organisation question" do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Set up this lettings log")
|
|
|
|
log_id = page.current_path.scan(/\d/).join
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/stock-owner")
|
|
|
|
select(user.organisation.name, from: "lettings-log-owning-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
expect(page).to have_current_path("/lettings-logs/#{log_id}/managing-organisation")
|
|
|
|
select(managing_org.name, from: "lettings-log-managing-organisation-id-field")
|
|
|
|
click_button("Save and continue")
|
|
|
|
visit("lettings-logs/#{log_id}/setup/check-answers")
|
|
|
|
expect(page).to have_content("Managing agent Managing org", normalize_ws: true)
|
|
|
|
expect(user.organisation.managing_agents).to eq([org_rel2.child_organisation])
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
context "when returning to the list of logs via breadcrumbs link" do
|
|
|
|
before do
|
|
|
|
visit("/lettings-logs")
|
|
|
|
click_button("Create a new lettings log")
|
|
|
|
click_link("Logs")
|
|
|
|
end
|
|
|
|
|
|
|
|
it "navigates you to the lettings logs page" do
|
|
|
|
expect(page).to have_current_path("/lettings-logs")
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|