From 00fc3db3f367bd2ab155510ac8b779f510de9f10 Mon Sep 17 00:00:00 2001
From: baarkerlounger <db@slothlife.xyz>
Date: Mon, 14 Mar 2022 09:20:57 +0000
Subject: [PATCH] Change method to hash constant

---
 app/models/case_log.rb | 38 ++++++++++++--------------------------
 1 file changed, 12 insertions(+), 26 deletions(-)

diff --git a/app/models/case_log.rb b/app/models/case_log.rb
index 5a3274990..e43c8a32f 100644
--- a/app/models/case_log.rb
+++ b/app/models/case_log.rb
@@ -40,6 +40,17 @@ class CaseLog < ApplicationRecord
   RENT_TYPE_MAPPING_LABELS = { 1 => "Social Rent", 2 => "Affordable Rent", 3 => "Intermediate Rent" }.freeze
   HAS_BENEFITS_OPTIONS = [0, 1, 2, 3].freeze
   STATUS = { "not_started" => 0, "in_progress" => 1, "completed" => 2 }.freeze
+  RENT_AND_CHARGES_PERIOD_LABEL = {
+    0 => "Every 2 weeks",
+    1 => "Every 4 weeks",
+    2 => "Every calendar month",
+    3 => "Weekly for 50 weeks",
+    4 => "Weekly for 49 weeks",
+    5 => "Weekly for 48 weeks",
+    6 => "Weekly for 47 weeks",
+    7 => "Weekly for 46 weeks",
+    8 => "Weekly for 52 weeks",
+  }.freeze
   enum status: STATUS
 
   def form
@@ -88,7 +99,7 @@ class CaseLog < ApplicationRecord
   def weekly_value(field_value)
     return unless field_value && period
 
-    case period_label
+    case RENT_AND_CHARGES_PERIOD_LABEL[period]
     when "Every 2 weeks"
       field_value / 2
     when "Every 4 weeks"
@@ -256,31 +267,6 @@ class CaseLog < ApplicationRecord
     reason == 1
   end
 
-  def period_label
-    return unless period
-
-    case period
-    when 0
-      "Every 2 weeks"
-    when 1
-      "Every 4 weeks"
-    when 2
-      "Every calendar month"
-    when 3
-      "Weekly for 50 weeks"
-    when 4
-      "Weekly for 49 weeks"
-    when 5
-      "Weekly for 48 weeks"
-    when 6
-      "Weekly for 47 weeks"
-    when 7
-      "Weekly for 46 weeks"
-    when 8
-      "Weekly for 52 weeks"
-    end
-  end
-
 private
 
   PIO = Postcodes::IO.new