Browse Source

CLDC-4177: use correct shared field count

pull/3144/head
Nat Dean-Lewis 1 week ago
parent
commit
048634f4f1
  1. 2
      app/helpers/bulk_upload/sales_log_to_csv.rb
  2. 8
      spec/services/bulk_upload/sales/year2026/csv_parser_spec.rb

2
app/helpers/bulk_upload/sales_log_to_csv.rb

@ -70,7 +70,7 @@ class BulkUpload::SalesLogToCsv
when 2025 when 2025
(1..121).to_a (1..121).to_a
when 2026 when 2026
(1..BulkUpload::Lettings::Year2026::CsvParser::FIELDS).to_a (1..BulkUpload::Sales::Year2026::CsvParser::FIELDS).to_a
else else
raise NotImplementedError "No mapping function implemented for year #{year}" raise NotImplementedError "No mapping function implemented for year #{year}"
end end

8
spec/services/bulk_upload/sales/year2026/csv_parser_spec.rb

@ -15,8 +15,8 @@ RSpec.describe BulkUpload::Sales::Year2026::CsvParser do
file.write("Can be empty?\n") file.write("Can be empty?\n")
file.write("Type of letting the question applies to\n") file.write("Type of letting the question applies to\n")
file.write("Duplicate check field?\n") file.write("Duplicate check field?\n")
file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2025)) file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2026))
file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2025)) file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2026))
file.write("\n") file.write("\n")
file.rewind file.rewind
end end
@ -81,8 +81,8 @@ RSpec.describe BulkUpload::Sales::Year2026::CsvParser do
file.write("Can be empty?\n") file.write("Can be empty?\n")
file.write("Type of letting the question applies to\n") file.write("Type of letting the question applies to\n")
file.write("Duplicate check field?\n") file.write("Duplicate check field?\n")
file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2025, seed:)) file.write(BulkUpload::SalesLogToCsv.new(log:).default_field_numbers_row_for_year(2026, seed:))
file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2025, seed:)) file.write(BulkUpload::SalesLogToCsv.new(log:).to_year_csv_row(2026, seed:))
file.rewind file.rewind
end end

Loading…
Cancel
Save