From 070f8a3d04b79421bd2aa36d462dfc532e5bd257 Mon Sep 17 00:00:00 2001 From: baarkerlounger <5101747+baarkerlounger@users.noreply.github.com> Date: Thu, 31 Mar 2022 14:03:09 +0100 Subject: [PATCH] CLDC-1014: Add Pagination for Logs Index (#438) * Add Pagy pagination to logs index * Add result count * Show total count at top * Replace view spec with request spec * More logs context * Make sure we have next/prev * Add total count * Generisize * Remove pagination indicators when only 1 page * Add pagination to title * Whole pagination nav only shows if > 1 page * Dry up paginated titles * Update style namespace --- Gemfile | 2 + Gemfile.lock | 3 + app/controllers/case_logs_controller.rb | 4 +- app/frontend/styles/_pagination.scss | 135 ++++++++++++ app/frontend/styles/application.scss | 1 + app/helpers/application_helper.rb | 15 +- app/views/case_logs/_log_list.html.erb | 2 +- app/views/case_logs/index.html.erb | 3 +- app/views/layouts/application.html.erb | 2 +- app/views/pagy/_nav.html.erb | 40 ++++ config/initializers/pagy.rb | 235 +++++++++++++++++++++ spec/helpers/application_helper_spec.rb | 29 ++- spec/requests/case_logs_controller_spec.rb | 101 ++++++++- spec/views/case_log_index_view_spec.rb | 19 -- 14 files changed, 554 insertions(+), 37 deletions(-) create mode 100644 app/frontend/styles/_pagination.scss create mode 100644 app/views/pagy/_nav.html.erb create mode 100644 config/initializers/pagy.rb delete mode 100644 spec/views/case_log_index_view_spec.rb diff --git a/Gemfile b/Gemfile index 65fc882d1..e08f126a0 100644 --- a/Gemfile +++ b/Gemfile @@ -59,6 +59,8 @@ gem "redis" # Receive exceptions and configure alerts gem "sentry-rails" gem "sentry-ruby" +# Pagination +gem "pagy" group :development, :test do # Check gems for known vulnerabilities diff --git a/Gemfile.lock b/Gemfile.lock index b95c524e9..b09b5b1da 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -266,6 +266,8 @@ GEM childprocess (>= 0.6.3, < 5) iniparse (~> 1.4) rexml (~> 3.2) + pagy (5.10.1) + activesupport paper_trail (12.3.0) activerecord (>= 5.2) request_store (~> 1.1) @@ -486,6 +488,7 @@ DEPENDENCIES listen (~> 3.3) notifications-ruby-client overcommit (>= 0.37.0) + pagy paper_trail paper_trail-globalid pg (~> 1.1) diff --git a/app/controllers/case_logs_controller.rb b/app/controllers/case_logs_controller.rb index f635826bc..1f84d7a15 100644 --- a/app/controllers/case_logs_controller.rb +++ b/app/controllers/case_logs_controller.rb @@ -1,11 +1,13 @@ class CaseLogsController < ApplicationController + include Pagy::Backend + skip_before_action :verify_authenticity_token, if: :json_api_request? before_action :authenticate, if: :json_api_request? before_action :authenticate_user!, unless: :json_api_request? before_action :find_resource, except: %i[create index edit] def index - @case_logs = current_user.case_logs + @pagy, @case_logs = pagy(current_user.case_logs) end def create diff --git a/app/frontend/styles/_pagination.scss b/app/frontend/styles/_pagination.scss new file mode 100644 index 000000000..e44bfae1d --- /dev/null +++ b/app/frontend/styles/_pagination.scss @@ -0,0 +1,135 @@ + +// https://github.com/alphagov/govuk-frontend/blob/add-pagination-prototype/src/govuk/components/pagination/_index.scss +.app-pagination { + border-top: 1px solid $govuk-border-colour; + margin-top: govuk-spacing(2); + padding-top: govuk-spacing(2); + text-align: center; + + @include govuk-media-query($from: tablet) { + // Hide whitespace between elements + font-size: 0; + + // Trick to remove the need for floats + text-align: justify; + + &:after { + content: " "; + display: inline-block; + width: 100%; + } + } +} + +.app-pagination__list { + margin: 0 govuk-spacing(-3); + padding: 0; + list-style: none; + + @include govuk-media-query($from: tablet) { + display: inline-block; + margin-bottom: 0; + } +} + +.app-pagination__results { + @include govuk-font(19); + margin-top: 0; + margin-bottom: govuk-spacing(4); + padding: govuk-spacing(1) 0; + + @include govuk-media-query($from: tablet) { + display: inline-block; + } +} + +.app-pagination__item { + @include govuk-font(19); + display: inline-block; + margin-bottom: govuk-spacing(4); + + // Hide items on small screens + @include govuk-media-query($until: tablet) { + display: none; + } +} + +// Only show previous, next, first, last and current items on mobile +.app-pagination__item--current, +.app-pagination__item--divider, +.app-pagination__item--prev, +.app-pagination__item--next, +.app-pagination__item:nth-child(2), +.app-pagination__item:nth-last-child(2) { + @include govuk-media-query($until: tablet) { + display: inline-block; + } +} + +.app-pagination__item--current, +.app-pagination__item--divider { + box-sizing: border-box; + font-weight: bold; + min-width: govuk-spacing(8); + min-height: govuk-spacing(4); + padding: govuk-spacing(2); + text-align: center; +} + +.app-pagination__item--divider { + margin: 0 govuk-spacing(-4); + padding-right: 0; + padding-left: 0; + color: $govuk-secondary-text-colour; + pointer-events: none; +} + +.app-pagination__link { + @include govuk-link-common; + @include govuk-link-style-no-underline; + box-sizing: border-box; + color: $govuk-link-colour; + display: block; + min-width: govuk-spacing(8); + min-height: govuk-spacing(4); + padding: govuk-spacing(2); + text-align: center; + + .app-pagination__link-label { + @include govuk-font($size: 16, $weight: "regular"); + display: block; + padding-left: 32px; + text-decoration: underline; + } + + &:hover .app-pagination__link-label { + @include govuk-link-hover-decoration; + } + + &:focus { + box-shadow: 0 0 $govuk-focus-colour, 0 4px $govuk-focus-text-colour; + text-decoration: underline; + } + + &:hover:not(:focus) { + background-color: govuk-colour("light-grey", $legacy: "grey-4"); + } +} + +.app-pagination__icon { + fill: currentColor; +} + +.app-pagination__item--prev .app-pagination__link, +.app-pagination__item--next .app-pagination__link { + padding: govuk-spacing(2) govuk-spacing(3); + font-weight: bold; +} + +.app-pagination__item--prev .app-pagination__icon { + margin-right: govuk-spacing(2); +} + +.app-pagination__item--next .app-pagination__icon { + margin-left: govuk-spacing(2); +} diff --git a/app/frontend/styles/application.scss b/app/frontend/styles/application.scss index 6b1d9cc81..17a5a97cf 100644 --- a/app/frontend/styles/application.scss +++ b/app/frontend/styles/application.scss @@ -22,6 +22,7 @@ $govuk-global-styles: true; @import "table-group"; @import "task-list"; @import "template"; +@import "pagination"; @import "panel"; // Turbo diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 1e8f2a07d..3b1332b28 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -1,9 +1,20 @@ module ApplicationHelper - def browser_title(title, *resources) + include Pagy::Frontend + + def browser_title(title, pagy, *resources) if resources.any? { |r| r.present? && r.errors.present? } "Error: #{[title, t('service_name'), 'GOV.UK'].select(&:present?).join(' - ')}" else - [title, t("service_name"), "GOV.UK"].select(&:present?).join(" - ") + [paginated_title(title, pagy), t("service_name"), "GOV.UK"].select(&:present?).join(" - ") end end + +private + + def paginated_title(title, pagy) + return unless title + return title unless pagy && pagy.pages > 1 + + title + " (page #{pagy.page} of #{pagy.pages})" + end end diff --git a/app/views/case_logs/_log_list.html.erb b/app/views/case_logs/_log_list.html.erb index 55b66fc81..3029e5e9c 100644 --- a/app/views/case_logs/_log_list.html.erb +++ b/app/views/case_logs/_log_list.html.erb @@ -1,6 +1,6 @@
- <%= case_logs.size %> <%= title.downcase %> + <%= pagy.count %> total <%= title.downcase %>
diff --git a/app/views/case_logs/index.html.erb b/app/views/case_logs/index.html.erb index 64cfc7146..b1d40c173 100644 --- a/app/views/case_logs/index.html.erb +++ b/app/views/case_logs/index.html.erb @@ -10,5 +10,6 @@ <% if @case_logs.present? %> - <%= render partial: "log_list", locals: { case_logs: @case_logs, title: "Logs" } %> + <%= render partial: "log_list", locals: { case_logs: @case_logs, title: "Logs", pagy: @pagy } %> + <%== render partial: 'pagy/nav', locals: { pagy: @pagy, item_name: "logs" } %> <% end %> diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index f47c55cac..66ba7ab59 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -1,7 +1,7 @@ - <%= browser_title(yield(:title), @admin_user, @user, @organisation, @case_log, @resource) %> + <%= browser_title(yield(:title), @pagy, @admin_user, @user, @organisation, @case_log, @resource) %> <%= csrf_meta_tags %> <%= csp_meta_tag %> <%= tag :meta, name: 'viewport', content: 'width=device-width, initial-scale=1' %> diff --git a/app/views/pagy/_nav.html.erb b/app/views/pagy/_nav.html.erb new file mode 100644 index 000000000..1dda448d2 --- /dev/null +++ b/app/views/pagy/_nav.html.erb @@ -0,0 +1,40 @@ +<% link = pagy_link_proc(pagy) -%> +<% if pagy.pages > 1 %> + +<% end %> diff --git a/config/initializers/pagy.rb b/config/initializers/pagy.rb new file mode 100644 index 000000000..896a19196 --- /dev/null +++ b/config/initializers/pagy.rb @@ -0,0 +1,235 @@ +# frozen_string_literal: true + +# Pagy initializer file (5.10.1) +# Customize only what you really need and notice that the core Pagy works also without any of the following lines. +# Should you just cherry pick part of this file, please maintain the require-order of the extras + +# Pagy DEFAULT Variables +# See https://ddnexus.github.io/pagy/api/pagy#variables +# All the Pagy::DEFAULT are set for all the Pagy instances but can be overridden per instance by just passing them to +# Pagy.new|Pagy::Countless.new|Pagy::Calendar::*.new or any of the #pagy* controller methods + +# Instance variables +# See https://ddnexus.github.io/pagy/api/pagy#instance-variables +# Pagy::DEFAULT[:page] = 1 # default +# Pagy::DEFAULT[:items] = 20 # default +# Pagy::DEFAULT[:outset] = 0 # default + +# Other Variables +# See https://ddnexus.github.io/pagy/api/pagy#other-variables +# Pagy::DEFAULT[:size] = [1,4,4,1] # default +# Pagy::DEFAULT[:page_param] = :page # default +# The :params can be also set as a lambda e.g ->(params){ params.exclude('useless').merge!('custom' => 'useful') } +# Pagy::DEFAULT[:params] = {} # default +# Pagy::DEFAULT[:fragment] = '#fragment' # example +# Pagy::DEFAULT[:link_extra] = 'data-remote="true"' # example +# Pagy::DEFAULT[:i18n_key] = 'pagy.item_name' # default +# Pagy::DEFAULT[:cycle] = true # example + +# Extras +# See https://ddnexus.github.io/pagy/extras + +# Backend Extras + +# Array extra: Paginate arrays efficiently, avoiding expensive array-wrapping and without overriding +# See https://ddnexus.github.io/pagy/extras/array +# require 'pagy/extras/array' + +# Calendar extra: Add pagination filtering by calendar time unit (year, quarter, month, week, day) +# See https://ddnexus.github.io/pagy/extras/calendar +# require 'pagy/extras/calendar' +# Default for each unit +# Pagy::Calendar::Year::DEFAULT[:order] = :asc # Time direction of pagination +# Pagy::Calendar::Year::DEFAULT[:format] = '%Y' # strftime format +# +# Pagy::Calendar::Quarter::DEFAULT[:order] = :asc # Time direction of pagination +# Pagy::Calendar::Quarter::DEFAULT[:format] = '%Y-Q%q' # strftime format +# +# Pagy::Calendar::Month::DEFAULT[:order] = :asc # Time direction of pagination +# Pagy::Calendar::Month::DEFAULT[:format] = '%Y-%m' # strftime format +# +# Pagy::Calendar::Week::DEFAULT[:order] = :asc # Time direction of pagination +# Pagy::Calendar::Week::DEFAULT[:format] = '%Y-%W' # strftime format +# +# Pagy::Calendar::Day::DEFAULT[:order] = :asc # Time direction of pagination +# Pagy::Calendar::Day::DEFAULT[:format] = '%Y-%m-%d' # strftime format +# +# Uncomment the following lines, if you need calendar localization without using the I18n extra +# module LocalizePagyCalendar +# def localize(time, opts) +# ::I18n.l(time, **opts) +# end +# end +# Pagy::Calendar.prepend LocalizePagyCalendar + +# Countless extra: Paginate without any count, saving one query per rendering +# See https://ddnexus.github.io/pagy/extras/countless +# require 'pagy/extras/countless' +# Pagy::DEFAULT[:countless_minimal] = false # default (eager loading) + +# Elasticsearch Rails extra: Paginate `ElasticsearchRails::Results` objects +# See https://ddnexus.github.io/pagy/extras/elasticsearch_rails +# Default :pagy_search method: change only if you use also +# the searchkick or meilisearch extra that defines the same +# Pagy::DEFAULT[:elasticsearch_rails_pagy_search] = :pagy_search +# Default original :search method called internally to do the actual search +# Pagy::DEFAULT[:elasticsearch_rails_search] = :search +# require 'pagy/extras/elasticsearch_rails' + +# Headers extra: http response headers (and other helpers) useful for API pagination +# See http://ddnexus.github.io/pagy/extras/headers +# require 'pagy/extras/headers' +# Pagy::DEFAULT[:headers] = { page: 'Current-Page', +# items: 'Page-Items', +# count: 'Total-Count', +# pages: 'Total-Pages' } # default + +# Meilisearch extra: Paginate `Meilisearch` result objects +# See https://ddnexus.github.io/pagy/extras/meilisearch +# Default :pagy_search method: change only if you use also +# the elasticsearch_rails or searchkick extra that define the same method +# Pagy::DEFAULT[:meilisearch_pagy_search] = :pagy_search +# Default original :search method called internally to do the actual search +# Pagy::DEFAULT[:meilisearch_search] = :ms_search +# require 'pagy/extras/meilisearch' + +# Metadata extra: Provides the pagination metadata to Javascript frameworks like Vue.js, react.js, etc. +# See https://ddnexus.github.io/pagy/extras/metadata +# you must require the shared internal extra (BEFORE the metadata extra) ONLY if you need also the :sequels +# require 'pagy/extras/shared' +# require 'pagy/extras/metadata' +# For performance reasons, you should explicitly set ONLY the metadata you use in the frontend +# Pagy::DEFAULT[:metadata] = %i[scaffold_url page prev next last] # example + +# Searchkick extra: Paginate `Searchkick::Results` objects +# See https://ddnexus.github.io/pagy/extras/searchkick +# Default :pagy_search method: change only if you use also +# the elasticsearch_rails or meilisearch extra that defines the same +# DEFAULT[:searchkick_pagy_search] = :pagy_search +# Default original :search method called internally to do the actual search +# Pagy::DEFAULT[:searchkick_search] = :search +# require 'pagy/extras/searchkick' +# uncomment if you are going to use Searchkick.pagy_search +# Searchkick.extend Pagy::Searchkick + +# Frontend Extras + +# Bootstrap extra: Add nav, nav_js and combo_nav_js helpers and templates for Bootstrap pagination +# See https://ddnexus.github.io/pagy/extras/bootstrap +# require 'pagy/extras/bootstrap' + +# Bulma extra: Add nav, nav_js and combo_nav_js helpers and templates for Bulma pagination +# See https://ddnexus.github.io/pagy/extras/bulma +# require 'pagy/extras/bulma' + +# Foundation extra: Add nav, nav_js and combo_nav_js helpers and templates for Foundation pagination +# See https://ddnexus.github.io/pagy/extras/foundation +# require 'pagy/extras/foundation' + +# Materialize extra: Add nav, nav_js and combo_nav_js helpers for Materialize pagination +# See https://ddnexus.github.io/pagy/extras/materialize +# require 'pagy/extras/materialize' + +# Navs extra: Add nav_js and combo_nav_js javascript helpers +# Notice: the other frontend extras add their own framework-styled versions, +# so require this extra only if you need the unstyled version +# See https://ddnexus.github.io/pagy/extras/navs +# require 'pagy/extras/navs' + +# Semantic extra: Add nav, nav_js and combo_nav_js helpers for Semantic UI pagination +# See https://ddnexus.github.io/pagy/extras/semantic +# require 'pagy/extras/semantic' + +# UIkit extra: Add nav helper and templates for UIkit pagination +# See https://ddnexus.github.io/pagy/extras/uikit +# require 'pagy/extras/uikit' + +# Multi size var used by the *_nav_js helpers +# See https://ddnexus.github.io/pagy/extras/navs#steps +# Pagy::DEFAULT[:steps] = { 0 => [2,3,3,2], 540 => [3,5,5,3], 720 => [5,7,7,5] } # example + +# Feature Extras + +# Gearbox extra: Automatically change the number of items per page depending on the page number +# See https://ddnexus.github.io/pagy/extras/gearbox +# require 'pagy/extras/gearbox' +# set to false only if you want to make :gearbox_extra an opt-in variable +# Pagy::DEFAULT[:gearbox_extra] = false # default true +# Pagy::DEFAULT[:gearbox_items] = [15, 30, 60, 100] # default + +# Items extra: Allow the client to request a custom number of items per page with an optional selector UI +# See https://ddnexus.github.io/pagy/extras/items +# require 'pagy/extras/items' +# set to false only if you want to make :items_extra an opt-in variable +# Pagy::DEFAULT[:items_extra] = false # default true +# Pagy::DEFAULT[:items_param] = :items # default +# Pagy::DEFAULT[:max_items] = 100 # default + +# Overflow extra: Allow for easy handling of overflowing pages +# See https://ddnexus.github.io/pagy/extras/overflow +# require 'pagy/extras/overflow' +# Pagy::DEFAULT[:overflow] = :empty_page # default (other options: :last_page and :exception) + +# Support extra: Extra support for features like: incremental, infinite, auto-scroll pagination +# See https://ddnexus.github.io/pagy/extras/support +# require 'pagy/extras/support' + +# Trim extra: Remove the page=1 param from links +# See https://ddnexus.github.io/pagy/extras/trim +# require 'pagy/extras/trim' +# set to false only if you want to make :trim_extra an opt-in variable +# Pagy::DEFAULT[:trim_extra] = false # default true + +# Standalone extra: Use pagy in non Rack environment/gem +# See https://ddnexus.github.io/pagy/extras/standalone +# require 'pagy/extras/standalone' +# Pagy::DEFAULT[:url] = 'http://www.example.com/subdir' # optional default + +# Rails +# Enable the .js file required by the helpers that use javascript +# (pagy*_nav_js, pagy*_combo_nav_js, and pagy_items_selector_js) +# See https://ddnexus.github.io/pagy/extras#javascript + +# With the asset pipeline +# Sprockets need to look into the pagy javascripts dir, so add it to the assets paths +# Rails.application.config.assets.paths << Pagy.root.join('javascripts') + +# I18n + +# Pagy internal I18n: ~18x faster using ~10x less memory than the i18n gem +# See https://ddnexus.github.io/pagy/api/frontend#i18n +# Notice: No need to configure anything in this section if your app uses only "en" +# or if you use the i18n extra below +# +# Examples: +# load the "de" built-in locale: +# Pagy::I18n.load(locale: 'de') +# +# load the "de" locale defined in the custom file at :filepath: +# Pagy::I18n.load(locale: 'de', filepath: 'path/to/pagy-de.yml') +# +# load the "de", "en" and "es" built-in locales: +# (the first passed :locale will be used also as the default_locale) +# Pagy::I18n.load({ locale: 'de' }, +# { locale: 'en' }, +# { locale: 'es' }) +# +# load the "en" built-in locale, a custom "es" locale, +# and a totally custom locale complete with a custom :pluralize proc: +# (the first passed :locale will be used also as the default_locale) +# Pagy::I18n.load({ locale: 'en' }, +# { locale: 'es', filepath: 'path/to/pagy-es.yml' }, +# { locale: 'xyz', # not built-in +# filepath: 'path/to/pagy-xyz.yml', +# pluralize: lambda{ |count| ... } ) + +# I18n extra: uses the standard i18n gem which is ~18x slower using ~10x more memory +# than the default pagy internal i18n (see above) +# See https://ddnexus.github.io/pagy/extras/i18n +# require 'pagy/extras/i18n' + +# Default i18n key +# Pagy::DEFAULT[:i18n_key] = 'pagy.item_name' # default + +# When you are done setting your own default freeze it, so it will not get changed accidentally +Pagy::DEFAULT.freeze diff --git a/spec/helpers/application_helper_spec.rb b/spec/helpers/application_helper_spec.rb index 3815474ad..b5cde06ce 100644 --- a/spec/helpers/application_helper_spec.rb +++ b/spec/helpers/application_helper_spec.rb @@ -5,16 +5,33 @@ RSpec.describe ApplicationHelper do let(:form) { form_handler.get_form("test_form") } let(:subsection) { form.get_subsection("household_characteristics") } let(:case_log) { FactoryBot.build(:case_log, :in_progress) } + let(:pagy) { nil } describe "browser_title" do - it "returns correct browser title when title is given" do - expect(browser_title("title")) - .to eq("title - #{t('service_name')} - GOV.UK") + context "with no pagination" do + it "returns correct browser title when title is given" do + expect(browser_title("title", pagy)) + .to eq("title - #{t('service_name')} - GOV.UK") + end + + it "returns correct browser title when title is not given" do + expect(browser_title(nil, pagy)) + .to eq("#{t('service_name')} - GOV.UK") + end end - it "returns correct browser title when title is not given" do - expect(browser_title(nil)) - .to eq("#{t('service_name')} - GOV.UK") + context "with pagination" do + let(:pagy) { OpenStruct.new(page: 1, pages: 2) } + + it "returns correct browser title when title is given" do + expect(browser_title("title", pagy)) + .to eq("title (page 1 of 2) - #{t('service_name')} - GOV.UK") + end + + it "returns correct browser title when title is not given" do + expect(browser_title(nil, pagy)) + .to eq("#{t('service_name')} - GOV.UK") + end end end end diff --git a/spec/requests/case_logs_controller_spec.rb b/spec/requests/case_logs_controller_spec.rb index 0c1e3524a..ab0282576 100644 --- a/spec/requests/case_logs_controller_spec.rb +++ b/spec/requests/case_logs_controller_spec.rb @@ -137,6 +137,7 @@ RSpec.describe CaseLogsController, type: :request do end describe "GET" do + let(:page) { Capybara::Node::Simple.new(response.body) } let(:user) { FactoryBot.create(:user) } let(:organisation) { user.organisation } let(:other_organisation) { FactoryBot.create(:organisation) } @@ -160,14 +161,102 @@ RSpec.describe CaseLogsController, type: :request do before do sign_in user - get "/logs", headers: headers, params: {} end - it "only shows case logs for your organisation" do - expected_case_row_log = "#{case_log.id}" - unauthorized_case_row_log = "#{unauthorized_case_log.id}" - expect(CGI.unescape_html(response.body)).to include(expected_case_row_log) - expect(CGI.unescape_html(response.body)).not_to include(unauthorized_case_row_log) + context "when there are less than 20 logs" do + before do + get "/logs", headers: headers, params: {} + end + + it "shows a table of logs" do + expect(CGI.unescape_html(response.body)).to match(/
/) + expect(CGI.unescape_html(response.body)).to match(/logs/) + end + + it "only shows case logs for your organisation" do + expected_case_row_log = "#{case_log.id}" + unauthorized_case_row_log = "#{unauthorized_case_log.id}" + expect(CGI.unescape_html(response.body)).to include(expected_case_row_log) + expect(CGI.unescape_html(response.body)).not_to include(unauthorized_case_row_log) + end + + it "shows the formatted created at date for each log" do + formatted_date = case_log.created_at.to_formatted_s(:govuk_date) + expect(CGI.unescape_html(response.body)).to include(formatted_date) + end + + it "shows the log's status" do + expect(CGI.unescape_html(response.body)).to include(case_log.status.humanize) + end + + it "shows the total log count" do + expect(CGI.unescape_html(response.body)).to match("1 total logs") + end + + it "does not show the pagination links" do + expect(page).not_to have_link("Previous") + expect(page).not_to have_link("Next") + end + + it "does not show the pagination result line" do + expect(CGI.unescape_html(response.body)).not_to match("Showing 1 to 20 of 26 logs") + end + + it "does not have pagination in the title" do + expect(page).to have_title("Logs") + end + end + + context "when there are more than 20 logs" do + before do + FactoryBot.create_list(:case_log, 25, owning_organisation: organisation, managing_organisation: organisation) + end + + context "when on the first page" do + before do + get "/logs", headers: headers, params: {} + end + + it "has pagination links" do + expect(page).to have_content("Previous") + expect(page).not_to have_link("Previous") + expect(page).to have_content("Next") + expect(page).to have_link("Next") + end + + it "shows which logs are being shown on the current page" do + expect(CGI.unescape_html(response.body)).to match("Showing 1 to 20 of 26 logs") + end + + it "has pagination in the title" do + expect(page).to have_title("Logs (page 1 of 2)") + end + end + + context "when on the second page" do + before do + get "/logs?page=2", headers: headers, params: {} + end + + it "shows the total log count" do + expect(CGI.unescape_html(response.body)).to match("26 total logs") + end + + it "has pagination links" do + expect(page).to have_content("Previous") + expect(page).to have_link("Previous") + expect(page).to have_content("Next") + expect(page).not_to have_link("Next") + end + + it "shows which logs are being shown on the current page" do + expect(CGI.unescape_html(response.body)).to match("Showing 21 to 26 of 26 logs") + end + + it "has pagination in the title" do + expect(page).to have_title("Logs (page 2 of 2)") + end + end end end diff --git a/spec/views/case_log_index_view_spec.rb b/spec/views/case_log_index_view_spec.rb deleted file mode 100644 index d7bcadc18..000000000 --- a/spec/views/case_log_index_view_spec.rb +++ /dev/null @@ -1,19 +0,0 @@ -require "rails_helper" - -RSpec.describe "case_logs/index" do - let(:in_progress_log) { FactoryBot.create(:case_log, :in_progress) } - - context "with a log list" do - before do - assign(:case_logs, [in_progress_log]) - render - end - - it "renders a table for all logs" do - expect(rendered).to match(/
/) - expect(rendered).to match(/logs/) - expect(rendered).to match(in_progress_log.created_at.to_formatted_s(:govuk_date)) - expect(rendered).to match(in_progress_log.status.humanize) - end - end -end