From 087309eab4cf75e7baebc9213c1119a1127d2fdc Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Mon, 10 Mar 2025 11:41:16 +0000
Subject: [PATCH] Fix lint and rewrite

---
 .../lettings/questions/address_search_spec.rb | 22 ++-----------------
 .../sales/questions/address_search_spec.rb    | 22 ++-----------------
 2 files changed, 4 insertions(+), 40 deletions(-)

diff --git a/spec/models/form/lettings/questions/address_search_spec.rb b/spec/models/form/lettings/questions/address_search_spec.rb
index 1daddefee..8635aa017 100644
--- a/spec/models/form/lettings/questions/address_search_spec.rb
+++ b/spec/models/form/lettings/questions/address_search_spec.rb
@@ -52,27 +52,9 @@ RSpec.describe Form::Lettings::Questions::AddressSearch, type: :model do
              .to_return(status: 200, body:, headers: {})
     end
 
-    let(:log_with_uprn) do
-      build(
-        :sales_log,
-        :completed,
-        uprn: 123,
-        manual_address_entry_selected: false,
-        address_line1_input: "1, Test Road",
-        postcode_full_input: "Test Town",
-        )
-    end
+    let(:log_with_uprn) { build(:lettings_log, :completed, uprn: 123, manual_address_entry_selected: false, address_line1_input: "1, Test Road", postcode_full_input: "Test Town") }
 
-    let(:log_without_uprn) do
-      build(
-        :sales_log,
-        :completed,
-        uprn: nil,
-        manual_address_entry_selected: false,
-        address_line1_input: "1, Test Road",
-        postcode_full_input: "Test Town",
-        )
-    end
+    let(:log_without_uprn) { build(:lettings_log, :completed, uprn: nil, manual_address_entry_selected: false, address_line1_input: "1, Test Road", postcode_full_input: "Test Town") }
 
     it "returns an answer option when uprn is present" do
       expect(question.answer_options(log_with_uprn)).to eq({ "123" => { "value" => "1 Test Street, Test City, AA1 1AA (123)" } })
diff --git a/spec/models/form/sales/questions/address_search_spec.rb b/spec/models/form/sales/questions/address_search_spec.rb
index 1808ff835..a2a2b51c9 100644
--- a/spec/models/form/sales/questions/address_search_spec.rb
+++ b/spec/models/form/sales/questions/address_search_spec.rb
@@ -52,27 +52,9 @@ RSpec.describe Form::Sales::Questions::AddressSearch, type: :model do
              .to_return(status: 200, body:, headers: {})
     end
 
-    let(:log_with_uprn) do
-      build(
-        :sales_log,
-        :completed,
-        uprn: 123,
-        manual_address_entry_selected: false,
-        address_line1_input: "1, Test Road",
-        postcode_full_input: "Test Town",
-      )
-    end
+    let(:log_with_uprn) { build(:sales_log, :completed, uprn: 123, manual_address_entry_selected: false, address_line1_input: "1, Test Road", postcode_full_input: "Test Town") }
 
-    let(:log_without_uprn) do
-      build(
-        :sales_log,
-        :completed,
-        uprn: nil,
-        manual_address_entry_selected: false,
-        address_line1_input: "1, Test Road",
-        postcode_full_input: "Test Town",
-        )
-    end
+    let(:log_without_uprn) { build(:sales_log, :completed, uprn: nil, manual_address_entry_selected: false, address_line1_input: "1, Test Road", postcode_full_input: "Test Town") }
 
     it "returns an answer option when uprn is present" do
       expect(question.answer_options(log_with_uprn)).to eq({ "123" => { "value" => "1 Test Street, Test City, AA1 1AA (123)" } })