Browse Source

Convert 'else next' to guard clause

CLDC-4146-infer-no-other-partners
oscar-richardson-softwire 1 week ago
parent
commit
0899fc46fc
  1. 12
      app/models/derived_variables/lettings_log_variables.rb

12
app/models/derived_variables/lettings_log_variables.rb

@ -322,14 +322,12 @@ private
def reset_partner_fields!
person_count = hhmemb || 8
(2..person_count).each do |i|
if send("relat#{i}_changed?") && send("relat#{i}_was") == "P"
((i + 1)..person_count).each do |j|
if self["relat#{j}"] == "X"
self["relat#{j}"] = nil
end
next unless send("relat#{i}_changed?") && send("relat#{i}_was") == "P"
((i + 1)..person_count).each do |j|
if self["relat#{j}"] == "X"
self["relat#{j}"] = nil
end
else
next
end
end
end

Loading…
Cancel
Save