CLDC-4146 infer no to multiple partners

app/models/derived_variables/lettings_log_variables.rb

@@ -75,6 +75,10 @@ module DerivedVariables::LettingsLogVariables
       self.beds = nil
     end
 
+    if form.start_year_2026_or_later?
+      infer_at_most_one_relationship!
+    end
+
     clear_child_constraints_for_age_changes!
     child_under_16_constraints!
 
@@ -325,6 +329,23 @@ private
     end
   end
 
+  def infer_at_most_one_relationship!
+    new_partner_numbers = partner_numbers.select { |i| public_send("relat#{i}_changed?") }
+    if new_partner_numbers.any?
+      infer_only_partner!(new_partner_numbers.first)
+    elsif partner_numbers.any?
+      infer_only_partner!(partner_numbers.first)
+    end
+  end
+
+  def infer_only_partner!(partner_number)
+    other_partner_numbers = partner_numbers.reject { |x| x == partner_number }
+    other_partner_numbers.each { |i| self["relat#{i}"] = "X" }
+
+    unanswered_partner_questions = (2..8).select { |i| public_send("relat#{i}").nil? }
+    unanswered_partner_questions.each { |i| self["relat#{i}"] = "X" }
+  end
+
   def household_type
     return unless totelder && totadult && totchild
 

app/models/form/lettings/pages/person_lead_partner.rb

@@ -18,8 +18,11 @@ class Form::Lettings::Pages::PersonLeadPartner < ::Form::Page
             "operator" => ">=",
             "operand" => 16,
           },
+          **(2...@person_index).map { |i| ["relat#{i}", { "operator" => "!=", "operand" => "P" }] }.to_h,
         },
-        { "details_known_#{@person_index}" => 0, "age#{@person_index}" => nil },
+        { "details_known_#{@person_index}" => 0,
+          "age#{@person_index}" => nil,
+          **(2...@person_index).map { |i| ["relat#{i}", { "operator" => "!=", "operand" => "P" }] }.to_h },
       ]
     else
       [{ "details_known_#{@person_index}" => 0 }]

app/models/form/lettings/questions/person_partner.rb

@@ -7,6 +7,12 @@ class Form::Lettings::Questions::PersonPartner < ::Form::Question
     @answer_options = answer_options
     @person_index = person_index
     @question_number = question_number
+    @hidden_in_check_answers = {
+      "depends_on" => (2...person_index).map do |i|
+        { "relat#{i}" => "P", "relat#{person_index}" => "X" }
+      end,
+    }
+    @disable_clearing_if_not_routed_or_dynamic_answer_options = form.start_year_2026_or_later?
   end
 
   def answer_options

app/models/form/lettings/subsections/household_characteristics.rb

@@ -52,15 +52,15 @@ class Form::Lettings::Subsections::HouseholdCharacteristics < ::Form::Subsection
       Form::Lettings::Pages::PersonKnown.new(nil, nil, self, person_index:),
       (Form::Lettings::Pages::PersonAge.new(nil, nil, self, person_index:) if form.start_year_2026_or_later?),
       relationship_question(person_index:),
-      (Form::Lettings::Pages::PartnerUnder16ValueCheck.new("relationship_#{person_index}_partner_under_16_value_check", nil, self, person_index:) if form.start_year_2024_or_later? && !form.start_year_2026_or_later?),
-      (Form::Lettings::Pages::MultiplePartnersValueCheck.new("relationship_#{person_index}_multiple_partners_value_check", nil, self, person_index:) if form.start_year_2024_or_later?),
+      (Form::Lettings::Pages::PartnerUnder16ValueCheck.new("relationship_#{person_index}_partner_under_16_value_check", nil, self, person_index:) unless form.start_year_2026_or_later?),
+      (Form::Lettings::Pages::MultiplePartnersValueCheck.new("relationship_#{person_index}_multiple_partners_value_check", nil, self, person_index:) unless form.start_year_2026_or_later?),
       (Form::Lettings::Pages::PersonAge.new(nil, nil, self, person_index:) unless form.start_year_2026_or_later?),
       (Form::Lettings::Pages::NoFemalesPregnantHouseholdPersonAgeValueCheck.new(nil, nil, self, person_index:) unless form.start_year_2026_or_later?),
       (Form::Lettings::Pages::FemalesInSoftAgeRangeInPregnantHouseholdPersonAgeValueCheck.new(nil, nil, self, person_index:) unless form.start_year_2026_or_later?),
       (Form::Lettings::Pages::NoHouseholdMemberLikelyToBePregnantCheck.new("no_household_member_likely_to_be_pregnant_person_age_#{person_index}_check", nil, self, person_index:) if form.start_year_2026_or_later?),
       Form::Lettings::Pages::PersonUnderRetirementValueCheck.new("age_#{person_index}_under_retirement_value_check", nil, self, person_index:),
       Form::Lettings::Pages::PersonOverRetirementValueCheck.new("age_#{person_index}_over_retirement_value_check", nil, self, person_index:),
-      (Form::Lettings::Pages::PartnerUnder16ValueCheck.new("age_#{person_index}_partner_under_16_value_check", nil, self, person_index:) if form.start_year_2024_or_later? && !form.start_year_2026_or_later?),
+      (Form::Lettings::Pages::PartnerUnder16ValueCheck.new("age_#{person_index}_partner_under_16_value_check", nil, self, person_index:) unless form.start_year_2026_or_later?),
       (Form::Lettings::Pages::PersonSexRegisteredAtBirth.new(nil, nil, self, person_index:) if form.start_year_2026_or_later?),
       (Form::Lettings::Pages::PersonGenderSameAsSex.new(nil, nil, self, person_index:) if form.start_year_2026_or_later?),
       (Form::Lettings::Pages::PersonGenderIdentity.new(nil, nil, self, person_index:) unless form.start_year_2026_or_later?),

app/models/lettings_log.rb

@@ -903,6 +903,10 @@ private
     end
   end
 
+  def partner_numbers
+    (2..8).select { |i| public_send("relat#{i}") == "P" }
+  end
+
   def age_refused?
     [age1_known, age2_known, age3_known, age4_known, age5_known, age6_known, age7_known, age8_known].any?(1)
   end

spec/factories/lettings_log.rb

@@ -137,7 +137,7 @@ FactoryBot.define do
       rp_hardship { 0 }
       rp_dontknow { 0 }
       tenancyother { nil }
-      net_income_value_check { nil }
+      net_income_value_check { 1 }
       void_date_value_check { 1 }
       major_repairs_date_value_check { 1 }
       net_income_known { 0 }

spec/models/form/lettings/pages/person_lead_partner_spec.rb

@@ -92,8 +92,13 @@ RSpec.describe Form::Lettings::Pages::PersonLeadPartner, type: :model do
                 "operator" => ">=",
                 "operand" => 16,
               },
+              "relat2" => { "operator" => "!=", "operand" => "P" },
+            },
+            {
+              "details_known_3" => 0,
+              "age3" => nil,
+              "relat2" => { "operator" => "!=", "operand" => "P" },
             },
-            { "details_known_3" => 0, "age3" => nil },
           ],
         )
       end

spec/models/form/lettings/questions/person_partner_spec.rb

@@ -107,5 +107,9 @@ RSpec.describe Form::Lettings::Questions::PersonPartner, type: :model do
     it "has the correct check_answers_card_number" do
       expect(question.check_answers_card_number).to eq(3)
     end
+
+    it "has the correct hidden_in_check_answers" do
+      expect(question.hidden_in_check_answers).to eq("relat2" => "P", "relat3" => "X")
+    end
   end
 end

spec/models/form/lettings/subsections/household_characteristics_spec.rb

@@ -357,7 +357,6 @@ RSpec.describe Form::Lettings::Subsections::HouseholdCharacteristics, type: :mod
           person_2_known
           person_2_age
           person_2_lead_partner
-          relationship_2_multiple_partners_value_check
           no_household_member_likely_to_be_pregnant_person_age_2_check
           age_2_under_retirement_value_check
           age_2_over_retirement_value_check
@@ -372,7 +371,6 @@ RSpec.describe Form::Lettings::Subsections::HouseholdCharacteristics, type: :mod
           person_3_known
           person_3_age
           person_3_lead_partner
-          relationship_3_multiple_partners_value_check
           no_household_member_likely_to_be_pregnant_person_age_3_check
           age_3_under_retirement_value_check
           age_3_over_retirement_value_check
@@ -387,7 +385,6 @@ RSpec.describe Form::Lettings::Subsections::HouseholdCharacteristics, type: :mod
           person_4_known
           person_4_age
           person_4_lead_partner
-          relationship_4_multiple_partners_value_check
           no_household_member_likely_to_be_pregnant_person_age_4_check
           age_4_under_retirement_value_check
           age_4_over_retirement_value_check
@@ -402,7 +399,6 @@ RSpec.describe Form::Lettings::Subsections::HouseholdCharacteristics, type: :mod
           person_5_known
           person_5_age
           person_5_lead_partner
-          relationship_5_multiple_partners_value_check
           no_household_member_likely_to_be_pregnant_person_age_5_check
           age_5_under_retirement_value_check
           age_5_over_retirement_value_check
@@ -417,7 +413,6 @@ RSpec.describe Form::Lettings::Subsections::HouseholdCharacteristics, type: :mod
           person_6_known
           person_6_age
           person_6_lead_partner
-          relationship_6_multiple_partners_value_check
           no_household_member_likely_to_be_pregnant_person_age_6_check
           age_6_under_retirement_value_check
           age_6_over_retirement_value_check
@@ -432,7 +427,6 @@ RSpec.describe Form::Lettings::Subsections::HouseholdCharacteristics, type: :mod
           person_7_known
           person_7_age
           person_7_lead_partner
-          relationship_7_multiple_partners_value_check
           no_household_member_likely_to_be_pregnant_person_age_7_check
           age_7_under_retirement_value_check
           age_7_over_retirement_value_check
@@ -447,7 +441,6 @@ RSpec.describe Form::Lettings::Subsections::HouseholdCharacteristics, type: :mod
           person_8_known
           person_8_age
           person_8_lead_partner
-          relationship_8_multiple_partners_value_check
           no_household_member_likely_to_be_pregnant_person_age_8_check
           age_8_under_retirement_value_check
           age_8_over_retirement_value_check

spec/models/lettings_log_derived_fields_spec.rb

@@ -1588,4 +1588,156 @@ RSpec.describe LettingsLog, type: :model do
       end
     end
   end
+
+  describe "#infer_at_most_one_relationship!" do
+    context "when 2025", metadata: { year: 25 } do
+      before do
+        Timecop.freeze(Time.zone.local(2025, 5, 10))
+        Singleton.__init__(FormHandler)
+      end
+
+      after do
+        Timecop.return
+        Singleton.__init__(FormHandler)
+      end
+
+      context "when there are no existing relationships" do
+        let(:log) { create(:lettings_log, :completed, relat2: "X", relat3: "X", relat4: "R") }
+
+        it "does not infer no to any relationship answers when a new relationship is added" do
+          log.relat2 = "P"
+          expect { log.set_derived_fields! }.to not_change(log, :relat3)
+          expect { log.set_derived_fields! }.to not_change(log, :relat4)
+          expect { log.set_derived_fields! }.to not_change(log, :relat5)
+        end
+      end
+
+      context "when there is an existing relationship" do
+        let(:log) { create(:lettings_log, :completed, relat2: "X", relat3: "P", relat4: "R", relat5: "X") }
+
+        it "does not infer no to any relationship answers when a new relationship is added" do
+          log.relat2 = "P"
+          expect { log.set_derived_fields! }.to not_change(log, :relat3)
+          expect { log.set_derived_fields! }.to not_change(log, :relat4)
+          expect { log.set_derived_fields! }.to not_change(log, :relat5)
+          expect { log.set_derived_fields! }.to not_change(log, :relat6)
+        end
+      end
+
+      context "when more than one relationship is set" do
+        let(:log) { create(:lettings_log, :completed, relat2: "X", relat3: "X", relat4: "R", relat5: "X") }
+
+        before do
+          log.relat3 = "P"
+          log.relat2 = "P"
+        end
+
+        it "does not infer no to any relationship answers" do
+          expect { log.set_derived_fields! }.to not_change(log, :relat2)
+          expect { log.set_derived_fields! }.to not_change(log, :relat3)
+          expect { log.set_derived_fields! }.to not_change(log, :relat4)
+          expect { log.set_derived_fields! }.to not_change(log, :relat5)
+          expect { log.set_derived_fields! }.to not_change(log, :relat6)
+        end
+      end
+    end
+
+    context "when 2026", metadata: { year: 26 } do
+      before do
+        Timecop.freeze(Time.zone.local(2026, 5, 10))
+        Singleton.__init__(FormHandler)
+      end
+
+      after do
+        Timecop.return
+        Singleton.__init__(FormHandler)
+      end
+
+      context "when there are no existing relationships" do
+        let(:log) { create(:lettings_log, :completed, relat2: "X", relat3: "X", relat4: "R") }
+
+        context "and a new relationship is added" do
+          before do
+            log.relat2 = "P"
+          end
+
+          it "infers no to unanswered questions" do
+            expect { log.set_derived_fields! }.to change(log, :relat5).to "X"
+          end
+
+          it "does not change relationship answers of no or prefer not to say" do
+            expect { log.set_derived_fields! }.to not_change(log, :relat3)
+            expect { log.set_derived_fields! }.to not_change(log, :relat4)
+          end
+        end
+
+        it "does not change other relationship values if no is changed to prefer not to say" do
+          log.relat2 = "R"
+          expect { log.set_derived_fields! }.to not_change(log, :relat3)
+          expect { log.set_derived_fields! }.to not_change(log, :relat4)
+        end
+
+        it "does not change other relationship values if prefer not to say is changed to no" do
+          log.relat4 = "X"
+          expect { log.set_derived_fields! }.to not_change(log, :relat2)
+          expect { log.set_derived_fields! }.to not_change(log, :relat3)
+        end
+      end
+
+      context "when there is an existing relationship" do
+        let(:log) { create(:lettings_log, :completed, relat2: "X", relat3: "P", relat4: "R", relat5: "X") }
+
+        context "and a new relationship is added" do
+          before do
+            log.relat6 = nil
+            log.relat2 = "P"
+          end
+
+          it "infers no to the previous relationship" do
+            expect { log.set_derived_fields! }.to change(log, :relat3).to "X"
+          end
+
+          it "infers no to unanswered questions" do
+            expect { log.set_derived_fields! }.to change(log, :relat6).to "X"
+          end
+
+          it "does not change relationship answers of no or prefer not to say" do
+            expect { log.set_derived_fields! }.to not_change(log, :relat5)
+            expect { log.set_derived_fields! }.to not_change(log, :relat4)
+          end
+        end
+
+        it "does not change other relationship values if the partner is removed" do
+          log.relat3 = "X"
+          expect { log.set_derived_fields! }.to not_change(log, :relat2)
+          expect { log.set_derived_fields! }.to not_change(log, :relat4)
+          expect { log.set_derived_fields! }.to not_change(log, :relat5)
+          expect { log.set_derived_fields! }.to not_change(log, :relat6)
+        end
+      end
+
+      context "when more than one relationship is set" do
+        let(:log) { create(:lettings_log, :completed, hhmemb: 6, relat2: "X", relat3: "X", relat4: "R", relat5: "X") }
+
+        before do
+          log.relat3 = "P"
+          log.relat2 = "P"
+        end
+
+        it "keeps the lower numbered relationship and infers the higher numbered one to false" do
+          expect { log.set_derived_fields! }.to change(log, :relat3).to "X"
+          expect { log.set_derived_fields! }.to not_change(log, :relat2)
+        end
+
+        it "infers no to unanswered questions" do
+          expect { log.set_derived_fields! }.to change(log, :relat6).to "X"
+        end
+
+        it "does not change relationship answers of no or prefer not to say" do
+          expect { log.set_derived_fields! }.to not_change(log, :relat5)
+          expect { log.set_derived_fields! }.to not_change(log, :relat4)
+        end
+      end
+    end
+  end
 end