diff --git a/app/models/validations/property_validations.rb b/app/models/validations/property_validations.rb index 0f0e2f265..45eccd43e 100644 --- a/app/models/validations/property_validations.rb +++ b/app/models/validations/property_validations.rb @@ -39,7 +39,7 @@ module Validations::PropertyValidations record.errors.add :referral, I18n.t("validations.household.referral.rsnvac_non_temp") end - if record.renewal == 0 && record.rsnvac == 14 + if record.renewal && record.renewal.zero? && record.rsnvac == 14 record.errors.add :rsnvac, I18n.t("validations.property.rsnvac.not_a_renewal") end end diff --git a/spec/models/validations/property_validations_spec.rb b/spec/models/validations/property_validations_spec.rb index 51916cf4c..b3965b3d6 100644 --- a/spec/models/validations/property_validations_spec.rb +++ b/spec/models/validations/property_validations_spec.rb @@ -236,7 +236,7 @@ RSpec.describe Validations::PropertyValidations do context "when the letting is not a renewal" do it "validates that the reason for vacancy is not renewal" do - record.first_time_property_let_as_social_housing = 0 + record.first_time_property_let_as_social_housing = 0 record.renewal = 0 record.rsnvac = 14 property_validator.validate_rsnvac(record)