Code review fixes

app/models/form/setup/pages/location.rb

@@ -9,7 +9,6 @@ class Form::Setup::Pages::Location < ::Form::Page
       "needstype" => 2,
       "scheme_has_multiple_locations?" => true,
     }]
-    @derived = true
   end
 
   def questions

app/models/form/setup/pages/scheme.rb

@@ -8,7 +8,6 @@ class Form::Setup::Pages::Scheme < ::Form::Page
       "supported_housing_schemes_enabled?" => true,
       "needstype" => 2,
     }]
-    @derived = true
   end
 
   def questions

app/models/form/setup/questions/location_id.rb

@@ -13,8 +13,8 @@ class Form::Setup::Questions::LocationId < ::Form::Question
     answer_opts = {}
     return answer_opts unless ActiveRecord::Base.connected?
 
-    Location.select(:id, :postcode, :address_line1).each_with_object(answer_opts) do |location, hsh|
+    Location.select(:id, :postcode, :name).each_with_object(answer_opts) do |location, hsh|
-      hsh[location.id.to_s] = { "value" => location.postcode, "hint" => location.address_line1 }
+      hsh[location.id.to_s] = { "value" => location.postcode, "hint" => location.name }
       hsh
     end
   end

app/models/form/setup/questions/scheme_id.rb

@@ -22,8 +22,9 @@ class Form::Setup::Questions::SchemeId < ::Form::Question
   def displayed_answer_options(case_log)
     return {} unless case_log.created_by
 
-    user_org_scheme_ids = Scheme.where(organisation_id: case_log.created_by.organisation_id).map(&:id).map(&:to_s)
+    user_org_scheme_ids = Scheme.select(:id).where(organisation_id: case_log.created_by.organisation_id).map(&:id)
-    answer_options.select { |k, _v| user_org_scheme_ids.include?(k) }
+    answer_options.select do |k, _v| user_org_scheme_ids.include?(k.to_i)
+    end
   end
 
   def hidden_in_check_answers?(case_log, _current_user = nil)

app/views/schemes/locations.html.erb

@@ -15,7 +15,7 @@
       <section class="x-govuk-summary-card govuk-!-margin-bottom-6">
         <header class="x-govuk-summary-card__header">
           <h2 class="x-govuk-summary-card__title">
-            <%= "#{location.address_line1}, #{location.address_line2}" %>
+            <%= location.name %>
           </h2>
         </header>
         <div class="x-govuk-summary-card__body">

db/migrate/20220704135746_rename_location_name.rb

@@ -0,0 +1,8 @@
+class RenameLocationName < ActiveRecord::Migration[7.0]
+  def change
+    change_table :locations, bulk: true do |t|
+      t.rename :address_line1, :name
+      t.remove :address_line2, type: :string
+    end
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2022_06_30_154441) do
+ActiveRecord::Schema[7.0].define(version: 2022_07_04_135746) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
@@ -243,8 +243,7 @@ ActiveRecord::Schema[7.0].define(version: 2022_06_30_154441) do
     t.string "type_of_building"
     t.integer "wheelchair_adaptation"
     t.bigint "scheme_id", null: false
-    t.string "address_line1"
+    t.string "name"
-    t.string "address_line2"
     t.string "county"
     t.datetime "created_at", null: false
     t.datetime "updated_at", null: false

db/seeds.rb

@@ -116,8 +116,7 @@ unless Rails.env.test?
       scheme: scheme1,
       location_code: "S254-CU193AA",
       postcode: "CU19 3AA",
-      address_line1: "Rectory Road",
+      name: "Rectory Road",
-      address_line2: "North Chaim",
       type_of_unit: "Self-contained flat or bedsit",
       type_of_building: "Purpose-built",
       county: "Mid Sussex",
@@ -128,8 +127,7 @@ unless Rails.env.test?
       scheme: scheme1,
       location_code: "S254-DM250DC",
       postcode: "DM25 0DC",
-      address_line1: "Smithy Lane",
+      name: "Smithy Lane",
-      address_line2: "North Kellieworth",
       type_of_unit: "Self-contained flat or bedsit with common facilities",
       type_of_building: "Converted from previous residential or non-residential property",
       county: "Fife",
@@ -140,8 +138,7 @@ unless Rails.env.test?
       scheme: scheme2,
       location_code: "S254-YX130WP",
       postcode: "YX13 0WP",
-      address_line1: "Smithy Lane",
+      name: "Smithy Lane",
-      address_line2: "East Darwin",
       type_of_unit: "Shared house or hostel",
       type_of_building: "Converted from previous residential or non-residential property",
       county: "Rochford",

spec/factories/location.rb

@@ -2,8 +2,7 @@ FactoryBot.define do
   factory :location do
     location_code { Faker::Name.initials(number: 10) }
     postcode { Faker::Address.postcode.delete(" ") }
-    address_line1 { Faker::Address.street_name }
+    name { Faker::Address.street_name }
-    address_line2 { Faker::Address.city }
     type_of_unit { Faker::Lorem.word }
     type_of_building { Faker::Lorem.word }
     wheelchair_adaptation { 0 }

spec/requests/schemes_controller_spec.rb

@@ -398,8 +398,7 @@ RSpec.describe SchemesController, type: :request do
           expect(page).to have_content(location.type_of_unit)
           expect(page).to have_content(location.type_of_building)
           expect(page).to have_content(location.wheelchair_adaptation)
-          expect(page).to have_content(location.address_line1)
+          expect(page).to have_content(location.name)
-          expect(page).to have_content(location.address_line2)
         end
       end