Browse Source

recactor out a conditional method

pull/115/head
Kat 4 years ago
parent
commit
0e21f2a9b9
  1. 12
      app/validations/date_validations.rb

12
app/validations/date_validations.rb

@ -4,10 +4,8 @@ module DateValidations
if record["startdate"].present? && record["mrcdate"].present? && record["startdate"] < record["mrcdate"]
record.errors.add :mrcdate, "Major repairs date must be before the tenancy start date"
end
if (record["rsnvac"] == "First let of newbuild property" ||
record["rsnvac"] == "First let of conversion/rehabilitation/acquired property" ||
record["rsnvac"] == "First let of leased property") &&
record["mrcdate"].present?
if is_rsnvac_first_let?(record) && record["mrcdate"].present?
record.errors.add :mrcdate, "Major repairs date must not be completed if the tenancy is first let"
end
@ -45,4 +43,10 @@ private
record.errors.add question, "Please enter a valid date"
end
end
def is_rsnvac_first_let?(record)
record["rsnvac"] == "First let of newbuild property" ||
record["rsnvac"] == "First let of conversion/rehabilitation/acquired property" ||
record["rsnvac"] == "First let of leased property"
end
end

Loading…
Cancel
Save