baarkerlounger
/
submit-social-housing-lettings-and-sales-data
mirror of https://github.com/communitiesuk/submit-social-housing-lettings-and-sales-data.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
Browse Source

Flipper feature flags PoC

pull/357/head
baarkerlounger 3 years ago
parent
794f3f0c7c
commit
0ed276a9b9
7 changed files with 95 additions and 25 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 4
      Gemfile
  2. 26
      Gemfile.lock
  3. 2
      app/views/case_logs/index.html.erb
  4. 6
      config/initializers/flipper.rb
  5. 4
      config/routes.rb
  6. 22
      db/migrate/20220307100023_create_flipper_tables.rb
  7. 56
      db/schema.rb

4
Gemfile
Unescape View File

@ -52,6 +52,10 @@ gem "paper_trail-globalid"
# Receive exceptions and configure alerts
gem "sentry-rails"
gem "sentry-ruby"
# Feature flagging
gem "flipper"
gem "flipper-active_record"
gem "flipper-ui"
group :development, :test do
# Check gems for known vulnerabilities

26
Gemfile.lock
Unescape View File

@ -23,7 +23,7 @@ GIT
GIT
remote: https://github.com/tagliala/activeadmin.git
revision: 871c6af8dec41f764a9f08bf04b5422971a23e32
revision: 32995284eb1a54a570f025ab27b3bbca582c10ce
branch: feature/railties-7
specs:
activeadmin (2.10.1)
@ -111,8 +111,8 @@ GEM
ruby2_keywords (>= 0.0.2, < 1.0)
ast (2.4.2)
aws-eventstream (1.2.0)
aws-partitions (1.562.0)
aws-sdk-core (3.127.0)
aws-partitions (1.563.0)
aws-sdk-core (3.128.0)
aws-eventstream (~> 1, >= 1.0.2)
aws-partitions (~> 1, >= 1.525.0)
aws-sigv4 (~> 1.1)
@ -173,6 +173,16 @@ GEM
factory_bot (~> 6.2.0)
railties (>= 5.0.0)
ffi (1.15.5)
flipper (0.24.0)
flipper-active_record (0.24.0)
activerecord (>= 4.2, < 8)
flipper (~> 0.24.0)
flipper-ui (0.24.0)
erubi (>= 1.0.0, < 2.0.0)
flipper (~> 0.24.0)
rack (>= 1.4, < 3)
rack-protection (>= 1.5.3, < 2.2.0)
sanitize (< 7)
formtastic (4.0.0)
actionpack (>= 5.2.0)
formtastic_i18n (0.7.0)
@ -292,6 +302,8 @@ GEM
rack (2.2.3)
rack-mini-profiler (2.3.4)
rack (>= 1.2.0)
rack-protection (2.1.0)
rack
rack-proxy (0.7.2)
rack
rack-test (1.1.0)
@ -377,7 +389,7 @@ GEM
rubocop-rails (= 2.13.2)
rubocop-rake (= 0.6.0)
rubocop-rspec (= 2.7.0)
rubocop-performance (1.13.2)
rubocop-performance (1.13.3)
rubocop (>= 1.7.0, < 2.0)
rubocop-ast (>= 0.4.0)
rubocop-rails (2.13.2)
@ -391,6 +403,9 @@ GEM
ruby-progressbar (1.11.0)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
sanitize (6.0.0)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
sass (3.7.4)
sass-listen (~> 4.0.0)
sass-listen (4.0.0)
@ -477,6 +492,9 @@ DEPENDENCIES
devise!
dotenv-rails
factory_bot_rails
flipper
flipper-active_record
flipper-ui
govuk-components
govuk_design_system_formbuilder
hotwire-rails

2
app/views/case_logs/index.html.erb
Unescape View File

@ -6,7 +6,7 @@
<div class="govuk-button-group">
<%= govuk_button_to "Create a new lettings log", case_logs_path %>
<%= govuk_link_to "Upload logs", bulk_upload_case_logs_path %>
<%= govuk_link_to("Upload logs", bulk_upload_case_logs_path) if Flipper.enabled?(:bulk_upload, current_user) %>
</div>
<% if @case_logs.present? %>

6
config/initializers/flipper.rb
Unescape View File

@ -0,0 +1,6 @@
class CanAccessFlipperUI
def self.matches?(request)
current_user = request.env["warden"].user
current_user.present? && current_user.is_a?(AdminUser)
end
end

4
config/routes.rb
Unescape View File

@ -26,6 +26,10 @@ Rails.application.routes.draw do
get "confirmations/reset", to: "auth/passwords#reset_confirmation"
end
constraints CanAccessFlipperUI do
mount Flipper::UI.app(Flipper) => "/feature-flags"
end
get "/health", to: ->(_) { [204, {}, [nil]] }
# For details on the DSL available within this file, see https://guides.rubyonrails.org/routing.html

22
db/migrate/20220307100023_create_flipper_tables.rb
Unescape View File

@ -0,0 +1,22 @@
class CreateFlipperTables < ActiveRecord::Migration[7.0]
def self.up
create_table :flipper_features do |t|
t.string :key, null: false
t.timestamps null: false
end
add_index :flipper_features, :key, unique: true
create_table :flipper_gates do |t|
t.string :feature_key, null: false
t.string :key, null: false
t.string :value
t.timestamps null: false
end
add_index :flipper_gates, %i[feature_key key value], unique: true
end
def self.down
drop_table :flipper_gates
drop_table :flipper_features
end
end

56
db/schema.rb
Unescape View File

@ -45,32 +45,24 @@ ActiveRecord::Schema[7.0].define(version: 202202071123100) do
t.datetime "updated_at", null: false
t.string "tenant_code"
t.integer "age1"
t.string "sex1"
t.integer "ethnic"
t.integer "national"
t.integer "prevten"
t.integer "ecstat1"
t.integer "hhmemb"
t.integer "age2"
t.string "sex2"
t.integer "ecstat2"
t.integer "age3"
t.string "sex3"
t.integer "ecstat3"
t.integer "age4"
t.string "sex4"
t.integer "ecstat4"
t.integer "age5"
t.string "sex5"
t.integer "ecstat5"
t.integer "age6"
t.string "sex6"
t.integer "ecstat6"
t.integer "age7"
t.string "sex7"
t.integer "ecstat7"
t.integer "age8"
t.string "sex8"
t.integer "ecstat8"
t.integer "homeless"
t.integer "underoccupation_benefitcap"
@ -157,7 +149,6 @@ ActiveRecord::Schema[7.0].define(version: 202202071123100) do
t.datetime "property_void_date", precision: nil
t.bigint "owning_organisation_id"
t.bigint "managing_organisation_id"
t.integer "renttype"
t.integer "needstype"
t.integer "lettype"
t.integer "postcode_known"
@ -186,6 +177,26 @@ ActiveRecord::Schema[7.0].define(version: 202202071123100) do
t.integer "previous_postcode_known"
t.integer "previous_la_known"
t.boolean "is_previous_la_inferred"
t.integer "letting_allocation_unknown"
t.integer "renttype"
t.string "sex1"
t.string "sex2"
t.string "sex3"
t.string "sex4"
t.string "sex5"
t.string "sex6"
t.string "sex7"
t.string "sex8"
t.integer "relat2"
t.integer "relat3"
t.integer "relat4"
t.integer "relat5"
t.integer "relat6"
t.integer "relat7"
t.integer "relat8"
t.integer "rent_type"
t.integer "has_benefits"
t.integer "renewal"
t.integer "age1_known"
t.integer "age2_known"
t.integer "age3_known"
@ -196,7 +207,6 @@ ActiveRecord::Schema[7.0].define(version: 202202071123100) do
t.integer "age8_known"
t.integer "ethnic_group"
t.string "ethnic_other"
t.integer "letting_allocation_unknown"
t.integer "details_known_2"
t.integer "details_known_3"
t.integer "details_known_4"
@ -204,20 +214,26 @@ ActiveRecord::Schema[7.0].define(version: 202202071123100) do
t.integer "details_known_6"
t.integer "details_known_7"
t.integer "details_known_8"
t.integer "relat2"
t.integer "relat3"
t.integer "relat4"
t.integer "relat5"
t.integer "relat6"
t.integer "relat7"
t.integer "relat8"
t.integer "rent_type"
t.integer "has_benefits"
t.integer "renewal"
t.index ["managing_organisation_id"], name: "index_case_logs_on_managing_organisation_id"
t.index ["owning_organisation_id"], name: "index_case_logs_on_owning_organisation_id"
end
create_table "flipper_features", force: :cascade do |t|
t.string "key", null: false
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["key"], name: "index_flipper_features_on_key", unique: true
end
create_table "flipper_gates", force: :cascade do |t|
t.string "feature_key", null: false
t.string "key", null: false
t.string "value"
t.datetime "created_at", null: false
t.datetime "updated_at", null: false
t.index ["feature_key", "key", "value"], name: "index_flipper_gates_on_feature_key_and_key_and_value", unique: true
end
create_table "organisations", force: :cascade do |t|
t.string "name"
t.string "phone"

Write Preview
Loading…
Cancel
Save