Browse Source

CLDC-4177: refactor to remove max cols going forwards

pull/3144/head
Nat Dean-Lewis 1 week ago
parent
commit
0fd753ffd0
  1. 2
      app/services/bulk_upload/sales/validator.rb
  2. 1
      app/services/bulk_upload/sales/year2026/csv_parser.rb

2
app/services/bulk_upload/sales/validator.rb

@ -167,7 +167,7 @@ private
column_count = rows.map(&:size).max column_count = rows.map(&:size).max
errors.add(:base, I18n.t("validations.sales.#{@bulk_upload.year}.bulk_upload.wrong_template.over_max_column_count")) if column_count > csv_parser.class::MAX_COLUMNS errors.add(:base, I18n.t("validations.sales.#{@bulk_upload.year}.bulk_upload.wrong_template.over_max_column_count")) if column_count > csv_parser.class::FIELDS + 1
end end
def validate_correct_template def validate_correct_template

1
app/services/bulk_upload/sales/year2026/csv_parser.rb

@ -5,7 +5,6 @@ class BulkUpload::Sales::Year2026::CsvParser
# TODO: CLDC-4162: Update when 2026 format is known # TODO: CLDC-4162: Update when 2026 format is known
FIELDS = 127 FIELDS = 127
MAX_COLUMNS = FIELDS + 1
FORM_YEAR = 2026 FORM_YEAR = 2026
attr_reader :path attr_reader :path

Loading…
Cancel
Save