Browse Source

CLDC-4028: Fix created at name change in lettings log

always safer to use updated at for checking whether the record has changed
pull/3109/head
Samuel Young 1 month ago
parent
commit
1140e4afea
  1. 4
      app/services/exports/lettings_log_export_service.rb

4
app/services/exports/lettings_log_export_service.rb

@ -58,10 +58,10 @@ module Exports
# these must be separate as activerecord struggles to join to two different name change tables in the same query # these must be separate as activerecord struggles to join to two different name change tables in the same query
ids.concat( ids.concat(
relation.left_joins(owning_organisation: :organisation_name_changes).where(owning_organisation: { organisation_name_changes: { created_at: range } }).pluck(:id), relation.left_joins(owning_organisation: :organisation_name_changes).where(owning_organisation: { organisation_name_changes: { updated_at: range } }).pluck(:id),
) )
ids.concat( ids.concat(
relation.left_joins(managing_organisation: :organisation_name_changes).where(managing_organisation: { organisation_name_changes: { created_at: range } }).pluck(:id), relation.left_joins(managing_organisation: :organisation_name_changes).where(managing_organisation: { organisation_name_changes: { updated_at: range } }).pluck(:id),
) )
LettingsLog.where(id: ids) LettingsLog.where(id: ids)

Loading…
Cancel
Save