From 11d6ba1732685ab6980af96a718e90ca408c07cd Mon Sep 17 00:00:00 2001 From: Carolyn Date: Fri, 21 Mar 2025 16:38:16 +0000 Subject: [PATCH] CLDC-3899 fix flaky test occasionally picking bad input --- spec/helpers/check_answers_helper_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/helpers/check_answers_helper_spec.rb b/spec/helpers/check_answers_helper_spec.rb index 9fb98946a..a7d18295a 100644 --- a/spec/helpers/check_answers_helper_spec.rb +++ b/spec/helpers/check_answers_helper_spec.rb @@ -41,7 +41,7 @@ RSpec.describe CheckAnswersHelper do describe "#get_answer_label" do context "when unanswered and bulk upload" do - let(:question) { log.form.questions.sample } + let(:question) { log.form.questions.reject { |q| log.optional_fields.include?(q.id) }.sample } let(:bulk_upload) { create(:bulk_upload) } let(:log) { create(:sales_log, creation_method: "bulk upload", bulk_upload:) }