From 1283dee7cc8a75e9d4108ca174d9ddb29378476b Mon Sep 17 00:00:00 2001 From: samyou-softwire Date: Thu, 19 Feb 2026 17:03:53 +0000 Subject: [PATCH] fixup! CLDC-4012: Add tests move R overrides for integers to their own test --- .../bulk_upload/lettings/year2025/row_parser_spec.rb | 9 +++++++-- .../bulk_upload/lettings/year2026/row_parser_spec.rb | 9 +++++++-- .../bulk_upload/sales/year2025/row_parser_spec.rb | 9 +++++++-- .../bulk_upload/sales/year2026/row_parser_spec.rb | 9 +++++++-- 4 files changed, 28 insertions(+), 8 deletions(-) diff --git a/spec/services/bulk_upload/lettings/year2025/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2025/row_parser_spec.rb index 6d4bf8b54..650f53168 100644 --- a/spec/services/bulk_upload/lettings/year2025/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2025/row_parser_spec.rb @@ -543,8 +543,13 @@ RSpec.describe BulkUpload::Lettings::Year2025::RowParser do end context "and case insensitive fields are set to lowercase" do - let(:case_insensitive_fields) { %w[field_42 field_48 field_52 field_56 field_60 field_64 field_68 field_72 field_43 field_49 field_53 field_57 field_61 field_65 field_69 field_73] } - let(:attributes) { valid_attributes.merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) } + let(:case_insensitive_fields) { %w[field_43 field_49 field_53 field_57 field_61 field_65 field_69 field_73] } + let(:case_insensitive_integer_fields_with_r_option) { %w[field_42 field_48 field_52 field_56 field_60 field_64 field_68 field_72] } + let(:attributes) do + valid_attributes + .merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) + .merge(case_insensitive_integer_fields_with_r_option.each_with_object({}) { |field, h| h[field.to_sym] = "r" }) + end it "is still valid" do expect(parser).to be_valid diff --git a/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb b/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb index 35c62b467..83122c9e9 100644 --- a/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb +++ b/spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb @@ -571,8 +571,13 @@ RSpec.describe BulkUpload::Lettings::Year2026::RowParser do end context "and case insensitive fields are set to lowercase" do - let(:case_insensitive_fields) { %w[field_42 field_48 field_52 field_56 field_60 field_64 field_68 field_72 field_130 field_131 field_132 field_133 field_134 field_135 field_136 field_137] } - let(:attributes) { valid_attributes.merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) } + let(:case_insensitive_fields) { %w[field_130 field_131 field_132 field_133 field_134 field_135 field_136 field_137] } + let(:case_insensitive_integer_fields_with_r_option) { %w[field_42 field_48 field_52 field_56 field_60 field_64 field_68 field_72] } + let(:attributes) do + valid_attributes + .merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) + .merge(case_insensitive_integer_fields_with_r_option.each_with_object({}) { |field, h| h[field.to_sym] = "r" }) + end it "is still valid" do expect(parser).to be_valid diff --git a/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb index 4b60b1332..8ce985445 100644 --- a/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb @@ -294,8 +294,13 @@ RSpec.describe BulkUpload::Sales::Year2025::RowParser do end context "and case insensitive fields are set to lowercase" do - let(:case_insensitive_fields) { %w[field_28 field_35 field_43 field_47 field_51 field_55 field_29 field_36 field_44 field_48 field_52 field_56 field_58 field_64 field_75 field_70 field_72] } - let(:attributes) { valid_attributes.merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) } + let(:case_insensitive_fields) { %w[field_29 field_36 field_44 field_48 field_52 field_56] } + let(:case_insensitive_integer_fields_with_r_option) { %w[field_28 field_35 field_43 field_47 field_51 field_55 field_58 field_64 field_75 field_70 field_72] } + let(:attributes) do + valid_attributes + .merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) + .merge(case_insensitive_integer_fields_with_r_option.each_with_object({}) { |field, h| h[field.to_sym] = "r" }) + end it "is still valid" do expect(parser).to be_valid diff --git a/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb index ab5e18f9f..a6d1c9190 100644 --- a/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb @@ -300,8 +300,13 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do end context "and case insensitive fields are set to lowercase" do - let(:case_insensitive_fields) { %w[field_28 field_35 field_43 field_47 field_51 field_55 field_122 field_123 field_124 field_125 field_126 field_127 field_58 field_64 field_75 field_70 field_72] } - let(:attributes) { valid_attributes.merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) } + let(:case_insensitive_fields) { %w[field_122 field_123 field_124 field_125 field_126 field_127] } + let(:case_insensitive_integer_fields_with_r_option) { %w[field_28 field_35 field_43 field_47 field_51 field_55 field_58 field_64 field_75 field_70 field_72] } + let(:attributes) do + valid_attributes + .merge(case_insensitive_fields.each_with_object({}) { |field, h| h[field.to_sym] = valid_attributes[field.to_sym]&.downcase }) + .merge(case_insensitive_integer_fields_with_r_option.each_with_object({}) { |field, h| h[field.to_sym] = "r" }) + end it "is still valid" do expect(parser).to be_valid