Assign relat value

app/services/bulk_upload/sales/year2025/row_parser.rb

@@ -806,31 +806,11 @@ private
     attributes["sex5"] = field_52
     attributes["sex6"] = field_56
 
-    attributes["relat2"] = if field_34 == 1
+    attributes["relat2"] = relat(field_34)
-                             "P"
+    attributes["relat3"] = relat(field_42)
-                           else
+    attributes["relat4"] = relat(field_46)
-                             (field_34 == 2 ? "X" : "R")
+    attributes["relat5"] = relat(field_50)
-                           end
+    attributes["relat6"] = relat(field_54)
-    attributes["relat3"] = if field_42 == 1
-                             "P"
-                           else
-                             (field_42 == 2 ? "X" : "R")
-                           end
-    attributes["relat4"] = if field_46 == 1
-                             "P"
-                           else
-                             (field_46 == 2 ? "X" : "R")
-                           end
-    attributes["relat5"] = if field_50 == 1
-                             "P"
-                           else
-                             (field_50 == 2 ? "X" : "R")
-                           end
-    attributes["relat6"] = if field_54 == 1
-                             "P"
-                           else
-                             (field_54 == 2 ? "X" : "R")
-                           end
 
     attributes["ecstat1"] = field_32
     attributes["ecstat2"] = field_39
@@ -1329,6 +1309,11 @@ private
     12
   end
 
+  def relat(field_value)
+    values = { 1 => "P", 2 => "X", 3 => "R" }
+    values[field_value]
+  end
+
   def validate_managing_org_related
     if owning_organisation && managing_organisation && !owning_organisation.can_be_managed_by?(organisation: managing_organisation)
       block_log_creation!