Browse Source

CLDC-4432: Add tests

pull/3322/head
samyou-softwire 3 weeks ago
parent
commit
13a50efd63
  1. 17
      spec/services/bulk_upload/lettings/year2025/row_parser_spec.rb
  2. 17
      spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb
  3. 17
      spec/services/bulk_upload/sales/year2025/row_parser_spec.rb
  4. 17
      spec/services/bulk_upload/sales/year2026/row_parser_spec.rb

17
spec/services/bulk_upload/lettings/year2025/row_parser_spec.rb

@ -646,9 +646,9 @@ RSpec.describe BulkUpload::Lettings::Year2025::RowParser do
end end
describe "invalid fields" do describe "invalid fields" do
let(:attributes) { setup_section_params.merge({ field_45: 0 }) }
context "when a field has been marked as invalid" do context "when a field has been marked as invalid" do
let(:attributes) { setup_section_params.merge({ field_45: 0 }) }
before do before do
parser.add_invalid_field("field_45") parser.add_invalid_field("field_45")
end end
@ -659,6 +659,19 @@ RSpec.describe BulkUpload::Lettings::Year2025::RowParser do
expect(parser.errors[:field_45]).to include(I18n.t("validations.lettings.2025.bulk_upload.invalid_option", question: "What is the lead tenant’s nationality?")) expect(parser.errors[:field_45]).to include(I18n.t("validations.lettings.2025.bulk_upload.invalid_option", question: "What is the lead tenant’s nationality?"))
end end
end end
context "when a field has been marked as invalid but it is not routed to" do
let(:attributes) { setup_section_params.merge({ field_117: 2 }) }
before do
parser.add_invalid_field("field_118")
end
it "does not set an error on that field" do
parser.valid?
expect(parser.errors[:field_118].size).to eq(0)
end
end
end end
end end
end end

17
spec/services/bulk_upload/lettings/year2026/row_parser_spec.rb

@ -538,9 +538,9 @@ RSpec.describe BulkUpload::Lettings::Year2026::RowParser do
end end
describe "invalid fields" do describe "invalid fields" do
let(:attributes) { setup_section_params.merge({ field_46: 0 }) }
context "when a field has been marked as invalid" do context "when a field has been marked as invalid" do
let(:attributes) { setup_section_params.merge({ field_46: 0 }) }
before do before do
parser.add_invalid_field("field_46") parser.add_invalid_field("field_46")
end end
@ -551,6 +551,19 @@ RSpec.describe BulkUpload::Lettings::Year2026::RowParser do
expect(parser.errors[:field_46]).to include(match(I18n.t("validations.lettings.2026.bulk_upload.invalid_option", question: "What is the lead tenant’s nationality?"))) expect(parser.errors[:field_46]).to include(match(I18n.t("validations.lettings.2026.bulk_upload.invalid_option", question: "What is the lead tenant’s nationality?")))
end end
end end
context "when a field has been marked as invalid but it is not routed to" do
let(:attributes) { setup_section_params.merge({ field_135: 2 }) }
before do
parser.add_invalid_field("field_136")
end
it "does not set an error on that field" do
parser.valid?
expect(parser.errors[:field_136].size).to eq(0)
end
end
end end
end end

17
spec/services/bulk_upload/sales/year2025/row_parser_spec.rb

@ -338,9 +338,9 @@ RSpec.describe BulkUpload::Sales::Year2025::RowParser do
end end
describe "invalid fields" do describe "invalid fields" do
let(:attributes) { setup_section_params.merge({ field_31: 0 }) }
context "when a field has been marked as invalid" do context "when a field has been marked as invalid" do
let(:attributes) { setup_section_params.merge({ field_10: 2, field_31: 0 }) }
before do before do
parser.add_invalid_field("field_31") parser.add_invalid_field("field_31")
end end
@ -351,6 +351,19 @@ RSpec.describe BulkUpload::Sales::Year2025::RowParser do
expect(parser.errors[:field_31]).to include(match(I18n.t("validations.sales.2025.bulk_upload.invalid_option", question: "What is buyer 1’s nationality?"))) expect(parser.errors[:field_31]).to include(match(I18n.t("validations.sales.2025.bulk_upload.invalid_option", question: "What is buyer 1’s nationality?")))
end end
end end
context "when a field has been marked as invalid but it is not routed to" do
let(:attributes) { setup_section_params.merge({ field_10: 1, field_31: 0 }) }
before do
parser.add_invalid_field("field_31")
end
it "does not set an error on that field" do
parser.valid?
expect(parser.errors[:field_31].size).to eq(0)
end
end
end end
end end
end end

17
spec/services/bulk_upload/sales/year2026/row_parser_spec.rb

@ -344,9 +344,9 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do
end end
describe "invalid fields" do describe "invalid fields" do
let(:attributes) { setup_section_params.merge({ field_34: 0 }) }
context "when a field has been marked as invalid" do context "when a field has been marked as invalid" do
let(:attributes) { setup_section_params.merge({ field_10: "2", field_34: 0 }) }
before do before do
parser.add_invalid_field("field_34") parser.add_invalid_field("field_34")
end end
@ -357,6 +357,19 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do
expect(parser.errors[:field_34]).to include(match(I18n.t("validations.sales.2026.bulk_upload.invalid_option", question: "What is buyer 1's nationality?"))) expect(parser.errors[:field_34]).to include(match(I18n.t("validations.sales.2026.bulk_upload.invalid_option", question: "What is buyer 1's nationality?")))
end end
end end
context "when a field has been marked as invalid but it is not routed to" do
let(:attributes) { setup_section_params.merge({ field_10: "1", field_34: 0 }) }
before do
parser.add_invalid_field("field_34")
end
it "does not set an error on that field" do
parser.valid?
expect(parser.errors[:field_34].size).to eq(0)
end
end
end end
end end
end end

Loading…
Cancel
Save