From 1511985df4e0b19d00469d26f58fe5515a38fde2 Mon Sep 17 00:00:00 2001
From: Kat <54268893+kosiakkatrina@users.noreply.github.com>
Date: Wed, 30 Oct 2024 08:17:20 +0000
Subject: [PATCH] Update tests and lint

---
 app/views/form/guidance/_scheme_selection.html.erb | 2 +-
 app/views/form/guidance/_void_date.html.erb        | 2 +-
 spec/requests/form_controller_spec.rb              | 2 +-
 spec/views/form/page_view_spec.rb                  | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/app/views/form/guidance/_scheme_selection.html.erb b/app/views/form/guidance/_scheme_selection.html.erb
index 804465962..3aaff4a4a 100644
--- a/app/views/form/guidance/_scheme_selection.html.erb
+++ b/app/views/form/guidance/_scheme_selection.html.erb
@@ -1,5 +1,5 @@
 <% if current_user.data_provider? %>
-  <p class="govuk-body"><%= I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.content", users_page_link: "#{govuk_link_to I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.users_page_link_text"), users_path}").html_safe %></p>
+  <p class="govuk-body"><%= I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.content", users_page_link: govuk_link_to(I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_provider.users_page_link_text"), users_path).to_s).html_safe %></p>
 <% elsif current_user.data_coordinator? %>
   <p class="govuk-body"><%= govuk_link_to I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.scheme_selection.data_coordinator.create_scheme_link_text"), new_scheme_path %></p>
 <% end %>
diff --git a/app/views/form/guidance/_void_date.html.erb b/app/views/form/guidance/_void_date.html.erb
index 5a0cf18c8..76e9e22e2 100644
--- a/app/views/form/guidance/_void_date.html.erb
+++ b/app/views/form/guidance/_void_date.html.erb
@@ -2,4 +2,4 @@
   <%= govuk_details(summary_text: I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.void_date.title")) do %>
     <%= I18n.t("forms.#{@log.form.start_date.year}.lettings.guidance.void_date.content").html_safe %>
   <% end %>
-</div>
\ No newline at end of file
+</div>
diff --git a/spec/requests/form_controller_spec.rb b/spec/requests/form_controller_spec.rb
index 94f6595c7..13d711c20 100644
--- a/spec/requests/form_controller_spec.rb
+++ b/spec/requests/form_controller_spec.rb
@@ -412,7 +412,7 @@ RSpec.describe FormController, type: :request do
         context "with a form page that has custom guidance" do
           it "displays the correct partial" do
             get "/lettings-logs/#{lettings_log.id}/net-income", headers: headers, params: {}
-            expect(response.body).to match("What counts as income?")
+            expect(response.body).to match(I18n.t("forms.2021.lettings.guidance.what_counts_as_income.title"))
           end
         end
 
diff --git a/spec/views/form/page_view_spec.rb b/spec/views/form/page_view_spec.rb
index 16c4c0672..a95c98e93 100644
--- a/spec/views/form/page_view_spec.rb
+++ b/spec/views/form/page_view_spec.rb
@@ -100,7 +100,7 @@ RSpec.describe "form/page" do
   end
 
   context "with a question containing extra guidance" do
-    let(:expected_guidance) { /What counts as income?/ }
+    let(:expected_guidance) { /#{I18n.t("forms.2021.lettings.guidance.what_counts_as_income.content")}/ }
 
     context "with radio type" do
       let(:question_attributes) { { type: "radio", answer_options: { "1": "A", "2": "B" } } }