From 16c0977aa96c5de183d70d4a8e8295bee6aa5eda Mon Sep 17 00:00:00 2001
From: Kat <katrina@madetech.com>
Date: Fri, 27 May 2022 09:25:07 +0100
Subject: [PATCH] Allow support users and data coordinators to toggle active
 users

---
 app/controllers/users_controller.rb    |  4 ++--
 spec/requests/users_controller_spec.rb | 30 ++++++++++++++++++++++++++
 2 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
index 2e0dcf1cd..b0f279cdb 100644
--- a/app/controllers/users_controller.rb
+++ b/app/controllers/users_controller.rb
@@ -116,9 +116,9 @@ private
         params.require(:user).permit(:email, :name, :password, :password_confirmation)
       end
     elsif current_user.data_coordinator?
-      params.require(:user).permit(:email, :name, :role, :is_dpo, :is_key_contact)
+      params.require(:user).permit(:email, :name, :role, :is_dpo, :is_key_contact, :active)
     elsif current_user.support?
-      params.require(:user).permit(:email, :name, :role, :is_dpo, :is_key_contact, :organisation_id)
+      params.require(:user).permit(:email, :name, :role, :is_dpo, :is_key_contact, :organisation_id, :active)
     end
   end
 
diff --git a/spec/requests/users_controller_spec.rb b/spec/requests/users_controller_spec.rb
index 51e63286f..1a297d6ab 100644
--- a/spec/requests/users_controller_spec.rb
+++ b/spec/requests/users_controller_spec.rb
@@ -686,6 +686,36 @@ RSpec.describe UsersController, type: :request do
                 .to change { other_user.reload.name }.from("filter name").to("new name")
             end
           end
+
+          context "when the data coordinator edits the user" do
+            let(:params) do
+              {
+                id: other_user.id, user: { active: value }
+              }
+            end
+
+            context "and tries to deactivate the user" do
+              let(:value) { false }
+
+              it "marks user as deactivated" do
+                expect { patch "/users/#{other_user.id}", headers:, params: }
+                  .to change { other_user.reload.active }.from(true).to(false)
+              end
+            end
+
+            context "and tries to activate deactivated user" do
+              let(:value) { true }
+
+              before do
+                other_user.update!(active: false)
+              end
+
+              it "marks user as active" do
+                expect { patch "/users/#{other_user.id}", headers:, params: }
+                  .to change { other_user.reload.active }.from(false).to(true)
+              end
+            end
+          end
         end
 
         context "when the current user does not match the user ID" do