From 17358e1d292c60ef2f380d35c965f5ce3da9c5b4 Mon Sep 17 00:00:00 2001 From: Kat <54268893+kosiakkatrina@users.noreply.github.com> Date: Mon, 2 Dec 2024 13:12:17 +0000 Subject: [PATCH] Remove create_logs? method --- .../bulk_upload/lettings/validator.rb | 14 ----------- app/services/bulk_upload/sales/validator.rb | 25 ------------------- 2 files changed, 39 deletions(-) diff --git a/app/services/bulk_upload/lettings/validator.rb b/app/services/bulk_upload/lettings/validator.rb index 85b0ea71b..291bf45e7 100644 --- a/app/services/bulk_upload/lettings/validator.rb +++ b/app/services/bulk_upload/lettings/validator.rb @@ -40,20 +40,6 @@ class BulkUpload::Lettings::Validator end end - # def create_logs? - # if block_log_creation_reason.present? - # case block_log_creation_reason - # when "row_parser_block_log_creation" - # Sentry.capture_message("Bulk upload log creation blocked: #{bulk_upload.id}.") - # when "logs_invalid" - # Sentry.capture_message("Bulk upload log creation blocked due to invalid logs after blanking non setup fields: #{bulk_upload.id}.") - # end - # return false - # end - - # true - # end - def block_log_creation_reason return "setup_errors" if any_setup_errors? diff --git a/app/services/bulk_upload/sales/validator.rb b/app/services/bulk_upload/sales/validator.rb index 4918ce51e..7ad9638d7 100644 --- a/app/services/bulk_upload/sales/validator.rb +++ b/app/services/bulk_upload/sales/validator.rb @@ -39,31 +39,6 @@ class BulkUpload::Sales::Validator end end - # def create_logs? - # return false if any_setup_errors? - - # if row_parsers.any?(&:block_log_creation?) - # Sentry.capture_message("Bulk upload log creation blocked: #{bulk_upload.id}.") - # return false - # end - - # if any_logs_already_exist? && FeatureToggle.bulk_upload_duplicate_log_check_enabled? - # Sentry.capture_message("Bulk upload log creation blocked due to duplicate logs: #{bulk_upload.id}.") - # return false - # end - - # row_parsers.each do |row_parser| - # row_parser.log.blank_invalid_non_setup_fields! - # end - - # if any_logs_invalid? - # Sentry.capture_message("Bulk upload log creation blocked due to invalid logs after blanking non setup fields: #{bulk_upload.id}.") - # return false - # end - - # true - # end - def block_log_creation_reason return "setup_errors" if any_setup_errors?