From 1b13106612f6e0d1152cb9c9fddf688ea8d125b4 Mon Sep 17 00:00:00 2001 From: baarkerlounger Date: Thu, 21 Jul 2022 16:54:53 +0100 Subject: [PATCH] Remove change links for confirmed schemes --- app/views/schemes/check_answers.html.erb | 60 ++++++++++++++---------- spec/features/schemes_spec.rb | 10 ++++ 2 files changed, 46 insertions(+), 24 deletions(-) diff --git a/app/views/schemes/check_answers.html.erb b/app/views/schemes/check_answers.html.erb index e84d49503..179a1afca 100644 --- a/app/views/schemes/check_answers.html.erb +++ b/app/views/schemes/check_answers.html.erb @@ -11,40 +11,48 @@ <%= summary_list.row do |row| %> <% row.key { attr[:name].to_s } %> <% row.value { details_html(attr) } %> - <% row.action( - text: "Change", - href: scheme_details_path(scheme_id: @scheme.id, check_answers: true), - ) %> + <% unless @scheme.confirmed? && attr[:name] != "Name" %> + <% row.action( + text: "Change", + href: scheme_details_path(@scheme, check_answers: true), + ) %> + <% end %> <% end %> <% end %> <% @scheme.check_support_services_provider_attributes.each do |attr| %> <%= summary_list.row do |row| %> <% row.key { attr[:name].to_s } %> <% row.value { details_html(attr) } %> - <% row.action( - text: "Change", - href: scheme_support_services_provider_path(scheme_id: @scheme.id, check_answers: true), - ) %> + <% unless @scheme.confirmed? %> + <% row.action( + text: "Change", + href: scheme_support_services_provider_path(@scheme, check_answers: true), + ) %> + <% end %> <% end %> <% end %> <% @scheme.check_primary_client_attributes.each do |attr| %> <%= summary_list.row do |row| %> <% row.key { attr[:name].to_s } %> <% row.value { details_html(attr) } %> - <% row.action( - text: "Change", - href: scheme_primary_client_group_path(scheme_id: @scheme.id, check_answers: true), - ) %> + <% unless @scheme.confirmed? %> + <% row.action( + text: "Change", + href: scheme_primary_client_group_path(@scheme, check_answers: true), + ) %> + <% end %> <% end %> <% end %> <% @scheme.check_secondary_client_confirmation_attributes.each do |attr| %> <%= summary_list.row do |row| %> <% row.key { attr[:name].to_s } %> <% row.value { details_html(attr) } %> - <% row.action( - text: "Change", - href: scheme_confirm_secondary_client_group_path(scheme_id: @scheme.id, check_answers: true), - ) %> + <% unless @scheme.confirmed? %> + <% row.action( + text: "Change", + href: scheme_confirm_secondary_client_group_path(@scheme, check_answers: true), + ) %> + <% end %> <% end %> <% end %> <% if @scheme.has_other_client_group == "Yes" %> @@ -52,10 +60,12 @@ <%= summary_list.row do |row| %> <% row.key { attr[:name].to_s } %> <% row.value { details_html(attr) } %> - <% row.action( - text: "Change", - href: scheme_secondary_client_group_path(scheme_id: @scheme.id, check_answers: true), - ) %> + <% unless @scheme.confirmed? %> + <% row.action( + text: "Change", + href: scheme_secondary_client_group_path(@scheme, check_answers: true), + ) %> + <% end %> <% end %> <% end %> <% end %> @@ -63,10 +73,12 @@ <%= summary_list.row do |row| %> <% row.key { attr[:name].to_s } %> <% row.value { details_html(attr) } %> - <% row.action( - text: "Change", - href: scheme_support_path(scheme_id: @scheme.id, check_answers: true), - ) %> + <% unless @scheme.confirmed? %> + <% row.action( + text: "Change", + href: scheme_support_path(@scheme, check_answers: true), + ) %> + <% end %> <% end %> <% end %> <% end %> diff --git a/spec/features/schemes_spec.rb b/spec/features/schemes_spec.rb index 0ad1919d6..e2e293242 100644 --- a/spec/features/schemes_spec.rb +++ b/spec/features/schemes_spec.rb @@ -275,6 +275,16 @@ RSpec.describe "Schemes scheme Features" do expect(page).to have_button("Save") expect(page).not_to have_button("Create scheme") end + + context "when you click to view the scheme details" do + before do + click_link("Scheme") + end + + it "does not let you change details other than the name" do + assert_selector "a", text: "Change", count: 1 + end + end end end end