From 1f02a351860d90f350fd19f47462373e8a728214 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Meny?= Date: Wed, 3 Aug 2022 11:23:11 +0100 Subject: [PATCH] Makes the invalid user save more explicit --- .../form/setup/questions/created_by_id_spec.rb | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/spec/models/form/setup/questions/created_by_id_spec.rb b/spec/models/form/setup/questions/created_by_id_spec.rb index 6bc921087..04b6a1635 100644 --- a/spec/models/form/setup/questions/created_by_id_spec.rb +++ b/spec/models/form/setup/questions/created_by_id_spec.rb @@ -8,11 +8,14 @@ RSpec.describe Form::Setup::Questions::CreatedById, type: :model do let(:page) { instance_double(Form::Page) } let(:subsection) { instance_double(Form::Subsection) } let(:form) { instance_double(Form) } - let!(:user_1) { FactoryBot.create(:user, name: "first user") } - let!(:user_2) { FactoryBot.create(:user, name: "second user") } - let(:user_3) { FactoryBot.build(:user, name: nil, email: "madeupmail@example.com") } - let(:users) { [user_1, user_2, user_3] } - let(:expected_answer_options) do + let(:user_1) { FactoryBot.create(:user, name: "first user") } + let(:user_2) { FactoryBot.create(:user, name: "second user") } + let(:user_3) do + user = FactoryBot.build(:user, name: nil, email: "madeupmail@example.com") + user.save!(validate: false) + user + end + let!(:expected_answer_options) do { "" => "Select an option", user_1.id => user_1.name, @@ -21,10 +24,6 @@ RSpec.describe Form::Setup::Questions::CreatedById, type: :model do } end - before do - allow(User).to receive(:select).and_return users - end - it "has correct page" do expect(question.page).to eq(page) end