From 2016dfdaa0968dbd06bd616e1125f76093390252 Mon Sep 17 00:00:00 2001
From: Nat Dean-Lewis <nat.dean-lewis@softwire.com>
Date: Thu, 23 Apr 2026 10:03:40 +0100
Subject: [PATCH] CLDC-4071: wip change link behaviour

---
 app/helpers/user_helper.rb | 30 ++++++++++++++++++++++++++----
 1 file changed, 26 insertions(+), 4 deletions(-)

diff --git a/app/helpers/user_helper.rb b/app/helpers/user_helper.rb
index 931f18680..b1ecdc7ad 100644
--- a/app/helpers/user_helper.rb
+++ b/app/helpers/user_helper.rb
@@ -82,13 +82,21 @@ module UserHelper
 
     case attribute
     when "role"
-      current_user.data_coordinator? || current_user.support? ? govuk_link_to("Select role", aliased_user_edit(user, current_user), class: "govuk-link govuk-link--no-visited-state") : "No role assigned"
+      if current_user.data_coordinator? || current_user.support?
+        edit_link("Select role", user, current_user)
+      else
+        "No role assigned"
+      end
     when "phone"
-      govuk_link_to("Enter telephone number", aliased_user_edit(user, current_user), class: "govuk-link govuk-link--no-visited-state")
+      edit_link("Enter telephone number", user, current_user)
     when "phone_extension"
-      current_user.data_coordinator? || current_user.support? ? govuk_link_to("Enter extension number", aliased_user_edit(user, current_user), class: "govuk-link govuk-link--no-visited-state") : "No answer provided"
+      if user == current_user || current_user.data_coordinator? || current_user.support?
+        edit_link("Enter extension number", user, current_user)
+      else
+        no_answer_provided_text
+      end
     else
-      "No answer provided"
+      no_answer_provided_text
     end
   end
 
@@ -97,4 +105,18 @@ module UserHelper
 
     ""
   end
+
+private
+
+  def edit_link(text, user, current_user)
+    govuk_link_to(
+      text,
+      aliased_user_edit(user, current_user),
+      class: "govuk-link govuk-link--no-visited-state",
+    )
+  end
+
+  def no_answer_provided_text
+    "No answer provided"
+  end
 end