Fixes

app/models/form/sales/pages/buyer1_income_ecstat_value_check.rb

@@ -3,7 +3,7 @@ class Form::Sales::Pages::Buyer1IncomeEcstatValueCheck < ::Form::Page
     super
     @depends_on = [
       {
-        "income1_out_of_soft_range?" => true,
+        "income1_outside_soft_range_for_ecstat?" => true,
       },
     ]
     @copy_key = "sales.soft_validations.income1_value_check.ecstat"

app/models/form/sales/pages/buyer2_income_ecstat_value_check.rb

@@ -3,7 +3,7 @@ class Form::Sales::Pages::Buyer2IncomeEcstatValueCheck < ::Form::Page
     super
     @depends_on = [
       {
-        "income2_out_of_soft_range?" => true,
+        "income2_outside_soft_range_for_ecstat?" => true,
       },
     ]
     @copy_key = "sales.soft_validations.income2_value_check.ecstat"

spec/models/form/sales/pages/buyer1_income_ecstat_value_check_spec.rb

@@ -1,9 +1,9 @@
 require "rails_helper"
 
-RSpec.describe Form::Sales::Pages::Buyer1IncomeMinValueCheck, type: :model do
+RSpec.describe Form::Sales::Pages::Buyer1IncomeEcstatValueCheck, type: :model do
   subject(:page) { described_class.new(page_id, page_definition, subsection) }
 
-  let(:page_id) { "prefix_buyer_1_income_min_value_check" }
+  let(:page_id) { "prefix_buyer_1_income_ecstat_value_check" }
   let(:page_definition) { nil }
   let(:form) { instance_double(Form, start_date: Time.zone.local(2024, 4, 1)) }
   let(:subsection) { instance_double(Form::Subsection, form:) }
@@ -17,13 +17,13 @@ RSpec.describe Form::Sales::Pages::Buyer1IncomeMinValueCheck, type: :model do
   end
 
   it "has the correct id" do
-    expect(page.id).to eq("prefix_buyer_1_income_min_value_check")
+    expect(page.id).to eq("prefix_buyer_1_income_ecstat_value_check")
   end
 
   it "has correct depends_on" do
     expect(page.depends_on).to eq([
       {
-        "income1_under_soft_min?" => true,
+        "income1_outside_soft_range_for_ecstat?" => true,
       },
     ])
   end

spec/models/form/sales/pages/buyer2_income_ecstat_value_check_spec.rb

@@ -1,9 +1,9 @@
 require "rails_helper"
 
-RSpec.describe Form::Sales::Pages::Buyer2IncomeMinValueCheck, type: :model do
+RSpec.describe Form::Sales::Pages::Buyer2IncomeEcstatValueCheck, type: :model do
   subject(:page) { described_class.new(page_id, page_definition, subsection) }
 
-  let(:page_id) { "prefix_buyer_2_income_min_value_check" }
+  let(:page_id) { "prefix_buyer_2_income_ecstat_value_check" }
   let(:page_definition) { nil }
   let(:form) { instance_double(Form, start_date: Time.zone.local(2024, 4, 1)) }
   let(:subsection) { instance_double(Form::Subsection, form:) }
@@ -17,13 +17,13 @@ RSpec.describe Form::Sales::Pages::Buyer2IncomeMinValueCheck, type: :model do
   end
 
   it "has the correct id" do
-    expect(page.id).to eq("prefix_buyer_2_income_min_value_check")
+    expect(page.id).to eq("prefix_buyer_2_income_ecstat_value_check")
   end
 
   it "has correct depends_on" do
     expect(page.depends_on).to eq([
       {
-        "income2_under_soft_min?" => true,
+        "income2_outside_soft_range_for_ecstat?" => true,
       },
     ])
   end