From 24562a28268a0f1f0bda8ad17546a24fd5e6b489 Mon Sep 17 00:00:00 2001 From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com> Date: Tue, 18 Feb 2025 15:59:53 +0000 Subject: [PATCH] Update request tests --- app/models/derived_variables/lettings_log_variables.rb | 1 + app/models/log.rb | 3 +-- spec/factories/lettings_log.rb | 2 +- spec/requests/address_search_controller_spec.rb | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/models/derived_variables/lettings_log_variables.rb b/app/models/derived_variables/lettings_log_variables.rb index 41ad8b0ec..8f387ac2b 100644 --- a/app/models/derived_variables/lettings_log_variables.rb +++ b/app/models/derived_variables/lettings_log_variables.rb @@ -116,6 +116,7 @@ module DerivedVariables::LettingsLogVariables if manual_address_entry_selected self.uprn_known = 0 self.uprn_selection = nil + self.uprn_confirmed = nil else self.uprn_confirmed = 1 if uprn.present? self.uprn_known = 1 if uprn.present? diff --git a/app/models/log.rb b/app/models/log.rb index d70d23751..1454aef65 100644 --- a/app/models/log.rb +++ b/app/models/log.rb @@ -75,8 +75,7 @@ class Log < ApplicationRecord presenter = UprnDataPresenter.new(service.result) self.uprn_known = 1 - # self.uprn_confirmed = nil unless skip_update_uprn_confirmed TODO: REMOVE - self.uprn_selection = nil + self.uprn_selection = uprn self.address_line1 = presenter.address_line1 self.address_line2 = presenter.address_line2 self.town_or_city = presenter.town_or_city diff --git a/spec/factories/lettings_log.rb b/spec/factories/lettings_log.rb index 0d200dcba..131ca6e2e 100644 --- a/spec/factories/lettings_log.rb +++ b/spec/factories/lettings_log.rb @@ -173,7 +173,7 @@ FactoryBot.define do log.postcode_full_input = log.postcode_full log.nationality_all_group = 826 log.uprn = evaluator.uprn || "10033558653" - log.uprn_selection = evaluator.uprn_selection || "1" + log.uprn_selection = evaluator.uprn_selection || "10033558653" end end end diff --git a/spec/requests/address_search_controller_spec.rb b/spec/requests/address_search_controller_spec.rb index e4ef054e5..5c2acd11a 100644 --- a/spec/requests/address_search_controller_spec.rb +++ b/spec/requests/address_search_controller_spec.rb @@ -50,7 +50,7 @@ RSpec.describe AddressSearchController, type: :request do expect(lettings_log.uprn_known).to eq(1) expect(lettings_log.uprn).to eq("10033558653") expect(lettings_log.uprn_confirmed).to eq(1) - expect(lettings_log.uprn_selection).to eq(nil) + expect(lettings_log.uprn_selection).to eq("10033558653") expect(lettings_log.postcode_known).to eq(1) expect(lettings_log.postcode_full).to eq("SW1A 1AA") expect(lettings_log.address_line1).to eq("The Mall, City Of Westminster")