Browse Source

remove test

bulk-upload-resume-v2
Phil Lee 2 years ago
parent
commit
251b3979d2
  1. 2
      app/services/bulk_upload/lettings/log_creator.rb
  2. 4
      spec/services/bulk_upload/lettings/log_creator_spec.rb
  3. 59
      spec/services/bulk_upload/processor_spec.rb

2
app/services/bulk_upload/lettings/log_creator.rb

@ -21,6 +21,8 @@ class BulkUpload::Lettings::LogCreator
Sentry.capture_exception(e)
end
end
bulk_upload.update!(processed: true)
end
private

4
spec/services/bulk_upload/lettings/log_creator_spec.rb

@ -22,6 +22,10 @@ RSpec.describe BulkUpload::Lettings::LogCreator do
expect(log.bulk_upload).to eql(bulk_upload)
expect(bulk_upload.lettings_logs).to include(log)
end
it "marks bulk upload as processed" do
expect { service.call }.to change(bulk_upload, :processed?).from(false).to(true)
end
end
context "when a valid csv with several blank rows" do

59
spec/services/bulk_upload/processor_spec.rb

@ -179,65 +179,6 @@ RSpec.describe BulkUpload::Processor do
end
end
context "when processing a bulk upload with errors but above threshold (therefore does not create logs)" do
let(:mock_downloader) do
instance_double(
BulkUpload::Downloader,
call: nil,
path: file_fixture("2022_23_lettings_bulk_upload.csv"),
delete_local_file!: nil,
)
end
let(:mock_validator) do
instance_double(
BulkUpload::Lettings::Validator,
invalid?: false,
call: nil,
any_setup_errors?: false,
create_logs?: false,
)
end
before do
allow(BulkUpload::Downloader).to receive(:new).with(bulk_upload:).and_return(mock_downloader)
allow(BulkUpload::Lettings::Validator).to receive(:new).and_return(mock_validator)
end
it "deletes the local file afterwards" do
processor.call
expect(mock_downloader).to have_received(:delete_local_file!)
end
it "sends correct and upload again mail" do
mail_double = instance_double("ActionMailer::MessageDelivery", deliver_later: nil)
allow(BulkUploadMailer).to receive(:send_correct_and_upload_again_mail).and_return(mail_double)
processor.call
expect(BulkUploadMailer).to have_received(:send_correct_and_upload_again_mail)
expect(mail_double).to have_received(:deliver_later)
end
it "does not send fix errors email" do
allow(BulkUploadMailer).to receive(:send_bulk_upload_with_errors_mail).and_call_original
processor.call
expect(BulkUploadMailer).not_to have_received(:send_bulk_upload_with_errors_mail)
end
it "does not send success email" do
allow(BulkUploadMailer).to receive(:send_bulk_upload_complete_mail).and_call_original
processor.call
expect(BulkUploadMailer).not_to have_received(:send_bulk_upload_complete_mail)
end
end
context "when processing a bulk with perfect data" do
let(:path) { file_fixture("2022_23_lettings_bulk_upload.csv") }

Loading…
Cancel
Save