From 287a1caeccb1bcbb855a7a2c28f4a29bd8aff04d Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire
 <94526761+natdeanlewissoftwire@users.noreply.github.com>
Date: Mon, 5 Feb 2024 09:26:34 +0000
Subject: [PATCH] feat: update hint text and test (#2182)

---
 .../form/lettings/questions/ppcodenk.rb       |  2 +-
 .../form/lettings/questions/ppcodenk_spec.rb  | 81 +++++++++++++++++++
 2 files changed, 82 insertions(+), 1 deletion(-)
 create mode 100644 spec/models/form/lettings/questions/ppcodenk_spec.rb

diff --git a/app/models/form/lettings/questions/ppcodenk.rb b/app/models/form/lettings/questions/ppcodenk.rb
index c8dbd24d0..88ca5277f 100644
--- a/app/models/form/lettings/questions/ppcodenk.rb
+++ b/app/models/form/lettings/questions/ppcodenk.rb
@@ -6,7 +6,7 @@ class Form::Lettings::Questions::Ppcodenk < ::Form::Question
     @header = "Do you know the postcode of the household’s last settled accommodation?"
     @type = "radio"
     @check_answers_card_number = 0
-    @hint_text = "This is also known as the household’s ‘last settled home’."
+    @hint_text = form.start_year_after_2024? ? "This is the tenant’s last long-standing home. It is where the tenant was living before any period in temporary accommodation, sleeping rough or otherwise homeless." : "This is also known as the household’s ‘last settled home’."
     @answer_options = ANSWER_OPTIONS
     @conditional_for = { "ppostcode_full" => [0] }
     @hidden_in_check_answers = { "depends_on" => [{ "ppcodenk" => 0 }, { "ppcodenk" => 1 }] }
diff --git a/spec/models/form/lettings/questions/ppcodenk_spec.rb b/spec/models/form/lettings/questions/ppcodenk_spec.rb
new file mode 100644
index 000000000..ad5e52e96
--- /dev/null
+++ b/spec/models/form/lettings/questions/ppcodenk_spec.rb
@@ -0,0 +1,81 @@
+require "rails_helper"
+
+RSpec.describe Form::Lettings::Questions::Ppcodenk, type: :model do
+  subject(:question) { described_class.new(nil, question_definition, page) }
+
+  let(:question_definition) { nil }
+  let(:page) { instance_double(Form::Page) }
+  let(:subsection) { instance_double(Form::Subsection) }
+  let(:form) { instance_double(Form) }
+
+  before do
+    allow(form).to receive(:start_year_after_2024?).and_return(false)
+    allow(page).to receive(:subsection).and_return(subsection)
+    allow(subsection).to receive(:form).and_return(form)
+  end
+
+  it "has correct page" do
+    expect(question.page).to eq(page)
+  end
+
+  it "has the correct type" do
+    expect(question.type).to eq("radio")
+  end
+
+  it "is not marked as derived" do
+    expect(question.derived?).to be false
+  end
+
+  it "has the correct answer_options" do
+    expect(question.answer_options).to eq({
+      "0" => { "value" => "Yes" },
+      "1" => { "value" => "No" },
+    })
+  end
+
+  it "has the correct check_answer_label" do
+    expect(question.check_answer_label).to eq("")
+  end
+
+  it "has the correct id" do
+    expect(question.id).to eq("ppcodenk")
+  end
+
+  it "has the correct header" do
+    expect(question.header).to eq("Do you know the postcode of the household’s last settled accommodation?")
+  end
+
+  it "has correct conditional for" do
+    expect(question.conditional_for).to eq({
+      "ppostcode_full" => [0],
+    })
+  end
+
+  it "has the correct hidden_in_check_answers" do
+    expect(question.hidden_in_check_answers).to eq(
+      {
+        "depends_on" => [{ "ppcodenk" => 0 }, { "ppcodenk" => 1 }],
+      },
+    )
+  end
+
+  it "has the correct check_answers_card_number" do
+    expect(question.check_answers_card_number).to eq(0)
+  end
+
+  context "with 2023/24 form" do
+    it "has the correct hint" do
+      expect(question.hint_text).to eq("This is also known as the household’s ‘last settled home’.")
+    end
+  end
+
+  context "with 2024/25 form" do
+    before do
+      allow(form).to receive(:start_year_after_2024?).and_return(true)
+    end
+
+    it "has the correct hint" do
+      expect(question.hint_text).to eq("This is the tenant’s last long-standing home. It is where the tenant was living before any period in temporary accommodation, sleeping rough or otherwise homeless.")
+    end
+  end
+end