From 2cb3674bdde967f1bb2271caaa551a7d2e88ca34 Mon Sep 17 00:00:00 2001
From: Manny Dinssa <44172848+Dinssa@users.noreply.github.com>
Date: Wed, 19 Mar 2025 12:00:18 +0000
Subject: [PATCH] Update query

---
 ...date_manual_address_entry_selected_prexisting_logs.rake | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/lib/tasks/update_manual_address_entry_selected_prexisting_logs.rake b/lib/tasks/update_manual_address_entry_selected_prexisting_logs.rake
index 26898b39c..5b911c80d 100644
--- a/lib/tasks/update_manual_address_entry_selected_prexisting_logs.rake
+++ b/lib/tasks/update_manual_address_entry_selected_prexisting_logs.rake
@@ -6,10 +6,10 @@ namespace :bulk_update do
     lettings_logs = LettingsLog.filter_by_year(2024)
                                .where(status: %w[in_progress completed])
                                .where(needstype: 1, manual_address_entry_selected: false, uprn: nil)
+                               .where("(address_line1 IS NOT NULL AND address_line1 != '') OR (address_line2 IS NOT NULL AND address_line2 != '') OR (town_or_city IS NOT NULL AND town_or_city != '') OR (county IS NOT NULL AND county != '') OR (postcode_full IS NOT NULL AND postcode_full != '')")
 
-    lettings_logs.find_each do |log|
-      next unless log.address_line1 || log.address_line2 || log.county || log.town_or_city || log.postcode_full
 
+    lettings_logs.find_each do |log|
       status_pre_change = log.status
       log.manual_address_entry_selected = true
       if log.save
@@ -28,10 +28,9 @@ namespace :bulk_update do
     sales_logs = SalesLog.filter_by_year(2024)
                          .where(status: %w[in_progress completed])
                          .where(manual_address_entry_selected: false, uprn: nil)
+                         .where("(address_line1 IS NOT NULL AND address_line1 != '') OR (address_line2 IS NOT NULL AND address_line2 != '') OR (town_or_city IS NOT NULL AND town_or_city != '') OR (county IS NOT NULL AND county != '') OR (postcode_full IS NOT NULL AND postcode_full != '')")
 
     sales_logs.find_each do |log|
-      next unless log.address_line1 || log.address_line2 || log.county || log.town_or_city || log.postcode_full
-
       status_pre_change = log.status
       log.manual_address_entry_selected = true
       if log.save