Browse Source

CLDC-4215: Don't run validate_discounted_ownership_value if mortgageused is 3 (#3239)

* CLDC-4215: Don't run validate_discounted_ownership_value if mortgageused is 3

I don't think this should have ever been turned on. if we don't know the mortgage we can't assume info in this check

* CLDC-4215: Add a verifying test
pull/3264/head
Samuel Young 1 week ago committed by GitHub
parent
commit
319af27e75
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
  1. 2
      app/models/validations/sales/sale_information_validations.rb
  2. 12
      spec/models/validations/sales/sale_information_validations_spec.rb

2
app/models/validations/sales/sale_information_validations.rb

@ -77,7 +77,7 @@ module Validations::Sales::SaleInformationValidations
def validate_discounted_ownership_value(record)
return unless record.saledate && record.form.start_year_2024_or_later?
return unless record.value && record.deposit && record.ownershipsch
return unless record.mortgage || record.mortgageused == 2 || record.mortgageused == 3
return unless record.mortgage || record.mortgageused == 2
return unless record.discount || record.grant || record.type == 29
tolerance = record.value_with_discount_tolerance

12
spec/models/validations/sales/sale_information_validations_spec.rb

@ -703,6 +703,18 @@ RSpec.describe Validations::Sales::SaleInformationValidations do
end
end
end
context "when mortgageused is don't know" do
let(:record) { FactoryBot.build(:sales_log, :saledate_today, mortgageused: 3, deposit: 10_000, value: 100_000, discount: 10, ownershipsch: 2, type: 9) }
it "does not add an error" do
sale_information_validator.validate_discounted_ownership_value(record)
expect(record.errors["mortgage"]).to be_empty
expect(record.errors["value"]).to be_empty
expect(record.errors["deposit"]).to be_empty
expect(record.errors["discount"]).to be_empty
end
end
end
describe "#validate_outright_sale_value_matches_mortgage_plus_deposit" do

Loading…
Cancel
Save