From 340aa6cdb2e290ab8b822033329519aec52b9cc9 Mon Sep 17 00:00:00 2001 From: Kat Date: Tue, 19 Jul 2022 15:42:15 +0100 Subject: [PATCH] add guard clause for answer_selected? --- app/models/form/question.rb | 1 + spec/models/form/setup/questions/property_reference_spec.rb | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/app/models/form/question.rb b/app/models/form/question.rb index de05f46a4..43147fcfb 100644 --- a/app/models/form/question.rb +++ b/app/models/form/question.rb @@ -229,6 +229,7 @@ class Form::Question end def answer_selected?(case_log, answer) + return false unless type == "select" case_log[id].to_s == answer.id.to_s end diff --git a/spec/models/form/setup/questions/property_reference_spec.rb b/spec/models/form/setup/questions/property_reference_spec.rb index 21144ff52..7242bf984 100644 --- a/spec/models/form/setup/questions/property_reference_spec.rb +++ b/spec/models/form/setup/questions/property_reference_spec.rb @@ -6,6 +6,7 @@ RSpec.describe Form::Setup::Questions::PropertyReference, type: :model do let(:question_id) { nil } let(:question_definition) { nil } let(:page) { instance_double(Form::Page) } + let(:case_log) { FactoryBot.create(:case_log) } it "has correct page" do expect(question.page).to eq(page) @@ -38,4 +39,8 @@ RSpec.describe Form::Setup::Questions::PropertyReference, type: :model do it "is not marked as derived" do expect(question.derived?).to be false end + + it "returns false for answer_selected" do + expect(question.answer_selected?(case_log, {})).to be false + end end