From 3805a177c9871f69c3671b5e134043b0e7fd7a20 Mon Sep 17 00:00:00 2001 From: Kat Date: Mon, 4 Oct 2021 15:42:59 +0100 Subject: [PATCH] remove return status, shuffle if statement --- app/helpers/tasklist_helper.rb | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/app/helpers/tasklist_helper.rb b/app/helpers/tasklist_helper.rb index 3a88d6667..e2363a9c3 100644 --- a/app/helpers/tasklist_helper.rb +++ b/app/helpers/tasklist_helper.rb @@ -33,15 +33,13 @@ module TasklistHelper def get_next_incomplete_section(form, case_log) subsections = form.all_subsections.keys - return subsections.find { |subsection| is_incomplete?(subsection, case_log, form.questions_for_subsection(subsection).keys) } + subsections.find { |subsection| is_incomplete?(subsection, case_log, form.questions_for_subsection(subsection).keys) } end def get_sections_count(form, case_log, status = :all) subsections = form.all_subsections.keys - if status == :all - return subsections.count - end - return subsections.count { |subsection| get_subsection_status(subsection, case_log, form.questions_for_subsection(subsection).keys) == status } + return subsections.count if status == :all + subsections.count { |subsection| get_subsection_status(subsection, case_log, form.questions_for_subsection(subsection).keys) == status } end private @@ -51,6 +49,6 @@ module TasklistHelper def is_incomplete?(subsection, case_log, questions) status = get_subsection_status(subsection, case_log, questions) - return status == :not_started || status == :in_progress + status == :not_started || status == :in_progress end end