From 3bfcaab417677268070138ab322f12b4fb05270d Mon Sep 17 00:00:00 2001 From: Kat Date: Thu, 14 Oct 2021 15:26:34 +0100 Subject: [PATCH] refactor get_all_forms --- app/models/form_handler.rb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/models/form_handler.rb b/app/models/form_handler.rb index 986ebd4da..c6cd755d4 100644 --- a/app/models/form_handler.rb +++ b/app/models/form_handler.rb @@ -18,11 +18,8 @@ class FormHandler forms = {} directories = ["config/forms", "spec/fixtures/forms"] directories.each do |directory| - Dir.foreach(directory) do |filename| - next if (filename == ".") || (filename == "..") - - form_name = filename.sub(".json", "") - form_path = "#{directory}/#{filename}" + Dir.glob("#{directory}/*.json").each do |form_path| + form_name = form_path.sub(".json", "").split("/")[-1] forms[form_name] = Form.new(form_path) end end