From 3c07107c8782150b0b16085ff90dba6c9ddc56d3 Mon Sep 17 00:00:00 2001 From: Phil Lee Date: Mon, 21 Nov 2022 12:02:19 +0000 Subject: [PATCH] wait for binding when deploying review apps (#1013) - there seems to be a race condition without this and there is a chance not command will fail as it needs to wait for any existing operations to complete first --- .github/workflows/review_pipeline.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/review_pipeline.yml b/.github/workflows/review_pipeline.yml index 8bf7ddb57..1ccd2717c 100644 --- a/.github/workflows/review_pipeline.yml +++ b/.github/workflows/review_pipeline.yml @@ -126,21 +126,21 @@ jobs: APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }} SERVICE_NAME: dluhc-core-review-${{ github.event.pull_request.number }}-postgres run: | - cf bind-service $APP_NAME $SERVICE_NAME + cf bind-service $APP_NAME $SERVICE_NAME --wait - name: Bind redis service env: APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }} SERVICE_NAME: dluhc-core-review-${{ github.event.pull_request.number }}-redis run: | - cf bind-service $APP_NAME $SERVICE_NAME + cf bind-service $APP_NAME $SERVICE_NAME --wait - name: Bind logit drain service env: APP_NAME: dluhc-core-review-${{ github.event.pull_request.number }} SERVICE_NAME: logit-ssl-drain run: | - cf bind-service $APP_NAME $SERVICE_NAME + cf bind-service $APP_NAME $SERVICE_NAME --wait - name: Start review app env: