From 3ca16165ba05cb225165967a964304d1197f4625 Mon Sep 17 00:00:00 2001 From: Kat Date: Fri, 11 Mar 2022 12:15:28 +0000 Subject: [PATCH] extract method --- app/models/case_log.rb | 5 +++++ app/models/validations/household_validations.rb | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/app/models/case_log.rb b/app/models/case_log.rb index 8aa4c3be1..79fb9ffb6 100644 --- a/app/models/case_log.rb +++ b/app/models/case_log.rb @@ -226,6 +226,11 @@ class CaseLog < ApplicationRecord def previous_tenancy_was_refuge? prevten == 21 end + + def is_reason_permanently_decanted? + reason == 1 + end + private PIO = Postcodes::IO.new diff --git a/app/models/validations/household_validations.rb b/app/models/validations/household_validations.rb index 024e4849d..67688794f 100644 --- a/app/models/validations/household_validations.rb +++ b/app/models/validations/household_validations.rb @@ -20,7 +20,7 @@ module Validations::HouseholdValidations end validate_other_field(record, 31, :reason, :other_reason_for_leaving_last_settled_home) - if record.reason == 1 && record.referral.present? && !record.is_internal_transfer? + if record.is_reason_permanently_decanted? && record.referral.present? && !record.is_internal_transfer? record.errors.add :referral, I18n.t("validations.household.referral.reason_permanently_decanted") record.errors.add :reason, I18n.t("validations.household.reason.not_internal_transfer") end