From 3fcf874d2c9f5c5972613908b2c5a867d2ac7e75 Mon Sep 17 00:00:00 2001 From: baarkerlounger Date: Tue, 31 May 2022 09:59:29 +0100 Subject: [PATCH] Make sure we can log old id --- .../imports/case_logs_field_import_service.rb | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/app/services/imports/case_logs_field_import_service.rb b/app/services/imports/case_logs_field_import_service.rb index 0e14ebda4..e1c88454c 100644 --- a/app/services/imports/case_logs_field_import_service.rb +++ b/app/services/imports/case_logs_field_import_service.rb @@ -14,7 +14,8 @@ module Imports private def update_major_repairs(xml_doc) - record = log(xml_doc) + old_id = field_value(xml_doc, "meta", "document-id") + record = CaseLog.find_by(old_id:) if record.present? previous_status = field_value(xml_doc, "meta", "status") @@ -36,7 +37,8 @@ module Imports end def update_tenant_code(xml_doc) - record = log(xml_doc) + old_id = field_value(xml_doc, "meta", "document-id") + record = CaseLog.find_by(old_id:) if record.present? tenant_code = string_or_nil(xml_doc, "_2bTenCode") @@ -50,11 +52,6 @@ module Imports end end - def log(xml_doc) - old_id = field_value(xml_doc, "meta", "document-id") - CaseLog.find_by(old_id:) - end - def compose_date(xml_doc, day_str, month_str, year_str) day = Integer(field_value(xml_doc, "xmlns", day_str), exception: false) month = Integer(field_value(xml_doc, "xmlns", month_str), exception: false)