From 411f42251d412ed7920052a9a18f84c29fa987f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Meny?= Date: Fri, 27 May 2022 15:12:05 +0100 Subject: [PATCH] Refactor call to update --- .../imports/case_logs_field_import_service.rb | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/app/services/imports/case_logs_field_import_service.rb b/app/services/imports/case_logs_field_import_service.rb index 7489cfef6..d7be932bd 100644 --- a/app/services/imports/case_logs_field_import_service.rb +++ b/app/services/imports/case_logs_field_import_service.rb @@ -12,20 +12,15 @@ module Imports private def update_tenant_code(xml_doc) - update_string_value(xml_doc, "_2bTenCode", "tenant_code") - end - - def update_string_value(xml_doc, src_field, dest_field) old_id = field_value(xml_doc, "meta", "document-id") record = CaseLog.find_by(old_id:) if record.present? - tenant_code = string_or_nil(xml_doc, src_field) - current_value = record.read_attribute(dest_field) - if tenant_code.present? && current_value.blank? - record.update_column(dest_field, tenant_code) + tenant_code = string_or_nil(xml_doc, "_2bTenCode") + if tenant_code.present? && record.tenant_code.blank? + record.update!(tenant_code:) else - @logger.info("Case Log #{record.id} has a value for #{dest_field}, skipping update") + @logger.info("Case Log #{record.id} has a value for tenant_code, skipping update") end else @logger.warn("Could not find record matching legacy ID #{old_id}")