feat: ensure period is routed to for needstype 1 regardless of household_charge (#1647)

app/models/form/lettings/pages/rent_period.rb

@@ -2,7 +2,7 @@ class Form::Lettings::Pages::RentPeriod < ::Form::Page
   def initialize(id, hsh, subsection)
     super
     @id = "rent_period"
-    @depends_on = [{ "household_charge" => 0 }, { "household_charge" => nil }]
+    @depends_on = [{ "needstype" => 1 }, { "needstype" => 2, "household_charge" => 0 }, { "needstype" => 2, "household_charge" => nil }]
   end
 
   def questions

config/forms/2022_2023.json

@@ -7481,9 +7481,14 @@
               },
               "depends_on": [
                 {
+                  "needstype": 1
+                },
+                {
+                  "needstype": 2,
                   "household_charge": 0
                 },
                 {
+                  "needstype": 2,
                   "household_charge": null
                 }
               ]