From 436f8d59d03c1e673377be2e73206208a56a6fef Mon Sep 17 00:00:00 2001
From: Jack <113976590+bibblobcode@users.noreply.github.com>
Date: Tue, 18 Jul 2023 15:20:44 +0100
Subject: [PATCH] CLDC-2500 Add "log" in front of ID (#1784)

* Add "log" in front of ID

* Test fix
---
 app/components/lettings_log_summary_component.html.erb | 2 +-
 app/components/sales_log_summary_component.html.erb    | 2 +-
 spec/requests/lettings_logs_controller_spec.rb         | 4 ++--
 spec/requests/sales_logs_controller_spec.rb            | 5 +++--
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/components/lettings_log_summary_component.html.erb b/app/components/lettings_log_summary_component.html.erb
index 8c348ed68..b0bc9fed8 100644
--- a/app/components/lettings_log_summary_component.html.erb
+++ b/app/components/lettings_log_summary_component.html.erb
@@ -4,7 +4,7 @@
       <header class="app-log-summary__header">
         <h2 class="app-log-summary__title">
           <%= govuk_link_to lettings_log_path(log) do %>
-            <span class="govuk-visually-hidden">Log </span><%= log.id %>
+            Log <%= log.id %>
           <% end %>
         </h2>
         <% if log.tenancycode? or log.propcode? %>
diff --git a/app/components/sales_log_summary_component.html.erb b/app/components/sales_log_summary_component.html.erb
index dd58f6a61..6b3be98cb 100644
--- a/app/components/sales_log_summary_component.html.erb
+++ b/app/components/sales_log_summary_component.html.erb
@@ -4,7 +4,7 @@
       <header class="app-log-summary__header">
         <h2 class="app-log-summary__title">
           <%= govuk_link_to sales_log_path(log) do %>
-            <span class="govuk-visually-hidden">Log </span><%= log.id %>
+            Log <%= log.id %>
           <% end %>
         </h2>
           <dl class="app-metadata app-metadata--inline">
diff --git a/spec/requests/lettings_logs_controller_spec.rb b/spec/requests/lettings_logs_controller_spec.rb
index 3c2459ea4..ae8770c7a 100644
--- a/spec/requests/lettings_logs_controller_spec.rb
+++ b/spec/requests/lettings_logs_controller_spec.rb
@@ -731,8 +731,8 @@ RSpec.describe LettingsLogsController, type: :request do
           end
 
           it "only shows lettings logs for your organisation" do
-            expected_case_row_log = "<span class=\"govuk-visually-hidden\">Log </span>#{lettings_log.id}"
-            unauthorized_case_row_log = "<span class=\"govuk-visually-hidden\">Log </span>#{unauthorized_lettings_log.id}"
+            expected_case_row_log = "Log #{lettings_log.id}"
+            unauthorized_case_row_log = "Log #{unauthorized_lettings_log.id}"
             expect(CGI.unescape_html(response.body)).to include(expected_case_row_log)
             expect(CGI.unescape_html(response.body)).not_to include(unauthorized_case_row_log)
           end
diff --git a/spec/requests/sales_logs_controller_spec.rb b/spec/requests/sales_logs_controller_spec.rb
index 34e4de534..0d5c0e029 100644
--- a/spec/requests/sales_logs_controller_spec.rb
+++ b/spec/requests/sales_logs_controller_spec.rb
@@ -552,8 +552,9 @@ RSpec.describe SalesLogsController, type: :request do
           end
 
           it "only shows sales logs for your organisation" do
-            expected_case_row_log = "<span class=\"govuk-visually-hidden\">Log </span>#{sales_log.id}"
-            unauthorized_case_row_log = "<span class=\"govuk-visually-hidden\">Log </span>#{unauthorized_sales_log.id}"
+            expected_case_row_log = "Log #{sales_log.id}"
+            unauthorized_case_row_log = "Log #{unauthorized_sales_log.id}"
+
             expect(CGI.unescape_html(response.body)).to include(expected_case_row_log)
             expect(CGI.unescape_html(response.body)).not_to include(unauthorized_case_row_log)
           end