From 482f137cda42a18e0fdb037821bfd44646a9ed75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?St=C3=A9phane=20Meny?= Date: Tue, 19 Apr 2022 12:16:30 +0100 Subject: [PATCH] Rubocop offenses --- app/models/case_log.rb | 4 ++-- spec/models/validations/household_validations_spec.rb | 2 +- spec/models/validations/tenancy_validations_spec.rb | 2 ++ spec/services/imports/case_logs_import_service_spec.rb | 1 - 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/app/models/case_log.rb b/app/models/case_log.rb index 3f1afb39c..8bb851f9e 100644 --- a/app/models/case_log.rb +++ b/app/models/case_log.rb @@ -162,12 +162,12 @@ class CaseLog < ApplicationRecord def is_supported_housing? # 0: Supported Housing - !!(needstype&.zero?) + !!needstype&.zero? end def has_hbrentshortfall? # 0: Yes - !!(hbrentshortfall&.zero?) + !!hbrentshortfall&.zero? end def postcode_known? diff --git a/spec/models/validations/household_validations_spec.rb b/spec/models/validations/household_validations_spec.rb index 80ec840ce..4b5cbd557 100644 --- a/spec/models/validations/household_validations_spec.rb +++ b/spec/models/validations/household_validations_spec.rb @@ -238,7 +238,7 @@ RSpec.describe Validations::HouseholdValidations do describe "armed forces validations" do context "when the tenant or partner was and is not a member of the armed forces" do it "validates that injured in the armed forces is not yes" do - record.armedforces = 3 + record.armedforces = 2 record.reservist = 0 household_validator.validate_armed_forces(record) expect(record.errors["reservist"]) diff --git a/spec/models/validations/tenancy_validations_spec.rb b/spec/models/validations/tenancy_validations_spec.rb index 4baaf6445..711b1481a 100644 --- a/spec/models/validations/tenancy_validations_spec.rb +++ b/spec/models/validations/tenancy_validations_spec.rb @@ -22,6 +22,7 @@ RSpec.describe Validations::TenancyValidations do context "when type of tenancy is assured shorthold" do let(:expected_error) { I18n.t("validations.tenancy.length.shorthold") } + before { record.tenancy = 4 } context "when tenancy length is greater than 1" do @@ -63,6 +64,7 @@ RSpec.describe Validations::TenancyValidations do context "when type of tenancy is secure" do let(:expected_error) { I18n.t("validations.tenancy.length.secure") } + before { record.tenancy = 1 } context "when tenancy length is greater than 1" do diff --git a/spec/services/imports/case_logs_import_service_spec.rb b/spec/services/imports/case_logs_import_service_spec.rb index f1c1dfe34..7af288654 100644 --- a/spec/services/imports/case_logs_import_service_spec.rb +++ b/spec/services/imports/case_logs_import_service_spec.rb @@ -24,7 +24,6 @@ RSpec.describe Imports::CaseLogsImportService do it "successfully create a case log with the expected data" do case_log_service.create_logs(remote_folder) - end end end