Browse Source

CLDC-4191: Add new referral fields to 2026 exports

remove old referral fields from 2026 exports

ensure new referral fields don't show in pre 2026 exports
CLDC-4191-referral-question-csv-xml
Samuel Young 2 weeks ago
parent
commit
4a894d8471
  1. 13
      app/services/exports/lettings_log_export_constants.rb
  2. 3
      app/services/exports/lettings_log_export_service.rb
  3. 4
      spec/fixtures/exports/general_needs_log_26_27.xml
  4. 3
      spec/services/exports/lettings_log_export_service_spec.rb

13
app/services/exports/lettings_log_export_constants.rb

@ -82,6 +82,9 @@ module Exports::LettingsLogExportConstants
"reasonother",
"reasonpref",
"referral",
"referral_register",
"referral_noms",
"referral_org",
"refused",
"reghome",
"renttype",
@ -201,6 +204,14 @@ module Exports::LettingsLogExportConstants
]
PRE_2026_EXPORT_FIELDS = Set[
"builtype"
"builtype",
"referral",
"referral_type",
]
POST_2026_EXPORT_FIELDS = Set[
"referral_register",
"referral_noms",
"referral_org",
]
end

3
app/services/exports/lettings_log_export_service.rb

@ -171,7 +171,8 @@ module Exports
(lettings_log.form.start_year_2024_or_later? && PRE_2024_EXPORT_FIELDS.include?(field_name)) ||
(!lettings_log.form.start_year_2024_or_later? && POST_2024_EXPORT_FIELDS.include?(field_name)) ||
(lettings_log.form.start_year_2025_or_later? && PRE_2025_EXPORT_FIELDS.include?(field_name)) ||
(lettings_log.form.start_year_2026_or_later? && PRE_2026_EXPORT_FIELDS.include?(field_name))
(lettings_log.form.start_year_2026_or_later? && PRE_2026_EXPORT_FIELDS.include?(field_name)) ||
(!lettings_log.form.start_year_2026_or_later? && POST_2026_EXPORT_FIELDS.include?(field_name))
end
def build_export_xml(lettings_logs)

4
spec/fixtures/exports/general_needs_log_26_27.xml vendored

@ -99,7 +99,9 @@
<totelder>0</totelder>
<totadult>2</totadult>
<nocharge/>
<referral>2</referral>
<referral_register>1</referral_register>
<referral_noms/>
<referral_org/>
<brent>200.0</brent>
<scharge>50.0</scharge>
<pscharge>40.0</pscharge>

3
spec/services/exports/lettings_log_export_service_spec.rb

@ -502,8 +502,7 @@ RSpec.describe Exports::LettingsLogExportService do
let(:expected_data_filename) { "core_2026_2027_apr_mar_f0001_inc0001_pt001.xml" }
let(:xml_export_file) { File.open("spec/fixtures/exports/general_needs_log_26_27.xml", "r:UTF-8") }
# TODO: CLDC-4191 Reinstate this test when we update log export
xit "generates an XML export file with the expected content within the ZIP file" do
it "generates an XML export file with the expected content within the ZIP file" do
expected_content = replace_entity_ids(lettings_log, xml_export_file.read)
expect(storage_service).to receive(:write_file).with(expected_zip_filename, any_args) do |_, content|
entry = Zip::File.open_buffer(content).find_entry(expected_data_filename)

Loading…
Cancel
Save