From 4f4e2e0c41cedfcd9acc4240b0ac42a4d967b4e9 Mon Sep 17 00:00:00 2001 From: Nat Dean-Lewis Date: Thu, 23 Apr 2026 10:05:33 +0100 Subject: [PATCH] CLDC-4071: show change link even when extension number not provided --- app/helpers/user_helper.rb | 8 +------- app/views/users/show.html.erb | 2 +- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/app/helpers/user_helper.rb b/app/helpers/user_helper.rb index b1ecdc7ad..f6168e108 100644 --- a/app/helpers/user_helper.rb +++ b/app/helpers/user_helper.rb @@ -89,19 +89,13 @@ module UserHelper end when "phone" edit_link("Enter telephone number", user, current_user) - when "phone_extension" - if user == current_user || current_user.data_coordinator? || current_user.support? - edit_link("Enter extension number", user, current_user) - else - no_answer_provided_text - end else no_answer_provided_text end end def user_action_text(user, attribute) - return "Change" if %w[role phone phone_extension].include?(attribute) && user.send(attribute).present? + return "Change" if (%w[role phone].include?(attribute) && user.send(attribute).present?) || attribute == "phone_extension" "" end diff --git a/app/views/users/show.html.erb b/app/views/users/show.html.erb index 06fda18a3..ff8a3647e 100644 --- a/app/views/users/show.html.erb +++ b/app/views/users/show.html.erb @@ -68,7 +68,7 @@ <%= summary_list.with_row do |row| row.with_key { "Extension number" } row.with_value { user_details_html(@user, current_user, "phone_extension") } - if UserPolicy.new(current_user, @user).edit_extension_numbers? && @user.phone_extension.present? + if UserPolicy.new(current_user, @user).edit_extension_numbers? row.with_action( text: user_action_text(@user, "phone_extension"), visually_hidden_text: "extension number",