From 5208b395c81d8a4065b8260f4d6c0b257ba4ddca Mon Sep 17 00:00:00 2001 From: Kat <54268893+kosiakkatrina@users.noreply.github.com> Date: Wed, 5 Mar 2025 09:01:20 +0000 Subject: [PATCH] Refactor --- app/models/log.rb | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/app/models/log.rb b/app/models/log.rb index 1e2154fd4..4c4116a23 100644 --- a/app/models/log.rb +++ b/app/models/log.rb @@ -91,12 +91,7 @@ class Log < ApplicationRecord service = AddressClient.new(address_string) service.call if service.result.blank? || service.error.present? - self.postcode_full = postcode_full_as_entered - self.address_line1 = address_line1_as_entered - self.address_line2 = address_line2_as_entered - self.county = county_as_entered - self.town_or_city = town_or_city_as_entered - self.manual_address_entry_selected = true + select_manual_address_entry! return nil end @@ -105,12 +100,7 @@ class Log < ApplicationRecord if presenter.match >= os_match_threshold_for_bulk_upload self.uprn_selection = presenter.uprn else - self.postcode_full = postcode_full_as_entered - self.address_line1 = address_line1_as_entered - self.address_line2 = address_line2_as_entered - self.county = county_as_entered - self.town_or_city = town_or_city_as_entered - self.manual_address_entry_selected = true + select_manual_address_entry! return nil end end @@ -418,4 +408,13 @@ private self[is_inferred_key] = false self[postcode_key] = nil end + + def select_manual_address_entry! + self.postcode_full = postcode_full_as_entered + self.address_line1 = address_line1_as_entered + self.address_line2 = address_line2_as_entered + self.county = county_as_entered + self.town_or_city = town_or_city_as_entered + self.manual_address_entry_selected = true + end end