diff --git a/app/models/derived_variables/lettings_log_variables.rb b/app/models/derived_variables/lettings_log_variables.rb index ba18a9991..ba3aaaecc 100644 --- a/app/models/derived_variables/lettings_log_variables.rb +++ b/app/models/derived_variables/lettings_log_variables.rb @@ -116,8 +116,8 @@ module DerivedVariables::LettingsLogVariables self.uprn_known = 0 self.uprn_selection = nil else - self.uprn = address_search self.uprn_confirmed = 1 if uprn.present? + self.uprn_known = 1 if uprn.present? reset_address_fields! if uprn.blank? end diff --git a/app/models/derived_variables/sales_log_variables.rb b/app/models/derived_variables/sales_log_variables.rb index a23b91c46..202aea893 100644 --- a/app/models/derived_variables/sales_log_variables.rb +++ b/app/models/derived_variables/sales_log_variables.rb @@ -68,8 +68,8 @@ module DerivedVariables::SalesLogVariables self.uprn_known = 0 self.uprn_selection = nil else - self.uprn = address_search - self.uprn_confirmed = 1 if uprn + self.uprn_confirmed = 1 if uprn.present? + self.uprn_known = 1 if uprn.present? reset_address_fields! if uprn.blank? end diff --git a/app/models/form/lettings/pages/address_search.rb b/app/models/form/lettings/pages/address_search.rb index 9caf89a99..9a87b725b 100644 --- a/app/models/form/lettings/pages/address_search.rb +++ b/app/models/form/lettings/pages/address_search.rb @@ -2,6 +2,7 @@ class Form::Lettings::Pages::AddressSearch < ::Form::Page def initialize(id, hsh, subsection) super @id = "address_search" + @copy_key = "sales.property_information.address_search" @depends_on = [{ "is_supported_housing?" => false, "manual_address_entry_selected" => false }] @question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max] end diff --git a/app/models/form/lettings/questions/address_search.rb b/app/models/form/lettings/questions/address_search.rb index bd2e769b9..6e4ea0629 100644 --- a/app/models/form/lettings/questions/address_search.rb +++ b/app/models/form/lettings/questions/address_search.rb @@ -1,8 +1,9 @@ class Form::Lettings::Questions::AddressSearch < ::Form::Question def initialize(id, hsh, page) super - @id = "address_search" + @id = "uprn" @type = "address_search" + @copy_key = "lettings.property_information.address_search" @plain_label = true @bottom_guidance_partial = "address_search" @question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max] diff --git a/app/models/form/lettings/questions/uprn_confirmation.rb b/app/models/form/lettings/questions/uprn_confirmation.rb index 88e45c874..2f03cb357 100644 --- a/app/models/form/lettings/questions/uprn_confirmation.rb +++ b/app/models/form/lettings/questions/uprn_confirmation.rb @@ -37,6 +37,6 @@ class Form::Lettings::Questions::UprnConfirmation < ::Form::Question end def hidden_in_check_answers?(log, _current_user = nil) - log.uprn_known != 1 || log.uprn_confirmed.present? || log.address_search.present? + log.uprn_known != 1 || log.uprn_confirmed.present? end end diff --git a/app/models/form/lettings/questions/uprn_known.rb b/app/models/form/lettings/questions/uprn_known.rb index 29d415134..8d2df4c06 100644 --- a/app/models/form/lettings/questions/uprn_known.rb +++ b/app/models/form/lettings/questions/uprn_known.rb @@ -5,7 +5,7 @@ class Form::Lettings::Questions::UprnKnown < ::Form::Question @copy_key = "lettings.property_information.uprn.uprn_known" @type = "radio" @answer_options = ANSWER_OPTIONS - @conditional_for = { "uprn" => [1] } + # @conditional_for = { "uprn" => [1] } #TODO: DELETE @inferred_check_answers_value = [ { "condition" => { "uprn_known" => 0 }, diff --git a/app/models/form/sales/pages/address_search.rb b/app/models/form/sales/pages/address_search.rb index 1745e4f63..5dedd9ff6 100644 --- a/app/models/form/sales/pages/address_search.rb +++ b/app/models/form/sales/pages/address_search.rb @@ -2,6 +2,7 @@ class Form::Sales::Pages::AddressSearch < ::Form::Page def initialize(id, hsh, subsection) super @id = "address_search" + @copy_key = "sales.property_information.address_search" @depends_on = [{ "manual_address_entry_selected" => false }] @question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max] end diff --git a/app/models/form/sales/questions/address_search.rb b/app/models/form/sales/questions/address_search.rb index b1995039b..2b526b1c7 100644 --- a/app/models/form/sales/questions/address_search.rb +++ b/app/models/form/sales/questions/address_search.rb @@ -1,12 +1,14 @@ class Form::Sales::Questions::AddressSearch < ::Form::Question def initialize(id, hsh, page) super - @id = "address_search" + @id = "uprn" @type = "address_search" + @copy_key = "sales.property_information.address_search" @plain_label = true @bottom_guidance_partial = "address_search" @question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max] @hide_question_number_on_page = true + @conditional_on = nil end def answer_options(log = nil, _user = nil) diff --git a/app/models/form/sales/questions/uprn_confirmation.rb b/app/models/form/sales/questions/uprn_confirmation.rb index a8e8c974b..fed35f665 100644 --- a/app/models/form/sales/questions/uprn_confirmation.rb +++ b/app/models/form/sales/questions/uprn_confirmation.rb @@ -35,6 +35,6 @@ class Form::Sales::Questions::UprnConfirmation < ::Form::Question end def hidden_in_check_answers?(log, _current_user = nil) - log.uprn_known != 1 || log.uprn_confirmed.present? || log.address_search.present? + log.uprn_known != 1 || log.uprn_confirmed.present? end end diff --git a/app/models/form/sales/questions/uprn_known.rb b/app/models/form/sales/questions/uprn_known.rb index e35642bee..eb68d967e 100644 --- a/app/models/form/sales/questions/uprn_known.rb +++ b/app/models/form/sales/questions/uprn_known.rb @@ -5,7 +5,7 @@ class Form::Sales::Questions::UprnKnown < ::Form::Question @copy_key = "sales.property_information.uprn.uprn_known" @type = "radio" @answer_options = ANSWER_OPTIONS - @conditional_for = { "uprn" => [1] } + # @conditional_for = { "uprn" => [1] } #TODO: DELETE @inferred_check_answers_value = [ { "condition" => { "uprn_known" => 0 }, diff --git a/app/models/lettings_log.rb b/app/models/lettings_log.rb index 2dc8137bd..920aed628 100644 --- a/app/models/lettings_log.rb +++ b/app/models/lettings_log.rb @@ -145,7 +145,7 @@ class LettingsLog < Log scope :filter_by_managing_organisation_text_search, ->(param, _user) { where(managing_organisation: Organisation.search_by(param)) } AUTOGENERATED_FIELDS = %w[id status created_at updated_at discarded_at].freeze - OPTIONAL_FIELDS = %w[tenancycode propcode chcharge address_search].freeze + OPTIONAL_FIELDS = %w[tenancycode propcode chcharge].freeze RENT_TYPE_MAPPING_LABELS = { 1 => "Social Rent", 2 => "Affordable Rent", 3 => "Intermediate Rent", 4 => "Specified accommodation" }.freeze HAS_BENEFITS_OPTIONS = [1, 6, 8, 7].freeze NUM_OF_WEEKS_FROM_PERIOD = { 2 => 26, 3 => 13, 4 => 12, 5 => 50, 6 => 49, 7 => 48, 8 => 47, 9 => 46, 1 => 52, 10 => 53 }.freeze diff --git a/app/models/log.rb b/app/models/log.rb index d7868f8f6..d70d23751 100644 --- a/app/models/log.rb +++ b/app/models/log.rb @@ -126,8 +126,8 @@ class Log < ApplicationRecord end def address_options - if address_search.present? - service = UprnClient.new(address_search) + if uprn.present? + service = UprnClient.new(uprn) service.call if service.result.blank? || service.error.present? @address_options = [] diff --git a/app/services/csv/lettings_log_csv_service.rb b/app/services/csv/lettings_log_csv_service.rb index 2171bac55..3c4324d14 100644 --- a/app/services/csv/lettings_log_csv_service.rb +++ b/app/services/csv/lettings_log_csv_service.rb @@ -258,7 +258,7 @@ module Csv def lettings_log_attributes ordered_questions = FormHandler.instance.ordered_questions_for_year(@year, "lettings") soft_validations_attributes = soft_validations_attributes(ordered_questions) - ordered_questions.reject! { |q| q.id.match?(/age\d_known|nationality_all_group|rent_value_check|address_search/) } + ordered_questions.reject! { |q| q.id.match?(/age\d_known|nationality_all_group|rent_value_check/) } attributes = insert_derived_and_related_attributes(ordered_questions) order_address_fields_for_support(attributes) final_attributes = non_question_fields + attributes + SCHEME_AND_LOCATION_ATTRIBUTES diff --git a/app/services/csv/sales_log_csv_service.rb b/app/services/csv/sales_log_csv_service.rb index 49bbf8ccf..f74684868 100644 --- a/app/services/csv/sales_log_csv_service.rb +++ b/app/services/csv/sales_log_csv_service.rb @@ -162,7 +162,7 @@ module Csv def sales_log_attributes ordered_questions = FormHandler.instance.ordered_questions_for_year(@year, "sales") - ordered_questions.reject! { |q| q.id.match?(/((?