CLDC-3162 Update buyers living in property for 24/25 (#2194)

* feat: update header and test

* refactor: lint

* feat: update tests

app/models/form/sales/questions/buyer_live.rb

@@ -3,7 +3,7 @@ class Form::Sales::Questions::BuyerLive < ::Form::Question
     super
     @id = "buylivein"
     @check_answer_label = "Buyers living in property"
-    @header = "Will the buyers live in the property?"
+    @header = form.start_year_after_2024? ? "Will any buyers live in the property?" : "Will the buyers live in the property?"
     @type = "radio"
     @answer_options = ANSWER_OPTIONS
     @question_number = 8

spec/models/form/sales/pages/buyer_live_spec.rb

@@ -6,6 +6,12 @@ RSpec.describe Form::Sales::Pages::BuyerLive, type: :model do
   let(:page_id) { nil }
   let(:page_definition) { nil }
   let(:subsection) { instance_double(Form::Subsection) }
+  let(:form) { instance_double(Form) }
+
+  before do
+    allow(form).to receive(:start_year_after_2024?).and_return(false)
+    allow(subsection).to receive(:form).and_return(form)
+  end
 
   it "has correct subsection" do
     expect(page.subsection).to eq(subsection)

spec/models/form/sales/questions/buyer_live_spec.rb

@@ -6,6 +6,14 @@ RSpec.describe Form::Sales::Questions::BuyerLive, type: :model do
   let(:question_id) { nil }
   let(:question_definition) { nil }
   let(:page) { instance_double(Form::Page) }
+  let(:subsection) { instance_double(Form::Subsection) }
+  let(:form) { instance_double(Form) }
+
+  before do
+    allow(form).to receive(:start_year_after_2024?).and_return(false)
+    allow(page).to receive(:subsection).and_return(subsection)
+    allow(subsection).to receive(:form).and_return(form)
+  end
 
   it "has correct page" do
     expect(question.page).to eq(page)
@@ -15,10 +23,6 @@ RSpec.describe Form::Sales::Questions::BuyerLive, type: :model do
     expect(question.id).to eq("buylivein")
   end
 
-  it "has the correct header" do
-    expect(question.header).to eq("Will the buyers live in the property?")
-  end
-
   it "has the correct check_answer_label" do
     expect(question.check_answer_label).to eq("Buyers living in property")
   end
@@ -37,4 +41,20 @@ RSpec.describe Form::Sales::Questions::BuyerLive, type: :model do
       "2" => { "value" => "No" },
     })
   end
+
+  context "with 2023/24 form" do
+    it "has the correct header" do
+      expect(question.header).to eq("Will the buyers live in the property?")
+    end
+  end
+
+  context "with 2024/25 form" do
+    before do
+      allow(form).to receive(:start_year_after_2024?).and_return(true)
+    end
+
+    it "has the correct header" do
+      expect(question.header).to eq("Will any buyers live in the property?")
+    end
+  end
 end