From 5e8ad6530eac624cda29c0ae61fbc10b99a9fd6a Mon Sep 17 00:00:00 2001
From: baarkerlounger <db@slothlife.xyz>
Date: Fri, 8 Oct 2021 11:46:36 +0100
Subject: [PATCH] Rename variables for clarity

---
 .../conditional_question_controller.js         | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/app/javascript/controllers/conditional_question_controller.js b/app/javascript/controllers/conditional_question_controller.js
index 29ef37884..c49ba490a 100644
--- a/app/javascript/controllers/conditional_question_controller.js
+++ b/app/javascript/controllers/conditional_question_controller.js
@@ -19,16 +19,16 @@ export default class extends Controller {
 
   displayConditionalRadio() {
     if(this.element.checked) {
-      let value = this.element.value
+      let selectedValue = this.element.value
       let conditional_for = JSON.parse(this.element.dataset.info)
 
-      Object.entries(conditional_for).forEach(([key, values]) => {
-        let div = document.getElementById(key + "_div")
-        if(values.includes(value)) {
+      Object.entries(conditional_for).forEach(([targetQuestion, conditions]) => {
+        let div = document.getElementById(targetQuestion + "_div")
+        if(conditions.includes(selectedValue)) {
           div.style.display = "block"
         } else {
           div.style.display = "none"
-          let buttons = document.getElementsByName(`case_log[${key}]`)
+          let buttons = document.getElementsByName(`case_log[${targetQuestion}]`)
           Object.entries(buttons).forEach(([idx, button]) => {
             button.checked = false;
           })
@@ -38,12 +38,12 @@ export default class extends Controller {
   }
 
   displayConditionalNumeric() {
-    let value = this.element.value
+    let enteredValue = this.element.value
     let conditional_for = JSON.parse(this.element.dataset.info)
 
-    Object.entries(conditional_for).forEach(([key, values]) => {
-      let div = document.getElementById(key + "_div")
-      if(eval((value + values))) {
+    Object.entries(conditional_for).forEach(([targetQuestion, condition]) => {
+      let div = document.getElementById(targetQuestion + "_div")
+      if(eval((enteredValue + condition))) {
         div.style.display = "block"
       } else {
         div.style.display = "none"