From 60a7f44e1c4a56905a3c484298f4164fe9152536 Mon Sep 17 00:00:00 2001 From: JG Date: Mon, 27 Jun 2022 11:54:03 +0100 Subject: [PATCH] rubo and lint --- app/views/schemes/check_answers.html.erb | 4 ++-- app/views/schemes/confirm_secondary.html.erb | 5 ++--- app/views/schemes/details.html.erb | 2 +- app/views/schemes/new.html.erb | 3 +-- app/views/schemes/primary_client_group.html.erb | 1 - app/views/schemes/secondary_client_group.html.erb | 2 +- spec/features/schemes_spec.rb | 1 - 7 files changed, 7 insertions(+), 11 deletions(-) diff --git a/app/views/schemes/check_answers.html.erb b/app/views/schemes/check_answers.html.erb index a612c5826..d286d2d52 100644 --- a/app/views/schemes/check_answers.html.erb +++ b/app/views/schemes/check_answers.html.erb @@ -10,7 +10,7 @@ <%= render partial: "organisations/headings", locals: { main: "Check your changes before updating this scheme", sub: @scheme.service_name } %> <%= govuk_tabs(title: "Check your answers before creating this scheme") do |component| %> - <% component.tab(label: 'Scheme') do %> + <% component.tab(label: "Scheme") do %> <%= govuk_summary_list do |summary_list| %> <% @scheme.check_details_attributes.each do |attr| %> <% next if current_user.data_coordinator? && attr[:name] == ("Managed by") %> @@ -19,7 +19,7 @@ <% row.value { details_html(attr) } %> <% row.action( text: "Change", - href: scheme_details_path(scheme_id: @scheme.id, check_answers: true) + href: scheme_details_path(scheme_id: @scheme.id, check_answers: true), ) %> <% end %> <% end %> diff --git a/app/views/schemes/confirm_secondary.html.erb b/app/views/schemes/confirm_secondary.html.erb index d27bfaac6..d1ed20d74 100644 --- a/app/views/schemes/confirm_secondary.html.erb +++ b/app/views/schemes/confirm_secondary.html.erb @@ -19,14 +19,13 @@ selection, :id, :name, - legend: nil - %> + legend: nil %> <%= f.hidden_field :page, value: "confirm-secondary" %> <% if request.query_parameters["check_answers"] == "true" %> <%= f.hidden_field :check_answers, value: "true" %> <% end %> - + <%= f.govuk_submit "Save and continue" %> diff --git a/app/views/schemes/details.html.erb b/app/views/schemes/details.html.erb index c19015caa..5594e6f77 100644 --- a/app/views/schemes/details.html.erb +++ b/app/views/schemes/details.html.erb @@ -70,4 +70,4 @@ <%= f.govuk_submit "Save and continue" %> - <% end %> \ No newline at end of file + <% end %> diff --git a/app/views/schemes/new.html.erb b/app/views/schemes/new.html.erb index 45ab011ab..f74ae4b44 100644 --- a/app/views/schemes/new.html.erb +++ b/app/views/schemes/new.html.erb @@ -3,7 +3,7 @@ <% content_for :before_content do %> <%= govuk_back_link( text: "Back", - href: 'javascript:history.go(-1);', + href: "javascript:history.go(-1);", ) %> <% end %> @@ -20,7 +20,6 @@ label: { text: "Scheme name", size: "m" }, hint: { text: "This is how you’ll refer to this supported housing scheme within your organisation. For example, the name could relate to the address or location. You’ll be able to see the client group when selecting it." } %> - <%= f.govuk_check_box :sensitive, "Yes", checked: @scheme.sensitive?, diff --git a/app/views/schemes/primary_client_group.html.erb b/app/views/schemes/primary_client_group.html.erb index 027e14bdc..e1faaadae 100644 --- a/app/views/schemes/primary_client_group.html.erb +++ b/app/views/schemes/primary_client_group.html.erb @@ -9,7 +9,6 @@ <%= render partial: "organisations/headings", locals: { main: "What client group is this scheme intended for?", sub: @scheme.service_name } %> - <%= form_for(@scheme, method: :patch) do |f| %>
diff --git a/app/views/schemes/secondary_client_group.html.erb b/app/views/schemes/secondary_client_group.html.erb index 3184fa746..084730a43 100644 --- a/app/views/schemes/secondary_client_group.html.erb +++ b/app/views/schemes/secondary_client_group.html.erb @@ -28,7 +28,7 @@ <% if request.query_parameters["check_answers"] == "true" %> <%= f.hidden_field :check_answers, value: "true" %> <% end %> - + <%= f.govuk_submit "Save and continue" %>
diff --git a/spec/features/schemes_spec.rb b/spec/features/schemes_spec.rb index 391ca44f9..a10061afd 100644 --- a/spec/features/schemes_spec.rb +++ b/spec/features/schemes_spec.rb @@ -321,7 +321,6 @@ RSpec.describe "Schemes scheme Features" do end context "when changing answers" do - it "displays change links" do assert_selector "a", text: "Change", count: 12 end