From 6385fc8e2387a08d5a8bd586d3b8194b82acb313 Mon Sep 17 00:00:00 2001 From: samyou-softwire Date: Tue, 21 Apr 2026 17:30:01 +0100 Subject: [PATCH] fixup! CLDC-4432: Add tests comment test dependencies --- spec/services/bulk_upload/sales/year2025/row_parser_spec.rb | 1 + spec/services/bulk_upload/sales/year2026/row_parser_spec.rb | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb index 22d06413a..99f0774fc 100644 --- a/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2025/row_parser_spec.rb @@ -339,6 +339,7 @@ RSpec.describe BulkUpload::Sales::Year2025::RowParser do describe "invalid fields" do context "when a field has been marked as invalid" do + # field_34 nationality is only shown if field_10 staircasing is no let(:attributes) { setup_section_params.merge({ field_10: 2, field_31: 0 }) } before do diff --git a/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb b/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb index 80a5438e1..f38ed5580 100644 --- a/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb +++ b/spec/services/bulk_upload/sales/year2026/row_parser_spec.rb @@ -345,7 +345,8 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do describe "invalid fields" do context "when a field has been marked as invalid" do - let(:attributes) { setup_section_params.merge({ field_10: "2", field_34: 0 }) } + # field_34 nationality is only shown if field_10 staircasing is no + let(:attributes) { setup_section_params.merge({ field_10: 2, field_34: 0 }) } before do parser.add_invalid_field("field_34") @@ -359,7 +360,7 @@ RSpec.describe BulkUpload::Sales::Year2026::RowParser do end context "when a field has been marked as invalid but it is not routed to" do - let(:attributes) { setup_section_params.merge({ field_10: "1", field_34: 0 }) } + let(:attributes) { setup_section_params.merge({ field_10: 1, field_34: 0 }) } before do parser.add_invalid_field("field_34")