From 63aaa3b7e3f667c9a2ecf6fb644c8c70be780d54 Mon Sep 17 00:00:00 2001
From: natdeanlewissoftwire <nat.dean-lewis@softwire.com>
Date: Mon, 10 Oct 2022 14:58:42 +0100
Subject: [PATCH] feat: remove question dynamic behaviour

---
 app/helpers/question_view_helper.rb              | 2 +-
 app/models/form/question.rb                      | 3 +--
 app/models/form/sales/questions/person2_known.rb | 3 +--
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/app/helpers/question_view_helper.rb b/app/helpers/question_view_helper.rb
index 1b9ffbb20..fc308b835 100644
--- a/app/helpers/question_view_helper.rb
+++ b/app/helpers/question_view_helper.rb
@@ -7,7 +7,7 @@ module QuestionViewHelper
 
   def legend(question, page_header, conditional)
     {
-      text: question.header_partial.present? ? question.header_partial.html_safe : question.header.html_safe,
+      text: question.header.html_safe,
       size: label_size(page_header, conditional),
       tag: label_tag(page_header, conditional),
     }
diff --git a/app/models/form/question.rb b/app/models/form/question.rb
index ff75dead8..227e6079e 100644
--- a/app/models/form/question.rb
+++ b/app/models/form/question.rb
@@ -1,5 +1,5 @@
 class Form::Question
-  attr_accessor :id, :header, :header_partial, :hint_text, :description, :questions,
+  attr_accessor :id, :header, :hint_text, :description, :questions,
                 :type, :min, :max, :step, :width, :fields_to_add, :result_field,
                 :conditional_for, :readonly, :answer_options, :page, :check_answer_label,
                 :inferred_answers, :hidden_in_check_answers, :inferred_check_answers_value,
@@ -16,7 +16,6 @@ class Form::Question
     if hsh
       @check_answer_label = hsh["check_answer_label"]
       @header = hsh["header"]
-      @header_partial = hsh["header_partial"]
       @guidance_partial = hsh["guidance_partial"]
       @guidance_position = GuidancePosition::TOP
       @hint_text = hsh["hint_text"]
diff --git a/app/models/form/sales/questions/person2_known.rb b/app/models/form/sales/questions/person2_known.rb
index 40306c64b..be298c3e5 100644
--- a/app/models/form/sales/questions/person2_known.rb
+++ b/app/models/form/sales/questions/person2_known.rb
@@ -3,8 +3,7 @@ class Form::Sales::Questions::Person2Known < ::Form::Question
     super
     @id = "details_known_2"
     @check_answer_label = "Details known for person 2"
-    @header = "Do you know the details for person 2?
-"
+    @header = "Do you know the details for person 2?"
     @type = "radio"
     @answer_options = ANSWER_OPTIONS
     @page = page